Coverity: CID 400829: Uninit

* src/media/media.c (Fmedia_stream_aspect): Initialize the
potential return value to nil

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Use dup2 if available for -t. Also check for ttyname and isatty in configure.

* configure.ac: Add some additional functions to check and add the
HAVE_ISATTY and HAVE_TTYNAME

* src/emacs.c (main_1): Enhance the logging of -t with ttyname if
it is available.

* src/emacs.c (main_1): Use raw_open instead of open to avoid
using the format conversion of the filename, which at this early
stage is not setup yet.

* src/emacs.c (main_1): use dup2 if available to dup the opened
file (and then close the original descriptor). This is much more
reliable than close then open, since dup2 will make sure the
descriptor number will be the desired.

* src/eval.c (grow_specpdl): If grow_specpdl is called very early
on specpdl_size is 0 and will loop infinitely here because 2 * 0
== 0 ;)

* src/sysdep.c (raw_open): New function that just calls the system
open with no argument conversion at all

* src/sysfile.h: declare the new raw_open function.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: CID 400828 Resource leak

* src/emacs.c (main_1): Make sure second dup is fdesc 1

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

xstrncpy saga

* src/effi.c (Fffi_load_library): use xstrncpy instead of strncpy, strncat

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

xstrncpy saga

* src/dumper.c (pdump_load): Use xstrncpy instead of strcpy

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

xstrncpy saga

* src/sysdep.c (init_system_name): use xstrncpy instead of strcpy

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

xstrncpy saga

* src/sysdep.c (init_system_name): Use xstrncpy instead of strncpy
* src/sysdep.c (readdir): Ditto.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Merge remote-tracking branch 'njsf/for-steve' into for-steve

Merge branch 'master' of ssh://dio.dreamhost.com/~/repos.nelsonferreira.com/git/sxemacs into for-steve

Warn about ignored tty 'with' options. Fix if with missing fi

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Add additional tty lib 'with' options

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

issue warning when no tty nor window system available

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Enable silent building, ie --enable-silent-rules and make V=0

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Correct the remote configuration command message

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

new SXE_CHECK_LINK_LIB macro

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Add summary for additional tty libraries

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Merge remote-tracking branch 'njsf/for-steve' into for-steve

Rename git-to-steve -> git-for-steve

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

xstrncpy saga

* src/fileio.c (file_name_as_directory): Use xstrncpy and change
prototype to take in buffer length.

* src/fileio.c (directory_file_name): Ditto.

* src/fileio.c (Ffile_name_as_directory): properly call
file_name_as_directory with buffer length.
* src/fileio.c (Fdirectory_file_name): ditto.

* src/fileio.c (Fexpand_file_name): Use xstrncat instead of strcat.

* src/fileio.c (Fdirectory_file_name): properly call
directory_file_name with buffer length.

* src/fileio.c (Fsubstitute_in_file_name): use xstrncpy instead of
strcpy keeping track of buffer availability.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Better checking of string and memory operations.
Also, add define FORBID_STRCPY to make runtime asserts on usage of strcpy, strcat and stpcpy.

* src/sysdep.h: Move xstrlen, xstrcmp, xstrcat, xstrncmp,
xstrncat, xstrncpy, xstpcpy, xstpncpy, xmemcmp, xmemcpy to
sxe-utils.h

* src/sysdep.h (x__dirlen): always_inline..
* src/sysdep.h (x__dirname): ditto.
* src/sysdep.h (xdirname): ditto.

* src/sxe-utils.h (xstrlen): move from sysdep.h
* src/sxe-utils.h (xstrcmp): ditto.
* src/sxe-utils.h (xstrncmp): ditto.
* src/sxe-utils.h (xstrncat): ditto.
* src/sxe-utils.h (xstrncpy): ditto.
* src/sxe-utils.h (xstpcpy): ditto.
* src/sxe-utils.h (xstpncpy): ditto.
* src/sxe-utils.h (xmemcmp): ditto.
* src/sxe-utils.h (xmemcpy): ditto.
* src/sxe-utils.h (xmin_size_t): ditto.

* src/sxe-utils.h (no_strcpy): New forbidden strcpy
* src/sxe-utils.h (no_strcat): New forbidden strcat
* src/sxe-utils.h (no_stpcpy): New forbidden stpcpy

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

xstrncpy saga

* src/dumper.c (pdump_load): Use xstrncpy instead of strncpy

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

xstrncpy saga

* src/sysdep.h (xstrncpy): New inline function.
* src/sysdep.h (xstpncpy): Use xstrncpy instead of strncpy

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

xstrncpy saga

* lib-src/fakemail.c (make_file_preface): Use xstrncpy instead of strncpy
* lib-src/fakemail.c (read_header): ditto.
* lib-src/fakemail.c (main): ditto.
* lib-src/gnuclient.c (main): ditto.
* lib-src/gnuserv.c (handle_ipc_request): ditto.
* lib-src/movemail.c (concat): ditto.
* lib-src/movemail.c (pop_retr): ditto.
* lib-src/movemail.c (pop_retr): ditto.
* lib-src/movemail.c (pop_search_top): ditto.
* lib-src/movemail.c (pop_search_top): ditto.
* lib-src/ootags.c (consider_token): ditto.
* lib-src/ootags.c (C_entries): ditto.
* lib-src/ootags.c (Pascal_functions): ditto.
* lib-src/ootags.c (Prolog_functions): ditto.
* lib-src/ootags.c (Erlang_functions): ditto.
* lib-src/ootags.c (substitute): ditto.
* lib-src/ootags.c (savenstr): ditto.
* lib-src/pop.c (pop_stat): ditto.
* lib-src/pop.c (pop_list): ditto.
* lib-src/pop.c (pop_multi_first): ditto.
* lib-src/pop.c (pop_last): ditto.
* lib-src/pop.c (getok): ditto.
* lib-src/yow.c (main): ditto.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

xstrncpy saga

* lib-src/etags.c (xstrncpy): cosmetic changes to xstrncpy macro

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity fixes from Nelson

* merges:
  Kill some spurious whitespace
  Coverity: Resource leak: CID 400020
  Coverity: Resource leak: CID 400022
  Coverity: Resource leak: CID 400023
  Coverity: Resource leak: 400024
  Coverity: Stray pointer arithmetic: CID 400000
  Coverity: Division by zero: CID 400004
  Coverity: Resource leak: CID 400025
  Coverity: Resource Leak: CID 400026
  Don't use strncpy, instead use *dest='\0' followed by strncat (with len-1)
  Coverity: CID 21065: Missing break
  Coverity: DEADCODE: CID 583

Kill some spurious whitespace

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Coverity: Resource leak: CID 400020

* src/editfns.c (Ftemp_directory): Check against 0 too. Unlikely
but possible.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: Resource leak: CID 400022

* src/emacs.c (main_1): Make sure the temporary descriptor is 0,
which makes the "leak" intentional.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: Resource leak: CID 400023

* src/fileio.c (Fcopy_file): make sure ifd is closed

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: Resource leak: 400024

* src/fileio.c (Fdo_auto_save): Make sure file is closed

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: Stray pointer arithmetic: CID 400000

* src/callint.c (Fcall_interactively): add new fcall array, which
is the one allocated, and make args value derive from that. Fill
in function in fcall, and arguments in args.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: Division by zero: CID 400004

* src/media/media.c (Fmedia_stream_aspect): assert for den != 0,
with additional check for the "already crashing" scenario.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: Resource leak: CID 400025

* src/ui/X11/glyphs-x.c (x_init_image_instance_from_eimage): Free
pixtbl if we are not using it...

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: Resource Leak: CID 400026

* src/ui/redisplay.c (add_glyph_rune): Dynarr_free not used
allocated memory.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Don't use strncpy, instead use *dest='\0' followed by strncat (with len-1)

* lib-src/etags.c (write_classname): use xstrncpy instead of strncpy
* lib-src/etags.c (consider_token): ditto.
* lib-src/etags.c (C_entries): ditto.
* lib-src/etags.c (Pascal_functions): ditto.
* lib-src/etags.c (HTML_lables): ditto.
* lib-src/etags.c (Prolog_functions): ditto.
* lib-src/etags.c (Erlang_functions): ditto.
* lib-src/etags.c (substitute): ditto.
* lib-src/etags.c (readline_internal): ditto.
* lib-src/etags.c (savenstr): ditto.
* lib-src/etags.c (concat): ditto.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: CID 21065: Missing break

* src/regex.c (common_op_match_null_string_p): Insert missing
brake for set_number_at case.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: DEADCODE: CID 583

* src/media/media-internal.c (int2ulaw): Do the assignment outside
of if condition to avoid Coverity false positive and improve code
legibility.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity fixes from Nelson

* merges:
  Coverity: Overrun static CID: 138
  Coverity: CID 681: TAINTED STRING
  Coverity: CID 610-DEAD CODE 611-UNUSED VALUE
  Coverity: TOCTOU: CID 387
  Coverity:Tainted string: CID 384
  Coverity: Tainted string: CID 386

Coverity: Overrun static CID: 138

* src/dumper.c (pdump_register_struct): Be even more obvious that
control flow ends on abort, which could fall through in the case
of fatal error.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: CID 681: TAINTED STRING

* src/emacs.c (main): Be even more strict on checks...

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: CID 610-DEAD CODE 611-UNUSED VALUE

* lib-src/etags.c (process_file_name): compr was not being used
before anyway so just remove the assignment from the if statement.

* lib-src/etags.c (process_file_name): only make compressed_value
NULL if it was previously not null. But still free it. This means
that after the free we CANNOT dereference it.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: TOCTOU: CID 387

* lib-src/etags.c (process_file_name): use open/popen then handle
failure, instead of stat. Also, after successful open check it is
regular file, and reject it is not.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity:Tainted string: CID 384

* lib-src/movemail.c (main): Sanitize argv[optind] so one can mark as fixed

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: Tainted string: CID 386

* src/emacs.c (main): Do sanity checking on the arguments

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Really fix FreeBSD -fstack-protector builds

* freebsd-ssp:
  Fix building on FreeBSD with -fstack-protector.

Fix building on FreeBSD with -fstack-protector.

So, as it turns out, FreeBSD CAN build SXEmacs with -fstack-protector.
But only if you DON'T link with libssp.  Who knew?

* m4/sxe-compiler.m4 (SXE_STACK_FLAGS): Re-work so that on FreeBSD
libssp is NOT used, while it is everywhere else.

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Coverity fixes, etc from Nelson

* merges:
  Coverity: TOCTOU: CID 392
  Fix build...
  Coverity: TOCTOU: CID 391
  Coverity: TOCTOU: CID 390
  Coverity: TOCTOU: CID 387
  Better stack-protector behavior in FreeBSD
  Remove forceful disable of ase in Mac OS X
  Coverity CID 52: Forward null
  Slightly better basic type detection.

Coverity: TOCTOU: CID 392

* src/editfns.c (Ftemp_directory): First mkdir then properly
handle errors for the home directory temp directory creation.
Also attempt to create .created_by_sxemacs in case the dir exists.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Fix build...

* src/ui/X11/xgccache.c (gc_cache_lookup): NULL not null

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: TOCTOU: CID 391

* lib-src/ootags.c (process_file): Check for regular file after
open, even if it fails, to improve diagnostic message.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: TOCTOU: CID 390

* lib-src/movemail.c (main): No need to check access to outname,
since open will fail and we are not giving any better diagnosis.

* lib-src/movemail.c (main): Ditto for inname.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Coverity: TOCTOU: CID 387

* lib-src/make-path.c (touchy_mkdir): Try to avoid check/create
race condition by first attempting to create, then check any
error. If it is EEXISTS or directory already exists, then all
good.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Merge branch 'njsf-cov' into for-steve

Better stack-protector behavior in FreeBSD

* m4/sxe-compiler.m4 (SXE_STACK_FLAGS): Forcefully disable stack-protector on freebsd and output warning message..

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Remove forceful disable of ase in Mac OS X

* configure.ac: Remove conditional on opsys != darwin for ase
inclusion. Make conditional on ase components depend on having
dynamic or static ase, not on OS...

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Merge remote-tracking branch 'origin/master' into for-steve

aRts removal from Horst

* merges:
  [aRts removal] Exorcizo te, omnis spiritus immunde, in nomine Dei Patris omnipotentis
  ex{|or}cise the monstrosity that is aRts once and for all

[aRts removal] Exorcizo te, omnis spiritus immunde, in nomine Dei Patris omnipotentis

Signed-off-by: Horst G. Burkhardt III <horst@sxemacs.org>

ex{|or}cise the monstrosity that is aRts once and for all

Signed-off-by: Horst G. Burkhardt III <horst@sxemacs.org>

PROBLEMS update re SSP on FreeBSD from Horst

* merges:
  added warning against SSP on FreeBSD to PROBLEMS file

added warning against SSP on FreeBSD to PROBLEMS file

Signed-off-by: Horst G. Burkhardt III <horst@sxemacs.org>

Coverity CID 52: Forward null

* src/ui/X11/xgccache.c (gc_cache_lookup): Only dereference
cell/cache->head if not NULL

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Merge remote-tracking branch 'origin/master' into for-steve

Merge branch 'openindie'

* openindie:
  Fix build on OpenIndiana

Fix build on OpenIndiana

"Fix" is probably too strong a word here, it wasn't really broken in the
first place.  Just a tiny tweak to autogen.sh was the only "fix" needed
here.

This changeset also documents (in PROBLEMS) the missing deps needed to
build SXEmacs on OpenIndiana.

* autogen.sh: Only add the xpg4/bin directory to the $PATH if this
isn't OpenIndiana.

* PROBLEMS: Document build quirks for OpenIndiana.

Signed-off-by: Steve Youngs <steve@sxemacs.org>

The Great Whitespace Cleanup

* whitespace: (24 commits)
  Whitespace cleanup in src [m-z]
  Whitespace cleanup in src [f-l]
  Whitespace cleanup in src [a-e]
  Whitespace cleanup in src/database
  Whitespace cleanup in src/ent
  Whitespace cleanup in src/events
  Whitespace cleanup in src/m
  Whitespace cleanup in src/media
  Whitespace cleanup in src/mem
  Whitespace cleanup in src/mule
  Whitespace cleanup in src/s
  Whitespace cleanup in src/ui
  Whitespace cleanup in src/ui/lwlib
  Whitespace cleanup in src/ui/X11
  Whitespace cleanup in src/ui/TTY
  Whitespace cleanup in tests
  Whitespace cleanup in modules
  Whitespace cleanup in m4
  Whitespace cleanup in lisp
  Whitespace cleanup in lib-src
  ...

Whitespace cleanup in src [m-z]

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in src [f-l]

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in src [a-e]

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in src/database

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in src/ent

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in src/events

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in src/m

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in src/media

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in src/mem

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in src/mule

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in src/s

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in src/ui

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in src/ui/lwlib

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in src/ui/X11

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in src/ui/TTY

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in tests

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in modules

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in m4

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in lisp

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in lib-src

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in info

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in etc

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in contrib

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Whitespace cleanup in toplevel dir

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Merge branch 'merges'

* merges:
  Conditional definition of HAVE_ALLOCA to avoid meaningless HAVE_ALLOCA redefined warnings...
  Use the real pre-processor var: DEBUG_SXEMACS
  Coverity: Forward NULL: CID 607

Slightly better basic type detection.

* m4/sxe-libc.m4 (SXE_CHECK_BASIC_TYPES): Check for int64_t, intptr_t and sizeof float

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Conditional definition of HAVE_ALLOCA to avoid meaningless HAVE_ALLOCA redefined warnings...

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Merge branch 'for-steve' into njsf-cov

autogen.sh fix from Nelson

* merges:
  Use head -n1 throughout
  Do not confuse GIT with git (or vice-versa)

Use head -n1 throughout

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Do not confuse GIT with git (or vice-versa)

* autogen.sh: Make sure to only conside one line of git describe,
thus taking care of GIT (http://www.gnu.org/software/git/) being
installed instead of git (http://git-scm.com)

* configure.ac: ditto.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

Merge branch 'breathing'

* breathing:
  Be consistent with setting and testing for breathing_space

Be consistent with setting and testing for breathing_space

* src/alloc.c (refill_memory_reserve): Test if breathing_space is
NULL, not zero.
Don't cast the malloc.

* src/alloc.c (garbage_collect_1): Increase breathing_space to,
erm, give us more breathing space.

* src/alloc.c (reinit_alloc_once_early): Set breathing_space to
NULL, not zero.

Signed-off-by: Steve Youngs <steve@sxemacs.org>

Build fix from Sebastian

* merges:
  Summary: fix, make sure ssp actually works before using it Keywords: bldchn diagnostics