Nelson Ferreira [Sat, 14 Jan 2012 04:45:45 +0000 (23:45 -0500)]
Add clear copyright notices to the scripts I contributed
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sat, 14 Jan 2012 01:01:20 +0000 (20:01 -0500)]
Merge branch 'master' of git.sxemacs.org/sxemacs into for-steve
Steve Youngs [Sat, 14 Jan 2012 01:00:28 +0000 (11:00 +1000)]
Merge branch 'trivial'
* trivial:
missing paren
Steve Youngs [Sat, 14 Jan 2012 01:00:12 +0000 (11:00 +1000)]
missing paren
Signed-off-by: Steve Youngs <steve@sxemacs.org>
Nelson Ferreira [Sat, 14 Jan 2012 00:51:20 +0000 (19:51 -0500)]
Fix build
* src/media/media-sox.c (media_sox_open): Fix stupid typo
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Fri, 13 Jan 2012 23:58:52 +0000 (09:58 +1000)]
Coverity fixes from Nelson
* merges:
Coverity: UNINIT: CID 474
Coverity: DEADCODE: CID 578
Coverity: Checked return: CID 582
Coverity: Missing lock: CID 584
Coverity: Negative Returns: CID 585
Coverity: UNINIT: CID 592
Coverity: NO_EFFECT: CID 594
Coverity: UNINIT: CID 593 Make sure file name is not used uninitialized. : Negative Returns: CID 586: Make sure file size is proper
Nelson Ferreira [Fri, 13 Jan 2012 22:59:37 +0000 (17:59 -0500)]
Coverity: UNINIT: CID 474
* src/media/media-sox.c: make sure file conversion is proper
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Fri, 13 Jan 2012 22:56:57 +0000 (17:56 -0500)]
Coverity: DEADCODE: CID 578
* src/print.c (SXE_VSNPRINT_VA): Fix the macro so that error in
snprintf is actually detected, instead of masked because of the
buffer growth loop.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Fri, 13 Jan 2012 22:51:16 +0000 (17:51 -0500)]
Coverity: Checked return: CID 582
* src/media/media-internal.c (parsewave): Check the return of
waverequire, because we are trying to align the stream, but it may
still be fatal. Also fix the "flow" through of fatal error parsing
WAVE file in case wvSoundChuck which do not sound proper.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Fri, 13 Jan 2012 22:43:25 +0000 (17:43 -0500)]
Coverity: Missing lock: CID 584
* src/media/sound-esd.c (sound_esd_play): Surround play_state
change with the necessary lock.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Fri, 13 Jan 2012 22:41:25 +0000 (17:41 -0500)]
Coverity: Negative Returns: CID 585
* src/media/media-internal.c (media_internal_analyse_stream): Only
close the fd if it is valid, ie >= 0.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Fri, 13 Jan 2012 22:37:14 +0000 (17:37 -0500)]
Coverity: UNINIT: CID 592
* src/media/media-internal.c (media_internal_analyse_stream): Make
sure that only if conversion to external format is successful we
try to open the file otherwise return as if file open failed.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Fri, 13 Jan 2012 22:24:14 +0000 (17:24 -0500)]
Coverity: NO_EFFECT: CID 594
* lib-src/gnuslib.c (connect_to_unix_server): Use int for sz which
is the proper return type of snprintf.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Fri, 13 Jan 2012 22:22:09 +0000 (17:22 -0500)]
Coverity: UNINIT: CID 593 Make sure file name is not used uninitialized.
: Negative Returns: CID 586: Make sure file size is proper
* src/media/media-mad.c (media_mad_open): Guard fopen against bad
EXTERNAL_FORMAT conversion.
Also make sure that if ftell is not successful the function terminates
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Thu, 12 Jan 2012 15:38:58 +0000 (01:38 +1000)]
Coverity fixes from Nelson
* merges:
Coverity: NEGATIVE_RETURNS: CID 588
Coverity: NULL returns: CID 589
Coverity: Resource leak: CID 590
Coverity: Resource leak: CID 591
Nelson Ferreira [Thu, 12 Jan 2012 15:23:40 +0000 (10:23 -0500)]
Coverity: NEGATIVE_RETURNS: CID 588
* src/ui/TTY/gpmevent.c (restore_gpm_state): Make sure that fd is
>= 0 before accesing the state array.
* src/ui/TTY/gpmevent.c (store_gpm_state): Ditto.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 12 Jan 2012 15:19:15 +0000 (10:19 -0500)]
Coverity: NULL returns: CID 589
* src/process-unix.c (allocate_pty): Make sure slave_name is not
NULL, since that is a possible return from ttyname.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 12 Jan 2012 15:14:34 +0000 (10:14 -0500)]
Coverity: Resource leak: CID 590
* src/media/media-internal.c (media_internal_analyse_stream): free
data in the case of failed open.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 12 Jan 2012 15:12:50 +0000 (10:12 -0500)]
Coverity: Resource leak: CID 591
* src/media/media-mad.c (media_mad_open): free sd on unknown driver.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Thu, 12 Jan 2012 14:54:28 +0000 (00:54 +1000)]
Compiler Warning fixes from Nelson
* merges:
Fix switch warnings in xlwscrollbar
Fix switch warnings in media
Remove warnings
Nelson Ferreira [Thu, 12 Jan 2012 13:29:59 +0000 (08:29 -0500)]
Fix switch warnings in xlwscrollbar
* src/ui/lwlib/xlwscrollbar.c (call_callbacks): Add default to switch.
* src/ui/lwlib/xlwscrollbar.c (timer): Init reason to
XmCR_NONE. Assert that ARM_NONE cannot happen in switch.
* src/ui/lwlib/xlwscrollbar.c (Select): Add fall-through case for
BUTTON_NONE. Add default case for another switch.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 12 Jan 2012 13:27:26 +0000 (08:27 -0500)]
Fix switch warnings in media
* src/media/media.c: New Qunavailable symbol.
* src/media/media.c (Fmedia_properties): Default driver to
Qunavailable. Add case labels for Xine and Gstreamer.
* src/media/media.c (syms_of_media): init Qunavailable.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 12 Jan 2012 13:25:00 +0000 (08:25 -0500)]
Remove warnings
* src/regex.c (POP_FAILURE_POINT): Move DEBUG_STATEMENT to comply
with C variable declaration rules. Cast the POP_FAILURE_POINTER return
to proper const-ness.
* src/regex.c (re_match_2_internal): Make re_char *'s d and dend
const. Make scope p2 char* const. Make pdummy and sdummy const.
Remove old comment.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Thu, 12 Jan 2012 05:57:56 +0000 (15:57 +1000)]
Improved assertions from Nelson
* merges:
Improved assert messages
Nelson Ferreira [Thu, 12 Jan 2012 05:22:28 +0000 (00:22 -0500)]
Merge branch 'master' of ssh://dio.dreamhost.com/~/repos.nelsonferreira.com/git/sxemacs into for-steve
Steve Youngs [Thu, 12 Jan 2012 05:04:17 +0000 (15:04 +1000)]
Coverity fixes from Nelson
* merges:
Coverity: Reverse INULL: CID 204
Coverity: Reverse INULL: CID:207
Coverity: Reverse Negative: CID:209
COVERITY: Forward NULL: CID:40
COVERITY: Forward NULL CID:46
COVERITY: SECURE_TEMP - CID:345
Small docstring update
Nelson Ferreira [Thu, 12 Jan 2012 03:55:56 +0000 (22:55 -0500)]
Merge branch 'njsf-cov' into for-steve
Nelson Ferreira [Thu, 12 Jan 2012 03:54:57 +0000 (22:54 -0500)]
Coverity: Reverse INULL: CID 204
* modules/ase/ase-interval.c (_ase_unite_intervals_intr): Defer
the call to ase_cartesion_dimension so that it does not try to
derefence an invalid argument. As a side benefit, it will be
faster in the trivial cases.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 12 Jan 2012 03:52:48 +0000 (22:52 -0500)]
Coverity: Reverse INULL: CID:207
* src/media/media.c (media_stream_finalise): Return immediately if the stream is NULL
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 12 Jan 2012 03:51:06 +0000 (22:51 -0500)]
Coverity: Reverse Negative: CID:209
* src/mule/file-coding.c (coding_system_from_mask): Make sure cat
is >=0 before dereferencing in the loop.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 12 Jan 2012 03:46:37 +0000 (22:46 -0500)]
COVERITY: Forward NULL: CID:40
* lib-src/ootags.c (analyse_regex): Return if regex_arg is NULL
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 12 Jan 2012 03:38:35 +0000 (22:38 -0500)]
Improved assert messages
* src/emacs.c: make the assertions_dont_abort a variable instead
of define.
* src/emacs.c (assert_failed): Make the 3rd nested assertion abort
instead of exit. Add an extra newline in the 2nd nested
assertion. Add a short backtrace of up to 32767 entries to the 2nd
nested assertion. Add a backtrace to to the 1st assert_failed.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 12 Jan 2012 03:25:39 +0000 (22:25 -0500)]
Merge branch 'master' of ssh://dio.dreamhost.com/~/repos.nelsonferreira.com/git/sxemacs into for-steve
Nelson Ferreira [Thu, 12 Jan 2012 03:25:12 +0000 (22:25 -0500)]
Merge branch 'njsf-cov' into for-steve
Nelson Ferreira [Thu, 12 Jan 2012 03:23:56 +0000 (22:23 -0500)]
COVERITY: Forward NULL CID:46
* src/print.c (write_string_to_stdio_stream): Add appropriate
diagnostics if no console nor stream provided...
* src/print.c (Fexternal_debugging_output): Explict NULL
initialization.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 12 Jan 2012 01:57:09 +0000 (20:57 -0500)]
COVERITY: SECURE_TEMP - CID:345
* lib-src/movemail.c (lock_dot): Force umask to a sensible default, ie remove all group and other permissions
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 12 Jan 2012 01:37:50 +0000 (20:37 -0500)]
Small docstring update
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Thu, 12 Jan 2012 01:29:10 +0000 (11:29 +1000)]
Refactor lisp-initd from Nelson
* merges:
Fix bug 134:
Nelson Ferreira [Thu, 12 Jan 2012 00:22:27 +0000 (19:22 -0500)]
Bug 134: Remove lisp-initd-dir from startup.el. Usage of path-construct makes it work in lisp-initd.el
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Wed, 11 Jan 2012 04:51:51 +0000 (14:51 +1000)]
Close bug #134
* bug-134:
Ensure lisp-initd-dir is set early enough -- Closes bug #134
Steve Youngs [Wed, 11 Jan 2012 04:50:11 +0000 (14:50 +1000)]
Ensure lisp-initd-dir is set early enough -- Closes bug #134
* lisp/lisp-initd.el (lisp-initd-dir): Move to startup.el to
ensure it is set early enough to take affect.
* lisp/startup.el (lisp-initd-dir): Moved here from
lisp-initd.el.
Signed-off-by: Steve Youngs <steve@sxemacs.org>
Nelson Ferreira [Wed, 11 Jan 2012 00:27:51 +0000 (19:27 -0500)]
Merge branch 'master' of ssh://dio.dreamhost.com/~/repos.nelsonferreira.com/git/sxemacs into for-steve
Nelson Ferreira [Wed, 11 Jan 2012 00:13:08 +0000 (19:13 -0500)]
Fix bug 134:
* lisp/lisp-initd.el (lisp-initd-basename): replaces
lisp-initd-prefix, it is the basename of .el, .elc and dirnames
for the initd.
* lisp/lisp-initd.el (lisp-initd-dir): Delay file expansion, and
as such, just put as default the concat of user-init-directory and
lisp-initd-basename.
* lisp/lisp-initd.el (lisp-initd-compile): update argument
names. Do the proper directory filename expansion here. Use
lisp-initd-basename instead of the literal "init.d"
* lisp/lisp-initd.el (lisp-initd-compile): Issue warning when a
file was not included in compiled initd.el instead of the almost
unnoticeable message in the lossage.
* lisp/lisp-initd.el (lisp-initd-compile-and-load): Update
argument names and interactive usage.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Wed, 11 Jan 2012 00:08:36 +0000 (10:08 +1000)]
Another go at fixing 131
* merges:
Summary: fix, exec elisp in right thread context, closes bug #131 Keywords: bug fix #131
Summary: revert, bring asyneq handling of job events to original state Keywords: bug unfix #131
Summary: fix, another bug 131 attempt, dispatch the Keywords: bug fix #131
Sebastian Freundt [Tue, 10 Jan 2012 23:02:48 +0000 (23:02 +0000)]
Merge branch 'bug/131' into next
* bug/131:
Summary: fix, exec elisp in right thread context, closes bug #131 Keywords: bug fix #131
Summary: revert, bring asyneq handling of job events to original state Keywords: bug unfix #131
Summary: fix, another bug 131 attempt, dispatch the Keywords: bug fix #131
Sebastian Freundt [Tue, 10 Jan 2012 23:00:02 +0000 (23:00 +0000)]
Summary: fix, exec elisp in right thread context, closes bug #131
Keywords: bug fix #131
This changeset now most definitely fixes the sentinel issue of bug #131,
this time the elisp is even executed in the main thread.
* src/events/event-stream.c: move asyneq events (work started, ...) to
execute_internal_event(), was in Fdispatch_event()
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Steve Youngs [Tue, 10 Jan 2012 14:20:28 +0000 (00:20 +1000)]
Byte-compiler warning fixes
* lisp-warnfix:
Fix a couple of byte-compiler warnings.
Steve Youngs [Tue, 10 Jan 2012 14:18:05 +0000 (00:18 +1000)]
Fix a couple of byte-compiler warnings.
* lisp/package-get.el (pui-bootstrap): Call #'pui-list-packages
via #'declare-fboundp to silence byte-compiler.
Also remove fake version hack.
* lisp/ffi/ffi-wand.el (liquid-rescale): Call
#'Wand:liquid-rescale via #'declare-fboundp to silence
byte-compiler.
Signed-off-by: Steve Youngs <steve@sxemacs.org>
Sebastian Freundt [Tue, 10 Jan 2012 11:18:18 +0000 (11:18 +0000)]
Summary: revert, bring asyneq handling of job events to original state
Keywords: bug unfix #131
This effectively reverts all the changes made to the asyneq handling of
job events, and also brings back bug #131.
* src/events/worker-asyneq.c: revert
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Steve Youngs [Tue, 10 Jan 2012 11:15:51 +0000 (21:15 +1000)]
Nuke the bitrotten GTK
* gtk1-removal:
GTK eradication -- plug the holes left from removing gtk files.
GTK eradication -- file removal
GTK eradication -- the build chain.
Steve Youngs [Tue, 10 Jan 2012 10:48:15 +0000 (20:48 +1000)]
GTK eradication -- plug the holes left from removing gtk files.
This changeset fixes all the problems that were the by-product of removing
all the gtk related files from the repo.
* configure.ac: Remove spurious gtk comment
* etc/Makefile.am (dist_etc_DATA): Remove gtkrc.
* lib-src/gnuclient.c (main): No more gtk.
* lisp/cus-edit.el (custom-display): No more gtk.
* lisp/device.el (device-type): Remove spurious gtk comment.
* lisp/device.el (make-gtk-device): Removed.
* lisp/dragdrop.el (gtk-start-drag): Removed.
* lisp/dragdrop.el (gtk-start-drag-region): Removed.
* lisp/faces.el (face-equal): Don't check for gtk device type.
* lisp/faces.el (make-face-bold): Remove gtk case.
* lisp/faces.el (make-face-italic): Ditto.
* lisp/faces.el (make-face-bold-italic): Ditto.
* lisp/faces.el (make-face-unbold): Ditto.
* lisp/faces.el (make-face-unitalic): Ditto.
* lisp/faces.el (init-device-faces): Don't init gtk, it's not
there.
* lisp/faces.el (init-frame-faces): Ditto.
* lisp/faces.el (init-global-faces): Ditto.
* lisp/font-menu.el (font-menu-preferred-resolution): Remove gtk
* lisp/font-menu.el (font-menu-size-scaling): Ditto.
* lisp/font.el (font-window-system-mappings): Ditto.
* lisp/frame.el (make-frame-on-device): Remove spurious gtk doc string.
* lisp/gnuserv.el (gnuserv-main-frame-function): No more gtk.
* lisp/gnuserv.el (gnuserv-visible-frame-function): Ditto.
* lisp/gnuserv.el (make-x-device-with-gtk-fallback): Removed.
* lisp/gnuserv.el (gnuserv-edit-files): Remove gtk stuff.
* lisp/menubar-items.el (default-menubar): Remove sample.gtkrc
* lisp/minibuf.el (read-color-completion-table): No gtk.
* lisp/specifier.el: Ditto.
* src/emacs.c (console_type_create_select_gtk): Removed.
* src/emacs.c (main_1): No gtk.
* src/events/event-stream.c (init_event_stream): No gtk.
* src/events/events.c: Don't #include console-gtk.h
* src/events/events.c (event_equal): No gtk.
* src/events/events.c (event_hash): Ditto.
* src/events/events.c (format_event_object): Ditto.
* src/general-slots.h: Remove gtk.
* src/inline.c: Don't #include gtk headers.
* src/lisp.h: No gtk.
* src/lrecord.h: Remove gtk types.
* src/symsinit.h: Remove gtk.
* src/ui/console.c (select_console_1): No gtk.
* src/ui/console.h: Ditto.
* src/ui/console.h (CONSOLE_TYPESYM_WIN_P): No gtk.
* src/ui/device.c (Fmake_device): No gtk.
* src/ui/device.c (delete_device_internal): Ditto.
* src/ui/device.h (DEVICE_GTK_P): Removed.
* src/ui/device.h (CHECK_GTK_DEVICE): Removed.
* src/ui/device.h (CONCHECK_GTK_DEVICE): Removed.
* src/ui/device.h (DEVICE_MSWINDOWS_P): What the? REEEEMOOOOOVED!!!
* src/ui/device.h (CHECK_MSWINDOWS_DEVICE): Gah! Gone!
* src/ui/device.h (CONCHECK_MSWINDOWS_DEVICE): Sheesh! Outta here!
* src/ui/faces.c (complex_vars_of_faces): No gtk.
* src/ui/frame.h (FRAME_GTK_P): Removed.
* src/ui/frame.h (CHECK_GTK_FRAME): Removed.
* src/ui/frame.h (CONCHECK_GTK_FRAME): Removed.
* src/ui/gutter.c (specifier_vars_of_gutter): No gtk.
* src/ui/redisplay.c (init_redisplay): No gtk.
* src/ui/toolbar.c: No gtk.
* src/ui/window.c (specifier_vars_of_window): Ditto.
* tests/Makefile.am (gtk_tests): Removed.
* tests/Makefile.am (EXTRA_DIST): Removed gtk tests
* src/events/events.h: Don't #include gdk stuff.
* m4/sxe-aux.m4 (__SXE_MAKE_ADDER): Nuke gtk.
* src/sysfile.h: No gtk.
* src/ui/glyphs.c (pixmap_to_lisp_data): Remove gtk version.
Signed-off-by: Steve Youngs <steve@sxemacs.org>
Sebastian Freundt [Tue, 10 Jan 2012 09:23:10 +0000 (09:23 +0000)]
Summary: fix, another bug 131 attempt, dispatch the
Keywords: bug fix #131
* src/events/worker-asyneq.c: dispatch directly
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Steve Youngs [Tue, 10 Jan 2012 08:23:16 +0000 (18:23 +1000)]
GTK eradication -- file removal
Signed-off-by: Steve Youngs <steve@sxemacs.org>
Steve Youngs [Tue, 10 Jan 2012 07:43:57 +0000 (17:43 +1000)]
GTK eradication -- the build chain.
The GTK code in SXEmacs has been stagnating since 2000, 4 years before
SXEmacs even came into existance. It was GTK version 1. Nobody, nowhere
uses GTKv1 any more, so this stuff is going to /dev/null hell!
* src/ui/Makefile.am: Don't add `Gtk' to SUBDIRS
* src/Makefile.am: Don't add gtk to pdumplibs.
* lisp/Makefile.am (corelispels): Remove all the gtk/gnome elisp.
* lisp/dumped-lisp.el: Don't dump any gtk lisp.
* m4/sxe-summary.m4: No more gtk.
* m4/sxe-gui.m4 (SXE_CHECK_XT_DEPENDENCIES): Remove gtk stuff.
* m4/sxe-gui.m4 (SXE_CHECK_GTK_DEPENDENCIES): Removed.
* m4/sxe-gui.m4 (SXE_CHECK_UI_SUFFICIENCY): Don't subst gtk obj's
* configure.ac: Remove all gtk nonsense.
Signed-off-by: Steve Youngs <steve@sxemacs.org>
Steve Youngs [Tue, 10 Jan 2012 00:44:42 +0000 (10:44 +1000)]
Really fix bug 131, for real this time
* crash-test:
Fix the fix that fixes the fix to fix bug 131
Steve Youngs [Tue, 10 Jan 2012 00:43:58 +0000 (10:43 +1000)]
Fix the fix that fixes the fix to fix bug 131
* src/events/worker-asyneq.c (eq_worker_eaten_myself): Don't call
asyneq_handle_event()
* src/events/worker-asyneq.c (eq_worker_work_started): Ditto.
Signed-off-by: Steve Youngs <steve@sxemacs.org>
Steve Youngs [Mon, 9 Jan 2012 21:20:31 +0000 (07:20 +1000)]
Closes bug #131 from Sebastian
* merges:
Summary: cosmetics, clean up event-stream code Keywords: code hygiene
Summary: fix, actually dispatch events, fixes bug #131 Keywords: bug fix #131
Sebastian Freundt [Mon, 9 Jan 2012 20:57:45 +0000 (20:57 +0000)]
Merge branch 'code/hygiene' into next
* code/hygiene:
Summary: cosmetics, clean up event-stream code Keywords: code hygiene
Sebastian Freundt [Mon, 9 Jan 2012 15:12:36 +0000 (15:12 +0000)]
Summary: cosmetics, clean up event-stream code
Keywords: code hygiene
This changeset brings event-stream.c to 21st century coding style and
our 80 cols rule.
* src/events/event-stream.c: big refactoring
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Mon, 9 Jan 2012 20:57:04 +0000 (20:57 +0000)]
Merge branch 'bug/131' into next
* bug/131:
Summary: fix, actually dispatch events, fixes bug #131 Keywords: bug fix #131
Sebastian Freundt [Mon, 9 Jan 2012 13:13:55 +0000 (13:13 +0000)]
Summary: fix, actually dispatch events, fixes bug #131
Keywords: bug fix #131
This changeset makes sure that the communication between REPL event
queue and delegation event queue (the one for the worker threads)
actually work in both directions. Events put on the REPL event queue
from within jobs that have been delegated are now announced to the event
queue handler and hence executed, which in particular was the reason the
sentinel wasn't invoked as described in bug #131.
* src/events/worker-asyneq.c: call asyneq_handle_event() after enqueuing
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Steve Youngs [Mon, 9 Jan 2012 00:15:08 +0000 (10:15 +1000)]
Build clean up, etc. from Sebastian
* merges:
Summary: cosmetics, conditionalise seemingly unused vars in movemail.c Keywords: refactor warn-fix
Summary: cosmetics, refactor large parts of make-docfile.c Keywords: refactor warn-fix
Summary: fix, -Winline -> only if maximum warning output Keywords: bldchn code hygiene warn-fix
Summary: fix, unused warnings in gnuserv.c Keywords: bldchn code hygiene warn-fix
Summary: fix, signedness and unused warnings in gnuserv et al. Keywords: bldchn code hygiene warn-fix
Summary: fix, clean up signedness problem in gnuserv and friends Keywords: bldchn code hygiene warn-fix
Summary: cosmetics, declare yow internal functions static Keywords: bldchn
Summary: cosmetics, fix some signedness and shadow warnings in gnuclient Keywords: bldchn
Summary: cosmetics, fix some warnings about signedness Keywords: bldchn
Summary: chore, deactivate some warnings again (if not aggressive) Keywords: bldchn
Sebastian Freundt [Sun, 8 Jan 2012 21:43:56 +0000 (21:43 +0000)]
Merge branch 'bld/warn-fix' into next
* bld/warn-fix:
Summary: cosmetics, conditionalise seemingly unused vars in movemail.c Keywords: refactor warn-fix
Summary: cosmetics, refactor large parts of make-docfile.c Keywords: refactor warn-fix
Sebastian Freundt [Sun, 8 Jan 2012 21:43:08 +0000 (21:43 +0000)]
Summary: cosmetics, conditionalise seemingly unused vars in movemail.c
Keywords: refactor warn-fix
This changeset conditionalises on MAIL_USE_POP to fix warnings that
arise from writing to unused variables.
* lib-src/movemail.c: put MAIL_USE_POP guards around poppass var
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Sebastian Freundt [Sun, 8 Jan 2012 11:09:53 +0000 (11:09 +0000)]
Summary: cosmetics, refactor large parts of make-docfile.c
Keywords: refactor warn-fix
This changeset refactors large parts of make-docfile.c, i.e. kill unused
code and kludges, adhere to our 80 column policy and maintain our coding
style throughout the file.
* lib-src/make-docfile.c: refactor
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Steve Youngs [Sun, 8 Jan 2012 04:47:59 +0000 (14:47 +1000)]
Fix if/else scope in yow.c from Rudi
* merges-rudi:
fix yow.c, include assert.h (was missing since
cb837c1c)
fix yow.c, correct else scope (broken since
cb837c1c)
Sebastian Freundt [Sun, 8 Jan 2012 03:21:30 +0000 (03:21 +0000)]
Merge branch 'bld/warn-fix' into next
* bld/warn-fix:
Summary: fix, -Winline -> only if maximum warning output Keywords: bldchn code hygiene warn-fix
Sebastian Freundt [Sun, 8 Jan 2012 00:59:50 +0000 (00:59 +0000)]
Summary: fix, -Winline -> only if maximum warning output
Keywords: bldchn code hygiene warn-fix
This changeset fixes some inline related warnings by turning them off.
* m4/sxe-acx_pthread.m4: enable -Winline only with_maximum_warning_output
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Sebastian Freundt [Sun, 8 Jan 2012 03:21:04 +0000 (03:21 +0000)]
Merge branch 'bld/warn-fix' into next
* bld/warn-fix:
Summary: fix, unused warnings in gnuserv.c Keywords: bldchn code hygiene warn-fix
Summary: fix, signedness and unused warnings in gnuserv et al. Keywords: bldchn code hygiene warn-fix
Summary: fix, clean up signedness problem in gnuserv and friends Keywords: bldchn code hygiene warn-fix
Sebastian Freundt [Sun, 8 Jan 2012 00:40:51 +0000 (00:40 +0000)]
Summary: fix, unused warnings in gnuserv.c
Keywords: bldchn code hygiene warn-fix
This changeset brings gnuserv.c to 21st century coding style and
fixes warnings along.
Note to myself: gnuserv is not v6-ready! Several locations assume for
inet addresses to fit in an unsigned long which is so 1980.
* lib-src/gnuserv.c: fix warnings and ennicen syntax
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Sebastian Freundt [Sat, 7 Jan 2012 23:53:28 +0000 (23:53 +0000)]
Summary: fix, signedness and unused warnings in gnuserv et al.
Keywords: bldchn code hygiene warn-fix
This changeset brings some of the stuff in gnuclient.c to 21st century
coding style and fixes warnings along.
* lib-src/gnuclient.c: fix warnings and ennicen syntax
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Conflicts:
lib-src/gnuclient.c
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Sebastian Freundt [Sat, 7 Jan 2012 23:46:38 +0000 (23:46 +0000)]
Summary: fix, clean up signedness problem in gnuserv and friends
Keywords: bldchn code hygiene warn-fix
This changeset introduces SNPRINTF, a macro that also ascertains that
its result is >=0 and < than the size of the buffer printed into.
* lib-src/gnuclient.c: migrate to SNPRINTF
* lib-src/gnuserv.c: migrate to SNPRINTF
* lib-src/gnuserv.h: provide SNPRINTF macro
* lib-src/gnuslib.c: migrate to SNPRINTF
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Conflicts:
lib-src/gnuclient.c
lib-src/gnuserv.c
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Sebastian Freundt [Sun, 8 Jan 2012 03:15:39 +0000 (03:15 +0000)]
Merge branch 'bldchn' into next
* bldchn:
Summary: cosmetics, declare yow internal functions static Keywords: bldchn
Summary: cosmetics, fix some signedness and shadow warnings in gnuclient Keywords: bldchn
Summary: cosmetics, fix some warnings about signedness Keywords: bldchn
Summary: chore, deactivate some warnings again (if not aggressive) Keywords: bldchn
Sebastian Freundt [Fri, 6 Jan 2012 19:34:52 +0000 (19:34 +0000)]
Summary: cosmetics, declare yow internal functions static
Keywords: bldchn
* lib-src/yow.c: make local things static
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Fri, 6 Jan 2012 19:33:27 +0000 (19:33 +0000)]
Summary: cosmetics, fix some signedness and shadow warnings in gnuclient
Keywords: bldchn
* lib-src/gnuclient.c: fix signedness warnings
fix shadow warnings
adhere to our coding style
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Conflicts:
lib-src/gnuclient.c
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Sebastian Freundt [Fri, 6 Jan 2012 19:06:26 +0000 (19:06 +0000)]
Summary: cosmetics, fix some warnings about signedness
Keywords: bldchn
* lib-src/gnuslib.c: treat ints returned by snprintf() as size_t for
assertions
* src/regex.c: strictly return values from the enum as declared
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Conflicts:
lib-src/gnuslib.c
lib-src/profile.c
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Sebastian Freundt [Fri, 6 Jan 2012 18:58:51 +0000 (18:58 +0000)]
Summary: chore, deactivate some warnings again (if not aggressive)
Keywords: bldchn
This changeset demotes some of the warning flags again to the special
--with-maximum-warning-output option.
* m4/sxe-compiler.m4: conditionalise on some warning switches again
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Steve Youngs [Sun, 8 Jan 2012 03:07:51 +0000 (13:07 +1000)]
Close bug #133 from Sebastian
* merges:
Summary: fix, bug 133, for real now Keywords: bug fix
Summary: cosmetics, prescind from using inlines for trivial one-off stuff Keywords: bldchn code hygiene
Summary: fix, final, use unsigned ints in modifier setup, fixes bug #133 Keywords: bug fix
Summary: fix, tentative, use unsigned int:1 to avoid overflows, fixes bug #133 Keywords: bug fix
Sebastian Freundt [Sun, 8 Jan 2012 03:01:27 +0000 (03:01 +0000)]
Merge branch 'bug/133' into for-steve
* bug/133:
Summary: fix, bug 133, for real now Keywords: bug fix
Sebastian Freundt [Sun, 8 Jan 2012 02:42:39 +0000 (02:42 +0000)]
Summary: fix, bug 133, for real now
Keywords: bug fix
This changeset fixes 133 by doing everything right.
* src/ui/X11/event-Xt.c: actually reset the old modifier to the bit it
represents, this should fix 133 once and forever
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Sebastian Freundt [Sat, 7 Jan 2012 22:38:16 +0000 (22:38 +0000)]
Merge remote-tracking branch 'rudi/fixes' into for-steve-from-rudi
* rudi/fixes:
fix yow.c, include assert.h (was missing since
cb837c1c)
fix yow.c, correct else scope (broken since
cb837c1c)
Ruediger Meier [Sat, 7 Jan 2012 18:53:16 +0000 (19:53 +0100)]
fix yow.c, include assert.h (was missing since
cb837c1c)
Ruediger Meier [Sat, 7 Jan 2012 18:45:31 +0000 (19:45 +0100)]
fix yow.c, correct else scope (broken since
cb837c1c)
Sebastian Freundt [Sat, 7 Jan 2012 16:10:28 +0000 (16:10 +0000)]
Summary: cosmetics, prescind from using inlines for trivial one-off stuff
Keywords: bldchn code hygiene
* src/ui/X11/event-Xt.c: superfluous inlines are removed
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Sebastian Freundt [Sat, 7 Jan 2012 16:08:00 +0000 (16:08 +0000)]
Merge branch 'bug/133' into for-steve
* bug/133:
Summary: fix, final, use unsigned ints in modifier setup, fixes bug #133 Keywords: bug fix
Sebastian Freundt [Sat, 7 Jan 2012 16:07:36 +0000 (16:07 +0000)]
Summary: fix, final, use unsigned ints in modifier setup, fixes bug #133
Keywords: bug fix
This fixes bug 133 finally.
* src/ui/X11/event-Xt.c: make the bit set a bit wider
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Sebastian Freundt [Sat, 7 Jan 2012 10:22:13 +0000 (10:22 +0000)]
Merge branch 'bug/133' into for-steve
* bug/133:
Summary: fix, tentative, use unsigned int:1 to avoid overflows, fixes bug #133 Keywords: bug fix
Sebastian Freundt [Sat, 7 Jan 2012 10:19:37 +0000 (10:19 +0000)]
Summary: fix, tentative, use unsigned int:1 to avoid overflows, fixes bug #133
Keywords: bug fix
This fixes bug 133 tentatively, a problem with the bitset seems to spoil
the big de-nestification. However, it appears the bits have to be wider
than I planned them to be, this is up to investigation, could be an
alignment issue.
* src/ui/X11/event-Xt.c: make the bit set a bit wider
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Steve Youngs [Fri, 6 Jan 2012 23:39:08 +0000 (09:39 +1000)]
from Sebastian
* merges:
Summary: chore, kick ase extern inline Keywords: code hygiene build clang
Summary: chore, don't check for extern inline support anymore Keywords: code hygiene build clang
Summary: chore, crunch the number of extern_inline definitions Keywords: code hygiene build clang
Summary: chore, refactor nested function construct in event-Xt.c Keywords: build clang
Summary: chore, replace nested function construct by cpp equivalent Keywords: build clang
Conflicts:
src/ui/X11/event-Xt.c -- trivial, resolved.
Signed-off-by: Steve Youngs <steve@sxemacs.org>
Sebastian Freundt [Fri, 6 Jan 2012 12:54:51 +0000 (12:54 +0000)]
Merge branch 'bld/clang' into next
* bld/clang:
Summary: chore, kick ase extern inline Keywords: code hygiene build clang
Summary: chore, don't check for extern inline support anymore Keywords: code hygiene build clang
Summary: chore, crunch the number of extern_inline definitions Keywords: code hygiene build clang
Summary: chore, refactor nested function construct in event-Xt.c Keywords: build clang
Summary: chore, replace nested function construct by cpp equivalent Keywords: build clang
Sebastian Freundt [Fri, 6 Jan 2012 12:24:45 +0000 (12:24 +0000)]
Summary: chore, kick ase extern inline
Keywords: code hygiene build clang
This changeset reviews ase code that erroneously used extern inlines
directly, transform them to static inlines.
* modules/ase/ase-cartesian.h: extern inline -> static inline
* modules/ase/ase-heap.h: extern inline -> static inline
* modules/ase/ase-neighbourhood.h: extern inline -> static inline
* modules/ase/ase.h: extern inline -> static inline
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Fri, 6 Jan 2012 10:34:52 +0000 (10:34 +0000)]
Summary: chore, don't check for extern inline support anymore
Keywords: code hygiene build clang
This changeset drops the check for extern inline support (and compiler
allergies to it) altogether, resorting instead to static inlines.
* m4/sxe-compiler.m4: do not check for extern inline compiler allergies
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Fri, 6 Jan 2012 09:03:48 +0000 (09:03 +0000)]
Summary: chore, crunch the number of extern_inline definitions
Keywords: code hygiene build clang
This changeset drops transitional extern_inline definitions so only pure
C99 static inlines are used from now on.
* src/sxe-utils.h: drop conditional extern_inline definitions leaving
only static inline as expansion
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Steve Youngs [Thu, 5 Jan 2012 13:26:23 +0000 (23:26 +1000)]
Warning fixes from Nelson
* merges:
Remove casts which were not needed and causing comparison sign mismatch
Add prototype for emacs_tparam to avoid warning
Change the pre-processor conditional to check for MPC_SET_UI_FR to avoid warning
Add new Assert-Equal and Assert-Not-Equal macros to test-harness, which print the actual values in case of failure. Use instead of (Assert (equal)) and (Assert (not (equal)))
Nelson Ferreira [Thu, 5 Jan 2012 06:35:08 +0000 (01:35 -0500)]
Remove casts which were not needed and causing comparison sign mismatch
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 5 Jan 2012 06:33:23 +0000 (01:33 -0500)]
Add prototype for emacs_tparam to avoid warning
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 5 Jan 2012 06:32:39 +0000 (01:32 -0500)]
Change the pre-processor conditional to check for MPC_SET_UI_FR to avoid warning
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 5 Jan 2012 06:31:31 +0000 (01:31 -0500)]
Add new Assert-Equal and Assert-Not-Equal macros to test-harness, which print the actual values in case of failure. Use instead of (Assert (equal)) and (Assert (not (equal)))
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Thu, 5 Jan 2012 05:13:45 +0000 (15:13 +1000)]
Warning fixes from Nelson
* merges:
More warning suppressions
More warning suppression
Get rid of the slew of warning in tags code
Nelson Ferreira [Thu, 5 Jan 2012 04:05:52 +0000 (23:05 -0500)]
More warning suppressions
* lib-src/gnuslib.c (connect_to_unix_server): Use size_t for sz
* src/ui/X11/event-Xt.c (x_reset_modifier_mapping): Add full
prototype to auto functions
* src/ui/glyphs-eimage.c (png_instantiate): use png_uint_32 in loop
* src/ui/lwlib/xlwmenu.c (parameterize_string): add new offset to
keep signedness in comparison
* src/ui/X11/glyphs-x.c (x_subwindow_query_geometry): add prototyp
* lib-src/gnuslib.c (connect_to_internet_server): Use size_t to
compare with sizeof.
* src/alloc.c (garbage_collect): ditto.
* src/buffer.c (Fgenerate_new_buffer_name): ditto.
* src/dumper.c (pdump_file_try): ditto.
* src/dumper.c (pdump_load): ditto.
* src/editfns.c (Fencode_time): ditto.
* src/editfns.c (Fencode_btime): ditto.
* src/editfns.c (Fcurrent_time_zone): ditto.
* src/extents.c (print_extent_1): ditto.
* src/mule/input-method-xlib.c (EmacsXtCvtStringToXIMStyles): ditto.
* src/mule/input-method-xlib.c (describe_Window): ditto.
* src/print.c (SXE_VSNPRINT_VA): ditto.
* src/print.c (write_hex_ptr): ditto.
* src/print.c (printing_major_badness): ditto.
* src/process-unix.c (allocate_pty_the_old_fashioned_way): ditto.
* src/process-unix.c (unix_open_network_stream): ditto.
* src/process-unix.c (unix_open_network_server_stream): ditto.
* src/process.c (make_process_internal): ditto.
* src/strftime.c (add_num_time_t): ditto.
* src/ui/TTY/objects-tty.c (Ffind_tty_color): ditto.
* src/ui/TTY/objects-tty.c (Ftty_registered_color_list): ditto.
* src/ui/TTY/redisplay-tty.c (term_get_fkeys_1): ditto.
* src/ui/X11/device-x.c (read_locale_specific_resources): ditto.
* src/ui/X11/device-x.c (x_init_device): ditto.
* src/ui/X11/device-x.c (signal_if_x_error): ditto.
* src/ui/X11/dialog-x.c (dbox_descriptor_to_widget_value): ditto.
* src/ui/X11/event-Xt.c (x_keysym_to_emacs_keysym): ditto.
* src/ui/X11/event-Xt.c (describe_event): ditto.
* src/ui/X11/frame-x.c (color_to_string): ditto.
* src/ui/X11/frame-x.c (x_set_initial_frame_size): ditto.
* src/ui/X11/frame-x.c (Fx_window_id): ditto.
* src/ui/X11/objects-x.c (truename_via_random_props): ditto.
* src/ui/X11/scrollbar-x.c (x_create_scrollbar_instance): ditto.
* src/ui/glyphs-eimage.c (tiff_error_func): ditto.
* src/ui/glyphs-eimage.c (tiff_warning_func): ditto.
* src/ui/lwlib/lwlib-Xaw.c (make_dialog): ditto.
* src/ui/lwlib/lwlib-Xaw.c (make_dialog): ditto.
* src/ui/lwlib/xlwgauge.c (GaugeExpose): ditto.
* src/ui/lwlib/xlwgauge.c (MaxLabel): ditto.
* src/ui/lwlib/xlwmenu.c (parameterize_string): ditto.
* src/ui/lwlib/xlwtabs.c (XawTabsSetTop): ditto.
* src/ui/redisplay.c (decode_mode_spec): ditto.
* src/ui/redisplay.c (decode_mode_spec): ditto.
* src/ui/redisplay.c (decode_mode_spec): ditto.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>