* nnmail.el (nnmail-expiry-target): Fix custom type.
+2008-10-02 Glenn Morris <rgm@gnu.org>
+
+ * mm-util.el (mm-codepage-setup): Tweak codepage error.
+ Silence compiler warning.
+
+2008-10-01 Magnus Henoch <mange@freemail.hu>
+
+ * tls.el (open-tls-stream): Show the actual command being
+ executed, instead of the format string.
+
2008-10-01 Katsumi Yamaoka <yamaoka@jpl.org>
* lpath.el: Fbind codepage-setup for Emacs 23.
+2008-09-30 Chong Yidong <cyd@stupidchicken.com>
+
+ * mml.el (mml-menu): Don't assume mml2015 is bound.
+
2008-09-29 Katsumi Yamaoka <yamaoka@jpl.org>
* gnus-art.el (gnus-article-read-summary-keys): Check if summary window
exists.
+2008-09-27 Glenn Morris <rgm@gnu.org>
+
+ * gnus-util.el (mail-header-remove-comments): Autoload it.
+
+2008-09-27 Andreas Schwab <schwab@suse.de>
+
+ * gnus-util.el (gnus-split-references): Strip comments.
+ (gnus-parent-id): Likewise.
+
2008-09-26 Reiner Steib <Reiner.Steib@gmx.de>
* message.el (message-confirm-send): Fix version.
summary line gnus-number property and ignore them (with a warning
message).
+2008-09-10 Katsumi Yamaoka <yamaoka@jpl.org>
+
+ * gnus-group.el (gnus-group-make-useful-group): Don't use the compiler
+ macro caddr in the interactive form since it won't be expanded.
+
+2008-09-09 Katsumi Yamaoka <yamaoka@jpl.org>
+
+ * gnus-art.el (gnus-mime-set-charset-parameters): Add new argument
+ `charset'; fix name of function called recursively.
+ (gnus-mime-view-part-as-charset): Don't bind gnus-newsgroup-charset.
+
+2008-09-09 Katsumi Yamaoka <yamaoka@jpl.org>
+
+ * gnus-art.el (gnus-mime-strip-charset-parameters): Remove.
+ (gnus-mime-set-charset-parameters): New function.
+ (gnus-mime-view-part-as-charset): Use it to correctly display part
+ specifying wrong charset.
+
2008-09-08 David Engster <dengste@eml.cc>
* nnmairix.el (nnmairix-create-server-and-default-group): Require match
* gnus-art.el (gnus-mime-inline-part): Decode parts according to
the coding cookies; decompress compressed parts.
- * mml.el (mml-generate-mime-1): Add the charaset parameter according
+ * mml.el (mml-generate-mime-1): Add the charset parameter according
to the value which a user specified manually or the coding cookie.
* mm-util.el (mm-string-to-multibyte): New function.
2003-10-24 Teodor Zlatanov <tzz@lifelogs.com>
* spam.el (spam-ham-copy-or-move-routine): Do not delete if copy
- is t, also don't intepret the list of groups as a list of lists.
+ is t, also don't interpret the list of groups as a list of lists.
(spam-mark-spam-as-expired-and-move-routine)
(spam-ham-copy-or-move-routine): Delete articles only if 1 or
more groups were specified (and "copy" was not specified for
broken connections by opening a new connection and repeating the
failed command.
(nntp-retrieve-headers-with-xover): Some NNTP servers respond to
- XOVER commands preceeding the active articles with the nov entry
+ XOVER commands preceding the active articles with the nov entry
of the first available article. When gnus connected to such a
server, the unexpected nov entry would result in duplicate lines
in the agent's overview file. This patch fixes the duplicate
lines problem and improves performance by skipping over all
- articles IDs that preceed the first nov entry in the server's
+ articles IDs that precede the first nov entry in the server's
reply.
2002-12-11 Katsumi Yamaoka <yamaoka@jpl.org>
2002-10-22 TSUCHIYA Masatoshi <tsuchiya@namazu.org>
- * pgg.el (pgg-snarf-keys): Do not refer unbinded local variables.
+ * pgg.el (pgg-snarf-keys): Do not refer unbound local variables.
2002-10-22 Simon Josefsson <jas@extundo.com>
2002-05-18 Jesper Harder <harder@ifa.au.dk>
- * gnus-sum.el (gnus-dependencies-add-header): Avoid one unecessary
+ * gnus-sum.el (gnus-dependencies-add-header): Avoid one unnecessary
call to gnus-parent-id when we check for References loops.
(gnus-summary-prepare-threads): Avoid simplifying every Subject
twice by saving the simplified subject string in simp-subject.
2002-04-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
- * gnus-art.el (gnus-article-prepare): Place point on the emtpy
+ * gnus-art.el (gnus-article-prepare): Place point on the empty
header line.
2002-04-11 Per Abrahamsen <abraham@dina.kvl.dk>
expiry-target. (Otherwise nnml will be in a inconsistent internal
state causing all kind of problems.)
(nnml-request-expire-articles): If `nnml-article-to-file' or
- `file-attributes' failes, return article as un-expirable instead
+ `file-attributes' fail, return article as un-expirable instead
of treating it as expired.
2001-08-31 Sam Steingold <sds@gnu.org>
(mm-string-to-multibyte contents)))
(goto-char b)))))
-(defun gnus-mime-strip-charset-parameters (handle)
- "Strip charset parameters from HANDLE."
+(defun gnus-mime-set-charset-parameters (handle charset)
+ "Set CHARSET to parameters in HANDLE.
+CHARSET may either be a string or a symbol."
+ (unless (stringp charset)
+ (setq charset (symbol-name charset)))
(if (stringp (car handle))
- (mapc #'gnus-mime-strip-charset-parameters (cdr handle))
+ (dolist (h (cdr handle))
+ (gnus-mime-set-charset-parameters h charset))
(let* ((type (mm-handle-type (if (equal (mm-handle-media-type handle)
"message/external-body")
(progn
(mm-extern-cache-contents handle))
(mm-handle-cache handle))
handle)))
- (charset (assq 'charset (cdr type))))
- (when charset
- (delq charset type)))))
+ (param (assq 'charset (cdr type))))
+ (if param
+ (setcdr param charset)
+ (setcdr type (cons (cons 'charset charset) (cdr type)))))))
(defun gnus-mime-view-part-as-charset (&optional handle arg)
"Insert the MIME part under point into the current buffer using the
(let ((handle (or handle (get-text-property (point) 'gnus-data)))
(fun (get-text-property (point) 'gnus-callback))
(gnus-newsgroup-ignored-charsets 'gnus-all)
- gnus-newsgroup-charset form preferred parts)
+ charset form preferred parts)
(when handle
(when (prog1
(and fun
- (setq gnus-newsgroup-charset
+ (setq charset
(or (cdr (assq
arg
gnus-summary-show-article-charset-alist))
(mm-read-coding-system "Charset: "))))
(if (mm-handle-undisplayer handle)
(mm-remove-part handle)))
- (gnus-mime-strip-charset-parameters handle)
+ (gnus-mime-set-charset-parameters handle charset)
(when (and (consp (setq form (cdr-safe fun)))
(setq form (ignore-errors
(assq 'gnus-mime-display-alternative form)))
(let ((entry (assoc (completing-read "Create group: " gnus-useful-groups
nil t)
gnus-useful-groups)))
- (list (cadr entry) (caddr entry))))
+ (list (cadr entry)
+ ;; Don't use `caddr' here since macros within the `interactive'
+ ;; form won't be expanded.
+ (car (cddr entry)))))
(setq method (gnus-copy-sequence method))
(let (entry)
(while (setq entry (memq (assq 'eval method) method))
(autoload 'rmail-show-message "rmail")
(autoload 'nnheader-narrow-to-headers "nnheader")
(autoload 'nnheader-replace-chars-in-string "nnheader")
+(autoload 'mail-header-remove-comments "mail-parse")
(eval-and-compile
(cond
(defun gnus-split-references (references)
"Return a list of Message-IDs in REFERENCES."
(let ((beg 0)
- (references (or references ""))
+ (references (mail-header-remove-comments (or references "")))
ids)
(while (string-match "<[^<]+[^< \t]" references beg)
(push (substring references (match-beginning 0) (setq beg (match-end 0)))
(while (nthcdr n ids)
(setq ids (cdr ids)))
(car ids))
- (when (string-match "\\(<[^<]+>\\)[ \t]*\\'" references)
- (match-string 1 references)))))
+ (let ((references (mail-header-remove-comments references)))
+ (when (string-match "\\(<[^<]+>\\)[ \t]*\\'" references)
+ (match-string 1 references))))))
(defun gnus-buffer-live-p (buffer)
"Say whether BUFFER is alive or not."
(let ((completion-ignore-case t)
(candidates (if (fboundp 'cp-supported-codepages)
(cp-supported-codepages)
- ;; Removed in Emacs 23 (unicode), sosignal an error:
- (error "`codepage-setup' is obsolete in this Emacs version."))))
+ ;; Removed in Emacs 23 (unicode), so signal an error:
+ (error "`codepage-setup' not present in this Emacs version."))))
(list (completing-read "Setup DOS Codepage: (default 437) " candidates
nil t nil nil "437"))))
(when alias
(intern (format "windows-%s" number)))))
(let* ((cp (intern (format "cp%s" number))))
(unless (mm-coding-system-p cp)
- (codepage-setup number))
+ (if (fboundp 'codepage-setup) ; silence compiler
+ (codepage-setup number)
+ (error "`codepage-setup' not present in this Emacs version.")))
(when (and alias
;; Don't add alias if setup of cp failed.
(mm-coding-system-p cp))
["PGG manual" (lambda () (interactive) (message-info mml2015-use))
;; XEmacs barfs on :visible.
,@(if (featurep 'xemacs) nil
- '(:visible (equal mml2015-use 'pgg)))
+ '(:visible (and (boundp 'mml2015-use) (equal mml2015-use 'pgg))))
,@(if (featurep 'xemacs) '(t)
'(:help "Display the PGG manual"))]
- ["EasyPG manual" (lambda () (interactive) (message-info mml2015-use))
+ ["EasyPG manual" (lambda () (interactive) (require 'mml2015) (message-info mml2015-use))
;; XEmacs barfs on :visible.
,@(if (featurep 'xemacs) nil
- '(:visible (equal mml2015-use 'epg)))
+ '(:visible (and (boundp 'mml2015-use) (equal mml2015-use 'epg))))
,@(if (featurep 'xemacs) '(t)
'(:help "Display the EasyPG manual"))]))
(with-current-buffer buffer
(message "Opening TLS connection to `%s'..." host)
(while (and (not done) (setq cmd (pop cmds)))
- (message "Opening TLS connection with `%s'..." cmd)
(let ((process-connection-type tls-process-connection-type)
+ (formatted-cmd
+ (format-spec
+ cmd
+ (format-spec-make
+ ?h host
+ ?p (if (integerp port)
+ (int-to-string port)
+ port))))
response)
+ (message "Opening TLS connection with `%s'..." formatted-cmd)
(setq process (start-process
name buffer shell-file-name shell-command-switch
- (format-spec
- cmd
- (format-spec-make
- ?h host
- ?p (if (integerp port)
- (int-to-string port)
- port)))))
+ formatted-cmd))
(while (and process
(memq (process-status process) '(open run))
(progn
tls-success nil t)))))
(unless (accept-process-output process 1)
(sit-for 1)))
- (message "Opening TLS connection with `%s'...%s" cmd
+ (message "Opening TLS connection with `%s'...%s" formatted-cmd
(if done "done" "failed"))
(if (not done)
(delete-process process)
projects / gnus / commitdiff