Sebastian Freundt [Mon, 2 Jan 2012 10:38:18 +0000 (10:38 +0000)]
Summary: fix to cosmetics, add AM_PROG_AR conditionally
Keywords: bldchn
* configure.ac: add AM_PROG_AR conditionally
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Mon, 2 Jan 2012 10:37:02 +0000 (10:37 +0000)]
Summary: cosmetics, add AM_PROG_AR like autoreconf suggests
Keywords: bldchn
* configure.ac: add AM_PROG_AR
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Sun, 1 Jan 2012 21:04:29 +0000 (21:04 +0000)]
Summary: minor, check certain compiler flags regardless of CC flavour
Keywords: bldchn
This changeset, in preparation to upcoming clang support, checks for
certain compiler flags (warnings at the moment) regardless of flavour.
It seems many compilers actually support a lot more gcc flags than gcc
itself, so check for them without checking for the flavour first.
This might break Sun studio build but Sun isn't shining anymore, is it?
* m4/sxe-compiler.m4: check for warning flags irrespective of CC flavour
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Sebastian Freundt [Sun, 1 Jan 2012 20:56:47 +0000 (20:56 +0000)]
Summary: minor, provide C11 check for anonymous structs
Keywords: bldchn
This changeset provides a check for anon structs, an on-and-off feature
of gcc, and mandatory for C11 support.
* m4/sxe-compiler.m4 (SXE_CHECK_ANON_STRUCTS): simply check if anon
structs are possible, they ought to be when -std=gnu1x is selected but
that's only possible in gcc 4.6.1 it seems.
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Sebastian Freundt [Sun, 1 Jan 2012 19:00:13 +0000 (19:00 +0000)]
Summary: fix, use our compiler flag check macros to check for pthread{,s}
Keywords: bldchn
This changeset properly checks for the flags -pthread and -pthreads.
The old case based system could not cope with new gcc's and clang's
error messages.
* configure.ac: fix, use SXE_CHECK_COMPILER_FLAGS, a macro defined in
m4/sxe-compiler.m4
Signed-off-by: Sebastian Freundt <hroptatyr@fresse.org>
Steve Youngs [Sun, 18 Dec 2011 03:41:16 +0000 (13:41 +1000)]
contrib updates from Nelson
* merges:
Add check for user email and name setup
Nelson Ferreira [Sat, 17 Dec 2011 04:51:26 +0000 (23:51 -0500)]
Add check for user email and name setup
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Sat, 17 Dec 2011 03:30:44 +0000 (13:30 +1000)]
stress testing git workflow
* merges:
ensure we track origin/master
Added contrib script to help people setup their contributing branches
Steve Youngs [Sat, 17 Dec 2011 03:30:23 +0000 (13:30 +1000)]
ensure we track origin/master
Signed-off-by: Steve Youngs <steve@sxemacs.org>
Nelson Ferreira [Sat, 17 Dec 2011 03:08:30 +0000 (22:08 -0500)]
Added contrib script to help people setup their contributing branches
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Sat, 17 Dec 2011 02:47:36 +0000 (12:47 +1000)]
stress testing git workflow
* merges:
Add copyright to autogen.sh
Nelson Ferreira [Sat, 17 Dec 2011 02:43:21 +0000 (21:43 -0500)]
Add copyright to autogen.sh
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Fri, 16 Dec 2011 00:24:53 +0000 (10:24 +1000)]
contrib updates
* merges:
Add triggers to action to update contrib scripts
More remove tla hook references in contrib
Remove tla hook references in contrib
Warn that cl emod is not being built due to missing bison
Revert "Add copyright and license to autogen.sh"
Add copyright and license to autogen.sh
Add the directory for the dbus module
Add my copyright to configure.ac
Nelson Ferreira [Thu, 15 Dec 2011 05:07:25 +0000 (00:07 -0500)]
Add triggers to action to update contrib scripts
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 15 Dec 2011 05:03:03 +0000 (00:03 -0500)]
More remove tla hook references in contrib
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 15 Dec 2011 05:00:41 +0000 (00:00 -0500)]
Remove tla hook references in contrib
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 15 Dec 2011 04:08:41 +0000 (23:08 -0500)]
Warn that cl emod is not being built due to missing bison
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 15 Dec 2011 03:52:40 +0000 (22:52 -0500)]
Revert "Add copyright and license to autogen.sh"
This reverts commit
141c2bb87dad80dd319fe76517ec2429a10bebe6.
Nelson Ferreira [Thu, 15 Dec 2011 03:42:14 +0000 (22:42 -0500)]
Add copyright and license to autogen.sh
Nelson Ferreira [Thu, 15 Dec 2011 03:10:59 +0000 (22:10 -0500)]
Add the directory for the dbus module
Nelson Ferreira [Thu, 15 Dec 2011 02:36:21 +0000 (21:36 -0500)]
Add my copyright to configure.ac
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Fri, 9 Dec 2011 23:34:12 +0000 (09:34 +1000)]
Autoconf/buildchain fixes/improvements from Nelson
* merges:
Enhance realpath and dirname checking.
Remove unneeded SXE_SHLIB_STUFF
Stop configure if there is no makeinfo
Nelson Ferreira [Fri, 9 Dec 2011 19:20:15 +0000 (14:20 -0500)]
Enhance realpath and dirname checking.
* m4/sxe-fs-funs.m4 (_SXE_CHECK_REALPATH_RETVAL): Do the checking
in a function so that any core will show which test cored.
* m4/sxe-fs-funs.m4 (_SXE_CHECK_REALPATH_RETVAL_OWNER): Ditto.
* m4/sxe-fs-funs.m4 (_SXE_CHECK_REALPATH_ON_PROTECTED_MEMORY): Ditto.
* m4/sxe-fs-funs.m4 (_SXE_CHECK_REALPATH_SANE_ON_NON_EXISTENT): Ditto.
* m4/sxe-fs-funs.m4 (_SXE_CHECK_DIRNAME_SIDE_EFFECT): Ditto.
* m4/sxe-fs-funs.m4 (_SXE_CHECK_DIRNAME_RETVAL_OWNER): Ditto.
* m4/sxe-fs-funs.m4 (_SXE_CHECK_DIRNAME_RETVAL_OWNER): Avoid a
core in MacOS X by pre-choosing sys as the result.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Fri, 9 Dec 2011 19:11:13 +0000 (14:11 -0500)]
Remove unneeded SXE_SHLIB_STUFF
* m4/sxe-linker.m4: As the title says. This is not called anywhere, so better to
take this ugly piece out. We have this logic already spreadout elsewhere anyway,
both in our own stuff and libtool...
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Fri, 9 Dec 2011 16:04:10 +0000 (11:04 -0500)]
Stop configure if there is no makeinfo
* m4/sxe-bldchain-progs.m4 (SXE_PROG_MAKEINFO): Detection of
makeinfo. Since autoconf will actually define one using missing,
we kinda need to execute --version to make sure it is actually
real.
* m4/sxe-bldchain-progs.m4 (SXE_CHECK_BUILDCHAIN): Add call to
SXE_PROG_MAKEINFO
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Tue, 6 Dec 2011 23:02:21 +0000 (09:02 +1000)]
Configure fix for Solaris
* merges:
Fix configure in solaris
Nelson Ferreira [Tue, 6 Dec 2011 20:58:09 +0000 (15:58 -0500)]
Fix configure in solaris
* m4/sxe-aux.m4 (SXE_CONSECUTIVE_UNDUP): Try use detected awk which will allow for better results. On solaris this should be either the xpg4 one, or gawk.
* m4/sxe-aux.m4 (SXE_UNDUP): Ditto
* m4/sxe-summary.m4 (SXE_SUMMARY): Ditto
* m4/sxe-crypto.m4 (SXE_OPENSSL_VERSION): Try to use detected grep which will allow for -q. On solaris this should be either gnu grep or the xpg4 one.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Mon, 5 Dec 2011 00:17:52 +0000 (10:17 +1000)]
INSTALL/PROBLEMS updates
* merges:
Give a little more detail about crash reporting on MacOS X
Add resolution to missing makeinfo while building
Update link to mpc library. Warn of texinfo needed to build from git. Small typo fix
Nelson Ferreira [Sun, 4 Dec 2011 04:09:59 +0000 (23:09 -0500)]
Give a little more detail about crash reporting on MacOS X
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 4 Dec 2011 03:34:50 +0000 (22:34 -0500)]
Merge branch 'master' of git.sxemacs.org/sxemacs
Nelson Ferreira [Sun, 4 Dec 2011 02:35:41 +0000 (21:35 -0500)]
Add resolution to missing makeinfo while building
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 4 Dec 2011 02:32:35 +0000 (21:32 -0500)]
Update link to mpc library. Warn of texinfo needed to build from git. Small typo fix
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Sat, 3 Dec 2011 22:23:38 +0000 (08:23 +1000)]
Fix mpc detection
* merges:
Fix detection and usage of mpc in newer versions (like mpc 0.9)
Nelson Ferreira [Sat, 3 Dec 2011 08:02:40 +0000 (03:02 -0500)]
Fix detection and usage of mpc in newer versions (like mpc 0.9)
* m4/sxe-maths.m4 (_SXE_CHECK_MPC): check for mpc_init and
mpc_set_ui_fr which were recently removed so that they can be
emulated for now. Also determine if mpc can be inited (and thus
used) by making sure one of mpc_init or mpc_init2 is available.
* m4/sxe-maths.m4 (SXE_CHECK_MPC_LIBS): check for mpc_init2 and
mpc_set_ui_fr too.
* src/ent/ent-mpc.h (bigc_init): conditional definition on whether
mpc_init or mpc_init2 is available.
* src/ent/ent-mpc.c: define mpc_set_ui_fr based on the MPC_SET_X_Y
macro if available. Abort compile if not available.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Sat, 3 Dec 2011 00:33:27 +0000 (10:33 +1000)]
Change mod/pkg load path (user dirs)
* merges:
Also make sxemacs packages of user home be looked up before xemacs ones, not just the system
Nelson Ferreira [Fri, 2 Dec 2011 14:55:18 +0000 (09:55 -0500)]
Also make sxemacs packages of user home be looked up before xemacs ones, not just the system
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Fri, 2 Dec 2011 14:49:18 +0000 (09:49 -0500)]
Merge branch 'master' of git.sxemacs.org/sxemacs
Steve Youngs [Fri, 2 Dec 2011 06:57:21 +0000 (16:57 +1000)]
Change mod/pkg load path
* merges:
Revert order changer for module paths
Enhance the module and package lookup paths
Nelson Ferreira [Fri, 2 Dec 2011 06:05:32 +0000 (01:05 -0500)]
Merge branch 'master' of git.sxemacs.org/sxemacs
Nelson Ferreira [Fri, 2 Dec 2011 06:04:33 +0000 (01:04 -0500)]
Revert order changer for module paths
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Fri, 2 Dec 2011 03:06:31 +0000 (22:06 -0500)]
Enhance the module and package lookup paths
* configure.ac: lookup sxemacs-<version>/<configuration> before sxemacs/<configuration> for modules
* configure.ac: looup sxemacs-packages before xemacs-packages
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Fri, 2 Dec 2011 02:46:08 +0000 (12:46 +1000)]
Configure summary clean up
* merges:
[ Replace this line with a one-line summary of the changes ]
Nelson Ferreira [Fri, 2 Dec 2011 01:34:28 +0000 (20:34 -0500)]
[ Replace this line with a one-line summary of the changes ]
* configure.ac: Properly quote eval so that ~ does not get expanded
* configure.ac: Remove double ':' on package path
* m4/sxe-summary.m4 (SXE_SUMMARY): Use awk instead of SED so that newlines are properly introduced in all cases
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Thu, 1 Dec 2011 22:16:00 +0000 (08:16 +1000)]
Fix pdump on Mac OS Lion from Nelson
* merges:
Disable PIE in MacOS X Lion, thus pdump works again...
Cosmetic fixes to the configuration summary (ie Installation)
Nelson Ferreira [Thu, 1 Dec 2011 17:37:29 +0000 (12:37 -0500)]
Disable PIE in MacOS X Lion, thus pdump works again...
* configure.ac: If darwin linker supports -no_pie, add it
* m4/sxe-bldenv.m4 (SXE_LD_NO_PIE): New function to check if the
linker supports -no_pie.
* m4/sxe-compiler.m4 (SXE_CHECK_CC_CHAR): Invoke the linker check for -no_pie
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 1 Dec 2011 16:10:21 +0000 (11:10 -0500)]
Cosmetic fixes to the configuration summary (ie Installation)
* m4/sxe-summary.m4 (SXE_SUMMARY): Fix the Runtime behavior prefix output. Properly indent the search paths
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Thu, 1 Dec 2011 13:28:40 +0000 (23:28 +1000)]
configure cleanup from Nelson
* merges:
Deduplicate options to compiler and linker, as well as consecutive LIBS
Nelson Ferreira [Thu, 1 Dec 2011 08:32:47 +0000 (03:32 -0500)]
Deduplicate options to compiler and linker, as well as consecutive LIBS
* configure.ac: Use SXE_{APPEND,PREPEND}_UNDUP do add to c_switch_site and ld_switch_site
* configure.ac: Ditto for adding to c_switch_gtk
* configure.ac: Ditto for adding to X_CFLAGS
* configure.ac: Ditto for adding to MM_CFLAGS, MM_LDFLAGS and MM_CPPFLAGS
* configure.ac: Use SXE_CONSECUTIVE_UNDUP instead of SXE_SPACE to remove consecutive dups on libs_xauth
* configure.ac: Ditto for ld_libs_general, ld_libs_window_system and ld_libs_all
* configure.ac: Use SXE_UNDUP to remove dups from {c,ld}_switch_{general,window_system,all}
* configure.ac: Remove extra verbose output of the switches, since this was moved to sxe-summary.m4
* m4/sxe-summary.m4 (SXE_SUMMARY): Provide output of {c,ld}_switch_{general,window_system,all}
* m4/sxe-summary.m4 (SXE_SUMMARY): Don't use -e on echo, since not all shells honor it
* m4/sxe-bldenv.m4: Use SXE_{APPEND,PREPEND}_UNDUP do add to LD_FLAGS, CPPFLAGS, ld_switch_{run,system,site}
* m4/sxe-compiler.m4: Use SXE_{APPEND,PREPEND}_UNDUP do add to c_switch_{site,system}, CFLAGS
* m4/sxe-crypto.m4: Use SXE_{APPEND,PREPEND}_UNDUP do add to CPPFLAGS, LDFLAGS
* m4/sxe-libtool.m4: Use SXE_{APPEND,PREPEND}_UNDUP do add to LDFLAGS
* m4/sxe-mm.m4: Use SXE_{APPEND,PREPEND}_UNDUP do add to {c,ld}_switch_site
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Mon, 28 Nov 2011 03:03:43 +0000 (13:03 +1000)]
typo fix
Signed-off-by: Steve Youngs <steve@sxemacs.org>
Steve Youngs [Mon, 28 Nov 2011 02:51:50 +0000 (12:51 +1000)]
Close EMchat bug #129
* merges:
Bug 129 - Bad conversion to snprintf
Nelson Ferreira [Mon, 28 Nov 2011 02:28:18 +0000 (21:28 -0500)]
Bug 129 - Bad conversion to snprintf
* src/filelock.c (lock_file): Compute size of malloc and use it assert
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Sun, 27 Nov 2011 21:07:16 +0000 (07:07 +1000)]
Wand updates from Evgeny
* merges:
[add] command: M-x Wand-list-patterns RET
lg [Sun, 27 Nov 2011 19:00:52 +0000 (22:00 +0300)]
[add] command: M-x Wand-list-patterns RET
[add] command: M-x Wand-list-composite-ops RET
[add] operation: preview-op, powerful shit to preview some operations
with different params
[add] operation: posterize
[add] operation: pattern
[enh] Wand-redisplay: image-wand can be changed during operation
[enh] make a use of (window-displayed-text-pixel-height)
Signed-off-by: lg <lg@lg-desktop.(none)>
Steve Youngs [Wed, 16 Nov 2011 04:33:50 +0000 (14:33 +1000)]
OpenSSL build fixes from Nelson
* merges:
Prevent inexistence of openssl ssl_verify_cert_chain from breaking the build
Nelson Ferreira [Wed, 16 Nov 2011 01:55:54 +0000 (20:55 -0500)]
Prevent inexistence of openssl ssl_verify_cert_chain from breaking the build
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Tue, 15 Nov 2011 11:33:59 +0000 (21:33 +1000)]
OpenSSL build fixes from Nelson
* merges:
Prevent inexistence of openssl server/client methods from breaking the build
Nelson Ferreira [Tue, 15 Nov 2011 08:59:38 +0000 (03:59 -0500)]
Prevent inexistence of openssl server/client methods from breaking the build
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Fri, 11 Nov 2011 01:36:47 +0000 (11:36 +1000)]
Add prompt stack for recursive minibuffer
* merges:
[add] minibuffer prompt stack for use with recursive minibuffers
Nelson Ferreira [Thu, 10 Nov 2011 22:54:04 +0000 (17:54 -0500)]
Merge branch 'master' of git.sxemacs.org/sxemacs
Zajcev Evgeny [Thu, 10 Nov 2011 10:57:11 +0000 (13:57 +0300)]
[add] minibuffer prompt stack for use with recursive minibuffers
Signed-off-by: Zajcev Evgeny <zevlg@yandex.ru>
Nelson Ferreira [Fri, 4 Nov 2011 04:14:36 +0000 (00:14 -0400)]
Merge branch 'master' of git.sxemacs.org/sxemacs
Steve Youngs [Tue, 25 Oct 2011 00:11:33 +0000 (10:11 +1000)]
Merge branch 'emailed-patches'
JD Horelick [Mon, 24 Oct 2011 10:16:12 +0000 (06:16 -0400)]
Fix compilation when MULE is disabled, due to a missing ifdef.
Signed-off-by: Steve Youngs <steve@sxemacs.org>
Nelson Ferreira [Wed, 19 Oct 2011 15:45:36 +0000 (11:45 -0400)]
Merge branch 'master' of git.sxemacs.org/sxemacs
Steve Youngs [Wed, 12 Oct 2011 00:21:12 +0000 (10:21 +1000)]
Coverity fixes from Nelson
* merges:
Remove unused variable
Fix compile of previous commit
Coverity fix CID:92 NEGATIVE_RETURNS
Coverity fix. CID:135 NULL_RETURNS
More binary files...
Coverity fix CID:202 REVERSE_INULL
Coverity fix CI:203 REVERSE_INULL
Coverity fixes CID:45 FORWARD_NULL
Nelson Ferreira [Tue, 11 Oct 2011 21:19:36 +0000 (17:19 -0400)]
Merge branch 'master' of git.sxemacs.org/sxemacs
Nelson Ferreira [Tue, 11 Oct 2011 01:29:16 +0000 (21:29 -0400)]
Remove unused variable
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Tue, 11 Oct 2011 01:28:41 +0000 (21:28 -0400)]
Fix compile of previous commit
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Tue, 11 Oct 2011 01:14:35 +0000 (21:14 -0400)]
Coverity fix CID:92 NEGATIVE_RETURNS
* lib-src/movemail.c (main): Make sure read was successful before
trying to write..
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Tue, 11 Oct 2011 00:36:35 +0000 (20:36 -0400)]
Coverity fix. CID:135 NULL_RETURNS
* src/ui/X11/event-Xt.c (x_to_emacs_keysym): make fure there is a
frame before dereferencing to get the XIC.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Tue, 11 Oct 2011 00:29:54 +0000 (20:29 -0400)]
More binary files...
* lisp/files.el (binary-file-regexps): Following the lead from a
recent XEmacs commit, enhance the list of known binary files.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Mon, 10 Oct 2011 23:56:12 +0000 (19:56 -0400)]
Coverity fix CID:202 REVERSE_INULL
* src/mem/ralloc.c (update_heap_bloc_correspondence): Make sure heap is not NULL before dereference
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Mon, 10 Oct 2011 23:51:20 +0000 (09:51 +1000)]
Coverity fixes from Nelson
* merges:
Coverity fix: CID 121 NEGATIVE_RETURNS
Coverity fix: CID:126 NEGATIVE_RETURNS
Fix solaris crash
Coverity fix: USE_AFTER_FREE CID:438
Nelson Ferreira [Mon, 10 Oct 2011 23:51:13 +0000 (19:51 -0400)]
Coverity fix CI:203 REVERSE_INULL
* src/doprnt.c (get_doprnt_args): avoid derefence a NULL specs
(emacs_doprnt_1): ditto.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Mon, 10 Oct 2011 23:42:58 +0000 (19:42 -0400)]
Coverity fixes CID:45 FORWARD_NULL
* src/dired.c (dfr_inner): Make sure bufp is not NULL before
calling pathname_matches_p
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Mon, 10 Oct 2011 18:16:49 +0000 (14:16 -0400)]
Coverity fix: CID 121 NEGATIVE_RETURNS
* src/ui/TTY/objects-tty.c (tty_font_spec_matches_charset): make
sure length is updated by fixup_internal_substring.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Mon, 10 Oct 2011 18:15:09 +0000 (14:15 -0400)]
Coverity fix: CID:126 NEGATIVE_RETURNS
* src/ui/X11/objects-x.c (x_font_spec_matches_charset): make sure
that fixup_internal_substring updated the_length.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Mon, 10 Oct 2011 15:31:45 +0000 (11:31 -0400)]
Fix solaris crash
* src/ent/ent-float.c (vars_of_ent_float): Make sure to use a
buffer since some implementations of snprintf will refuse a NULL
buffer and not return the characters that would be written.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Mon, 10 Oct 2011 13:51:43 +0000 (09:51 -0400)]
Coverity fix: USE_AFTER_FREE CID:438
* src/sysdep.c (sys_fclose): loop with close on fd, not fclose
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Mon, 10 Oct 2011 03:42:29 +0000 (13:42 +1000)]
Coverity inspired security fixes from Nelson
* merges:
SECURE_CODING: Use snprintf/write_fmt_str instead of sprintf
Nelson Ferreira [Mon, 10 Oct 2011 02:56:14 +0000 (22:56 -0400)]
SECURE_CODING: Use snprintf/write_fmt_str instead of sprintf
* etc/tests/external-widget/test-ew-motif.c (ScaleValueChangedCB):
Use snprintf instead of sprintf.
* etc/tests/external-widget/test-ew-motif.c (main): ditto.
* etc/tests/external-widget/test-ew-motif.c (main): ditto.
* etc/tests/external-widget/test-ew-xlib.c (draw_text): ditto
* lib-src/gnuclient.c (tell_emacs_to_resume): ditto.
* lib-src/gnuclient.c (main): ditto.
* lib-src/gnuserv.c (ipc_init): ditto.
* lib-src/gnuserv.c (unix_init): ditto.
* lib-src/gnuslib.c (connect_to_ipc_server): ditto.
* lib-src/gnuslib.c (connect_to_unix_server): ditto.
* lib-src/make-po.c (buf_print): ditto.
* lib-src/movemail.c (lock_dot): ditto.
* lib-src/pop.c (pop_open): ditto.
* lib-src/profile.c (get_time): ditto.
* lib-src/yow.c (main): ditto.
* src/bytecode.c (invalid_byte_code_error): ditto.
* src/extents.c (print_extent_1): ditto.
* src/m/cydra5.h (PTY_NAME_SPRINTF): ditto.
* src/m/cydra5.h (PTY_TTY_NAME_SPRINTF): ditto.
* src/media/media-ffmpeg.c (media_ffmpeg_streaminfo): ditto.
* src/media/sound-hpplay.c (player_error_internal): ditto.
* src/media/sound-sunplay.c (init_device): ditto.
* src/media/sound-sunplay.c (play_sound_file): ditto.
* src/media/sound-sunplay.c (play_sound_data): ditto.
* src/media/sound-sunplay.c (sound_native_audio_init): ditto.
* src/process.c (make_process_internal): ditto.
* src/ui/Gtk/menubar-gtk.c (menu_descriptor_to_widget_1): ditto.
* src/print.c: fix comment
* modules/ase/ase-resclass.h (resc_rng_to_string): check return of
snprintf.
* modules/ase/ase-resclass.c (_ase_resc_rng_to_string): ditto.
* modules/ase/ase-resclass.c (_ase_resc_elm_to_string): ditto.
* src/media/sound-jack.c (sound_jack_subthread_create): ditto.
* src/effi.c (WRITE_FMT_STRING): new macro to use
write_fmt_string.
* src/lisp.h (PRIVATE_EXTERNAL_LIST_LOOP_6): Finally fix the
computed value not used warning.
* src/events/events.c (print_event): remove unneeded buf
* modules/ase/ase-cartesian.c (ase_cartesian_prnt): Use
write_fmt_str instead of sprintf.
* modules/ase/ase-heap.c (ase_yheap_prnt): ditto.
* modules/ase/ase-heap.c (ase_dheap_prnt): ditto.
* modules/ase/ase-heap.c (ase_wheap_prnt): ditto.
* modules/ase/ase-metric.c (ase_metric_prnt): ditto.
* modules/ase/ase-permutation.c (_ase_permutation_prnt_cyc): ditto.
* src/bytecode.c (print_compiled_function): ditto.
* src/chartab.c (print_chartab_two_byte_charset): ditto.
* src/chartab.c (print_char_table): ditto.
* src/database/database.c (print_database): ditto.
* src/database/eldap.c (print_ldap): ditto.
* src/database/postgresql.c (print_pgconn): ditto.
* src/database/postgresql.c (print_pgresult): ditto.
* src/effi.c (print_ffiobject): ditto.
* src/effi.c (print_ffi_job): ditto.
* src/emacs.c (fatal_error_signal): ditto.
* src/extents.c (print_extent_1): ditto.
* src/extents.c (print_extent): ditto.
* src/media/media.c (media_substream_print_audio): ditto.
* src/media/media.c (media_substream_print_video): ditto.
* src/media/sound-alsa.c (sound_alsa_print): ditto.
* src/media/sound-pulse.c (sound_pulse_print): ditto.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Tue, 4 Oct 2011 05:56:10 +0000 (15:56 +1000)]
Coverity inspired security fixes from Nelson
* merges:
Quick typo fix (missing semi-colon)
Security fixes
Steve Youngs [Tue, 4 Oct 2011 05:55:35 +0000 (15:55 +1000)]
Quick typo fix (missing semi-colon)
* src/filelock.c (lock_file_1): Add missing semi-colon.
Signed-off-by: Steve Youngs <steve@sxemacs.org>
Nelson Ferreira [Tue, 4 Oct 2011 05:16:11 +0000 (01:16 -0400)]
Security fixes
* src/alloc.c (garbage-collect): check return of snprintf
* src/doprnt.c (emacs_doprnt_smZ): ditto
* src/dumper.c (pdump_file_try): ditto
* src/dumper.c (pdump_load): ditto
* src/editfns.c (Fencode_time): ditto
* src/editfns.c (Fencode_btime): ditto
* src/editfns.c (current_time_zone): ditto
* src/ent/ent-float.c (vars_of_ent_float): ditto
* src/filelock.c (lock_file_1): ditto
* src/media/sound-arts.c (sound_arts_play): ditto
* src/mule/mule-ccl.c (ccl_driver): ditto
* src/opaque.c (print_opaque_ptr): ditto
* src/strftime.c (add_num_time_t): ditto
* src/casetab.c (print_case_table): use write_fmt_str instead of sprintf
* src/elhash.c (print_hash_table): ditto
* src/events/event-stream.c (print_timeout): ditto
* src/events/events.c (print_event): ditto
* src/media/sound-nas.c (sound_nas_print): ditto
* src/media/sound.c (print_audio_job): ditto
* src/opaque.c (print_opaque): ditto
* src/openssl.c (print_evp_pkey): ditto
* src/symbols.c (print_symbol_value_magic): ditto
* src/filelock.c (lock_file): Use snprintf instead of sprintf
* src/libsst.c (sst_set_ger): ditto
* src/libsst.c (sst_set_gr): ditto
* src/libsst.c (sst_set_gx): ditto
* src/libsst.c (sst_tones): ditto
* src/libsst.c (sst_dmtf): ditto
* src/print.c (float_to_string): ditto
* src/process-unix.c (allocate_pty_the_old_fashioned_way): ditto
* src/process-unix.c (unix_open_network_stream): ditto
* src/s/hpux.h (PTY_TTY_NAME_SPRINTF): ditto
* src/s/rtu.h (PTY_TTY_NAME_SPRINTF): ditto
* src/s/sco4.h (PTY_TTY_NAME_SPRINTF): ditto
* src/s/sco5.h (PTY_TTY_NAME_SPRINTF): ditto
* src/data.c (Fnumber_to_string): correct arguments to new buffer
size aware float_to_string and long_to_string
* src/doprnt.c (emacs_doprnt_number): correct arguments to new
buffer size aware long_to_string
* src/print.c (print_internal): ditto
* src/ui/redisplay.c (window_line_number): ditto
* src/ui/redisplay.c (decode_mode_spec): ditto
* src/ent/ent-float.c (print_float): correct arguments to new
buffer size aware float_to_string
* src/ent/ent-float.h: define new argument for float_to_string
* src/lisp.h: define new argument for long_to_string
* src/emacs.c (assert_failed): flush stderr to make sure assertion is written.
* src/print.c (float_to_string): rewrite so that it knows size and
does not overflow buf. Also uses snprintf instead of sprintf
* src/print.c (long_to_string): ditto.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Mon, 3 Oct 2011 02:01:04 +0000 (12:01 +1000)]
Coverity fixes from Nelson
* merges: (27 commits)
Coverity fixes. Replace UNUSED with SXE_UNUSED since some system includes (like sox.h) define it in an incompatible fashion
Coverity fixes
[ Replace this line with a one-line summary of the changes ]
Coverity fixes
Coverity fixes
Coverity fixes
Coverity fixes
Coverity changes
Coverity fixes
Coverity fixes
Coverity fixes
Coverity fixes
Coverity fixes
Coverity fixes
Coverity fixes
Coverity fixes
Coverity fixes
Coverity fixes
Coverity fixes
Coverity fixes.
...
Nelson Ferreira [Sun, 2 Oct 2011 23:14:00 +0000 (19:14 -0400)]
Coverity fixes. Replace UNUSED with SXE_UNUSED since some system includes (like sox.h) define it in an incompatible fashion
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 2 Oct 2011 21:26:45 +0000 (17:26 -0400)]
Coverity fixes
* src/lisp.h (PRIVATE_EXTERNAL_LIST_LOOP_6): silence value
computed not used warning.
* src/lisp.h: add prototypes for write_hex_ptr, write_fmt_str and
write_fmt_sting.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 2 Oct 2011 21:23:23 +0000 (17:23 -0400)]
[ Replace this line with a one-line summary of the changes ]
* src/emodules-ng.c (__emodng_find): only get module info if on debug mode
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 2 Oct 2011 21:22:10 +0000 (17:22 -0400)]
Coverity fixes
* src/doc.c (unparesseuxify_doc_string): decrease stack usage
* src/doc.c (Fsnarf_documentation): check return of snprintf
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 2 Oct 2011 21:20:05 +0000 (17:20 -0400)]
Coverity fixes
* src/ui/X11/frame-x.c (color_to_string): use snprintf instead of sprintf
* src/ui/X11/frame-x.c (x_set_initial_frame_size): ditto.
* src/ui/X11/frame-x.c (Fx_window_id): ditto.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 2 Oct 2011 21:18:08 +0000 (17:18 -0400)]
Coverity fixes
* src/ui/X11/event-Xt.c (x_keysym_to_emacs_keysym): check result of snprintf
* src/ui/X11/event-Xt.c (describe_event_window): ditto.
* src/ui/X11/event-Xt.c (describe_event): ditto.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 2 Oct 2011 21:16:05 +0000 (17:16 -0400)]
Coverity fixes
* src/ui/X11/dialog-x.c (dbox_descriptor_to_widget_value): use snprintf instead of sprintf
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 2 Oct 2011 21:15:03 +0000 (17:15 -0400)]
Coverity changes
* src/ui/TTY/terminfo.c (emacs_tparam): use strncpy instead of strcpy
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 2 Oct 2011 21:14:11 +0000 (17:14 -0400)]
Coverity fixes
* src/ui/TTY/redisplay-tty.c (term_get_fkeys_1): check return of snprintf
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 2 Oct 2011 21:12:59 +0000 (17:12 -0400)]
Coverity fixes
* src/ui/X11/objects-x.c (x_print_color_instance): use write_fmt_str instead of snprintf
* src/ui/X11/objects-x.c (x_print_font_instance): ditto
* src/ui/X11/objects-x.c (truename_via_random_props): check result
of snprintf and remove not needed finalizer from strncpy.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 2 Oct 2011 21:10:09 +0000 (17:10 -0400)]
Coverity fixes
* src/ui/TTY/objects-tty.c (Ffind_tty_color): check return of snprintf
* src/ui/TTY/objects-tty.c (Ftty_registered_color_list): ditto.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 2 Oct 2011 21:08:56 +0000 (17:08 -0400)]
Coverity fixes
* src/ui/TTY/gpmevent.c (Fgpm_enabled_p): check return of snprintf
* src/ui/TTY/gpmevent.c (Fgpm_enable): ditto.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 2 Oct 2011 21:06:55 +0000 (17:06 -0400)]
Coverity fixes
* src/ui/Gtk/ui-gtk.c (ffi_object_printer): use write_fmt_str
instead of sprintf.
* src/ui/Gtk/ui-gtk.c (emacs_gtk_object_printer): ditto.
* src/ui/Gtk/ui-gtk.c (object_getprop): use write fmt_string instead of sprintf.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 2 Oct 2011 21:04:49 +0000 (17:04 -0400)]
Coverity fixes
* src/ui/Gtk/objects-gtk.c (gtk_print_color_instance): use
write_fmt_str instead of sprintf.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 2 Oct 2011 21:03:44 +0000 (17:03 -0400)]
Coverity fixes
* src/ui/Gtk/gtk-xemacs.c (xemacs_gtk_convert_color): use snprint
instead of sprintf.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
projects / sxemacs / log