Add some prototype to silence silly warnings. * src/effi.c(ffi_make_callback_x86): Add prototype. * src/media/sound-jack.c (demux_internal): Ditto. * src/mule/file-coding.c (autodetect_real_coding_system): Ditto. * src/print.c (float_to_string): Ditto. Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Whitespace cleanup in src [m-z] Signed-off-by: Steve Youngs <steve@sxemacs.org>
Coverity: UNINIT: CID 393 * src/print.c (write_string_to_stdio_stream): handle the case where the transcoding fails. Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Coverity: UNINIT: CID 402 * src/print.c (Falternate_debugging_output): Make sure to handle the case where transcoding failed. Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Coverity: DEADCODE: CID 578 * src/print.c (SXE_VSNPRINT_VA): Fix the macro so that error in snprintf is actually detected, instead of masked because of the buffer growth loop. Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
COVERITY: Forward NULL CID:46 * src/print.c (write_string_to_stdio_stream): Add appropriate diagnostics if no console nor stream provided... * src/print.c (Fexternal_debugging_output): Explict NULL initialization. Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
More warning suppressions * lib-src/gnuslib.c (connect_to_unix_server): Use size_t for sz * src/ui/X11/event-Xt.c (x_reset_modifier_mapping): Add full prototype to auto functions * src/ui/glyphs-eimage.c (png_instantiate): use png_uint_32 in loop * src/ui/lwlib/xlwmenu.c (parameterize_string): add new offset to keep signedness in comparison * src/ui/X11/glyphs-x.c (x_subwindow_query_geometry): add prototyp * lib-src/gnuslib.c (connect_to_internet_server): Use size_t to compare with sizeof. * src/alloc.c (garbage_collect): ditto. * src/buffer.c (Fgenerate_new_buffer_name): ditto. * src/dumper.c (pdump_file_try): ditto. * src/dumper.c (pdump_load): ditto. * src/editfns.c (Fencode_time): ditto. * src/editfns.c (Fencode_btime): ditto. * src/editfns.c (Fcurrent_time_zone): ditto. * src/extents.c (print_extent_1): ditto. * src/mule/input-method-xlib.c (EmacsXtCvtStringToXIMStyles): ditto. * src/mule/input-method-xlib.c (describe_Window): ditto. * src/print.c (SXE_VSNPRINT_VA): ditto. * src/print.c (write_hex_ptr): ditto. * src/print.c (printing_major_badness): ditto. * src/process-unix.c (allocate_pty_the_old_fashioned_way): ditto. * src/process-unix.c (unix_open_network_stream): ditto. * src/process-unix.c (unix_open_network_server_stream): ditto. * src/process.c (make_process_internal): ditto. * src/strftime.c (add_num_time_t): ditto. * src/ui/TTY/objects-tty.c (Ffind_tty_color): ditto. * src/ui/TTY/objects-tty.c (Ftty_registered_color_list): ditto. * src/ui/TTY/redisplay-tty.c (term_get_fkeys_1): ditto. * src/ui/X11/device-x.c (read_locale_specific_resources): ditto. * src/ui/X11/device-x.c (x_init_device): ditto. * src/ui/X11/device-x.c (signal_if_x_error): ditto. * src/ui/X11/dialog-x.c (dbox_descriptor_to_widget_value): ditto. * src/ui/X11/event-Xt.c (x_keysym_to_emacs_keysym): ditto. * src/ui/X11/event-Xt.c (describe_event): ditto. * src/ui/X11/frame-x.c (color_to_string): ditto. * src/ui/X11/frame-x.c (x_set_initial_frame_size): ditto. * src/ui/X11/frame-x.c (Fx_window_id): ditto. * src/ui/X11/objects-x.c (truename_via_random_props): ditto. * src/ui/X11/scrollbar-x.c (x_create_scrollbar_instance): ditto. * src/ui/glyphs-eimage.c (tiff_error_func): ditto. * src/ui/glyphs-eimage.c (tiff_warning_func): ditto. * src/ui/lwlib/lwlib-Xaw.c (make_dialog): ditto. * src/ui/lwlib/lwlib-Xaw.c (make_dialog): ditto. * src/ui/lwlib/xlwgauge.c (GaugeExpose): ditto. * src/ui/lwlib/xlwgauge.c (MaxLabel): ditto. * src/ui/lwlib/xlwmenu.c (parameterize_string): ditto. * src/ui/lwlib/xlwtabs.c (XawTabsSetTop): ditto. * src/ui/redisplay.c (decode_mode_spec): ditto. * src/ui/redisplay.c (decode_mode_spec): ditto. * src/ui/redisplay.c (decode_mode_spec): ditto. Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
SECURE_CODING: Use snprintf/write_fmt_str instead of sprintf * etc/tests/external-widget/test-ew-motif.c (ScaleValueChangedCB): Use snprintf instead of sprintf. * etc/tests/external-widget/test-ew-motif.c (main): ditto. * etc/tests/external-widget/test-ew-motif.c (main): ditto. * etc/tests/external-widget/test-ew-xlib.c (draw_text): ditto * lib-src/gnuclient.c (tell_emacs_to_resume): ditto. * lib-src/gnuclient.c (main): ditto. * lib-src/gnuserv.c (ipc_init): ditto. * lib-src/gnuserv.c (unix_init): ditto. * lib-src/gnuslib.c (connect_to_ipc_server): ditto. * lib-src/gnuslib.c (connect_to_unix_server): ditto. * lib-src/make-po.c (buf_print): ditto. * lib-src/movemail.c (lock_dot): ditto. * lib-src/pop.c (pop_open): ditto. * lib-src/profile.c (get_time): ditto. * lib-src/yow.c (main): ditto. * src/bytecode.c (invalid_byte_code_error): ditto. * src/extents.c (print_extent_1): ditto. * src/m/cydra5.h (PTY_NAME_SPRINTF): ditto. * src/m/cydra5.h (PTY_TTY_NAME_SPRINTF): ditto. * src/media/media-ffmpeg.c (media_ffmpeg_streaminfo): ditto. * src/media/sound-hpplay.c (player_error_internal): ditto. * src/media/sound-sunplay.c (init_device): ditto. * src/media/sound-sunplay.c (play_sound_file): ditto. * src/media/sound-sunplay.c (play_sound_data): ditto. * src/media/sound-sunplay.c (sound_native_audio_init): ditto. * src/process.c (make_process_internal): ditto. * src/ui/Gtk/menubar-gtk.c (menu_descriptor_to_widget_1): ditto. * src/print.c: fix comment * modules/ase/ase-resclass.h (resc_rng_to_string): check return of snprintf. * modules/ase/ase-resclass.c (_ase_resc_rng_to_string): ditto. * modules/ase/ase-resclass.c (_ase_resc_elm_to_string): ditto. * src/media/sound-jack.c (sound_jack_subthread_create): ditto. * src/effi.c (WRITE_FMT_STRING): new macro to use write_fmt_string. * src/lisp.h (PRIVATE_EXTERNAL_LIST_LOOP_6): Finally fix the computed value not used warning. * src/events/events.c (print_event): remove unneeded buf * modules/ase/ase-cartesian.c (ase_cartesian_prnt): Use write_fmt_str instead of sprintf. * modules/ase/ase-heap.c (ase_yheap_prnt): ditto. * modules/ase/ase-heap.c (ase_dheap_prnt): ditto. * modules/ase/ase-heap.c (ase_wheap_prnt): ditto. * modules/ase/ase-metric.c (ase_metric_prnt): ditto. * modules/ase/ase-permutation.c (_ase_permutation_prnt_cyc): ditto. * src/bytecode.c (print_compiled_function): ditto. * src/chartab.c (print_chartab_two_byte_charset): ditto. * src/chartab.c (print_char_table): ditto. * src/database/database.c (print_database): ditto. * src/database/eldap.c (print_ldap): ditto. * src/database/postgresql.c (print_pgconn): ditto. * src/database/postgresql.c (print_pgresult): ditto. * src/effi.c (print_ffiobject): ditto. * src/effi.c (print_ffi_job): ditto. * src/emacs.c (fatal_error_signal): ditto. * src/extents.c (print_extent_1): ditto. * src/extents.c (print_extent): ditto. * src/media/media.c (media_substream_print_audio): ditto. * src/media/media.c (media_substream_print_video): ditto. * src/media/sound-alsa.c (sound_alsa_print): ditto. * src/media/sound-pulse.c (sound_pulse_print): ditto. Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Security fixes * src/alloc.c (garbage-collect): check return of snprintf * src/doprnt.c (emacs_doprnt_smZ): ditto * src/dumper.c (pdump_file_try): ditto * src/dumper.c (pdump_load): ditto * src/editfns.c (Fencode_time): ditto * src/editfns.c (Fencode_btime): ditto * src/editfns.c (current_time_zone): ditto * src/ent/ent-float.c (vars_of_ent_float): ditto * src/filelock.c (lock_file_1): ditto * src/media/sound-arts.c (sound_arts_play): ditto * src/mule/mule-ccl.c (ccl_driver): ditto * src/opaque.c (print_opaque_ptr): ditto * src/strftime.c (add_num_time_t): ditto * src/casetab.c (print_case_table): use write_fmt_str instead of sprintf * src/elhash.c (print_hash_table): ditto * src/events/event-stream.c (print_timeout): ditto * src/events/events.c (print_event): ditto * src/media/sound-nas.c (sound_nas_print): ditto * src/media/sound.c (print_audio_job): ditto * src/opaque.c (print_opaque): ditto * src/openssl.c (print_evp_pkey): ditto * src/symbols.c (print_symbol_value_magic): ditto * src/filelock.c (lock_file): Use snprintf instead of sprintf * src/libsst.c (sst_set_ger): ditto * src/libsst.c (sst_set_gr): ditto * src/libsst.c (sst_set_gx): ditto * src/libsst.c (sst_tones): ditto * src/libsst.c (sst_dmtf): ditto * src/print.c (float_to_string): ditto * src/process-unix.c (allocate_pty_the_old_fashioned_way): ditto * src/process-unix.c (unix_open_network_stream): ditto * src/s/hpux.h (PTY_TTY_NAME_SPRINTF): ditto * src/s/rtu.h (PTY_TTY_NAME_SPRINTF): ditto * src/s/sco4.h (PTY_TTY_NAME_SPRINTF): ditto * src/s/sco5.h (PTY_TTY_NAME_SPRINTF): ditto * src/data.c (Fnumber_to_string): correct arguments to new buffer size aware float_to_string and long_to_string * src/doprnt.c (emacs_doprnt_number): correct arguments to new buffer size aware long_to_string * src/print.c (print_internal): ditto * src/ui/redisplay.c (window_line_number): ditto * src/ui/redisplay.c (decode_mode_spec): ditto * src/ent/ent-float.c (print_float): correct arguments to new buffer size aware float_to_string * src/ent/ent-float.h: define new argument for float_to_string * src/lisp.h: define new argument for long_to_string * src/emacs.c (assert_failed): flush stderr to make sure assertion is written. * src/print.c (float_to_string): rewrite so that it knows size and does not overflow buf. Also uses snprintf instead of sprintf * src/print.c (long_to_string): ditto. Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Small type change * lib-src/etags.c (argv): Use int instead of ssize_t as per manpage * src/print.c (std_handle_out_va): ditto * src/print.c (write_fmt_str): fix comment reference to function name Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Coverity fixes. Several CID's related to use of sprintf and stack usage. * src/print.c (std_handle_out_external): cleanup extranous scope * src/print.c (std_handle_out_external): remove condition for extlen == 0, since that is impossible. CID:23 DEADCODE * src/print.c (std_handle_out_va): Lowered buffer from 16K to 1K since most messages will be small and this could lead to heavy stack usage (specially upon assert failure in std_handle_out_external). CID:348,349 STACK_USE * src/print.c (internal_object_printer): Use newly refactored write_fmt_string instead of sprintf. CID:305 SECURE_CODING * src/print.c (printing_major_badness): Use snprintf CID:240 SECURE_CODING * src/print.c (default_object_printer): Use write_fmt_string instead of sprintf CID:239 SECURE_CODING * src/print.c (internal_object_printer): ditto. * src/print.c (SXE_VSNPRINT_VA): Macro to do vsnprintf with automatic buffer resizing. * src/print.c (write_fmt_str): New function for small (like integers) sprintf. * src/print.c (write_fmt_string): Moved up and refactored to use the macro which tries buffer reallocation. * src/print.c (std_handle_out_va): Refactor to use macro which tries buffer reallocation. * src/print.c (stdout_out): minor indenting change * src/print.c (fatal): Make sure not to do GETTEXT when in fatal error * src/print.c (write_hex_ptr): New function to print a pointer value in hex Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Initial git import