From 4a213f853c86a308912f7cf2384934ce135a5cf3 Mon Sep 17 00:00:00 2001 From: Mohammed Sameer Date: Sun, 26 Aug 2012 11:46:33 +0300 Subject: [PATCH] Don't try to manipulate the viewfinder renderer if we fail to create it. --- lib/qtcamgraphicsviewfinder.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lib/qtcamgraphicsviewfinder.cpp b/lib/qtcamgraphicsviewfinder.cpp index 76ccad1..342255a 100644 --- a/lib/qtcamgraphicsviewfinder.cpp +++ b/lib/qtcamgraphicsviewfinder.cpp @@ -11,6 +11,11 @@ public: void ensureBackend() { if (!renderer) { renderer = QtCamViewfinderRenderer::create(conf, q_ptr); + if (!renderer) { + qCritical() << "Failed to create a viewfinder renderer"; + return; + } + renderer->resize(q_ptr->size()); QObject::connect(renderer, SIGNAL(updateRequested()), q_ptr, SLOT(updateRequested())); } @@ -43,6 +48,10 @@ QtCamGraphicsViewfinder::~QtCamGraphicsViewfinder() { GstElement *QtCamGraphicsViewfinder::sinkElement() { d_ptr->ensureBackend(); + if (!d_ptr->renderer) { + return 0; + } + return d_ptr->renderer->sinkElement(); } -- 2.25.1