Fixes for changing video resolution between 16:9 and 4:3
authorMohammed Sameer <msameer@foolab.org>
Mon, 16 Sep 2013 20:05:12 +0000 (23:05 +0300)
committerMohammed Sameer <msameer@foolab.org>
Mon, 16 Sep 2013 20:05:12 +0000 (23:05 +0300)
We simply set the video aspect ratio before we set the resolution and
We don't try to change the resolution when aspect ratio gets changed

qml/MainPage.qml
qml/VideoResolutionSettings.qml

index 95cba6b..722fd38 100644 (file)
@@ -146,12 +146,6 @@ CameraPage {
                 videoSettings.setVideoResolution()
             }
         }
                 videoSettings.setVideoResolution()
             }
         }
-
-        onVideoAspectRatioChanged: {
-            if (!root.deviceChangeInProgress) {
-                videoSettings.setVideoResolution()
-            }
-        }
     }
 
     PipelineManager {
     }
 
     PipelineManager {
index 3a23d5c..d6323c5 100644 (file)
@@ -49,7 +49,10 @@ Column {
                 capitalize: true
                 text: qsTr("%1 %2").arg(resolutionName).arg(resolution)
                 checked: settings.videoResolution == resolutionName
                 capitalize: true
                 text: qsTr("%1 %2").arg(resolutionName).arg(resolution)
                 checked: settings.videoResolution == resolutionName
-                onClicked: settings.videoResolution = resolutionName
+                onClicked: {
+                    settings.videoAspectRatio = resolutionAspectRatio
+                    settings.videoResolution = resolutionName
+                }
             }
         }
     }
             }
         }
     }