Don't try to manipulate the viewfinder renderer if we fail to create it.

diff --git a/lib/qtcamgraphicsviewfinder.cpp b/lib/qtcamgraphicsviewfinder.cpp
index 76ccad1..342255a 100644 (file)
--- a/lib/qtcamgraphicsviewfinder.cpp
+++ b/lib/qtcamgraphicsviewfinder.cpp
@@ -11,6 +11,11 @@ public:
   void ensureBackend() {
     if (!renderer) {
       renderer = QtCamViewfinderRenderer::create(conf, q_ptr);
   void ensureBackend() {
     if (!renderer) {
       renderer = QtCamViewfinderRenderer::create(conf, q_ptr);

+      if (!renderer) {
+       qCritical() << "Failed to create a viewfinder renderer";
+       return;
+      }
+

       renderer->resize(q_ptr->size());
       QObject::connect(renderer, SIGNAL(updateRequested()), q_ptr, SLOT(updateRequested()));
     }
       renderer->resize(q_ptr->size());
       QObject::connect(renderer, SIGNAL(updateRequested()), q_ptr, SLOT(updateRequested()));
     }


@@ -43,6 +48,10 @@ QtCamGraphicsViewfinder::~QtCamGraphicsViewfinder() {
 GstElement *QtCamGraphicsViewfinder::sinkElement() {
   d_ptr->ensureBackend();
 
 GstElement *QtCamGraphicsViewfinder::sinkElement() {
   d_ptr->ensureBackend();
 

+  if (!d_ptr->renderer) {
+    return 0;
+  }
+

   return d_ptr->renderer->sinkElement();
 }
 
   return d_ptr->renderer->sinkElement();
 }