From fa44e14d9b3db9b61236a6f1a68f3b5420e3e2ab Mon Sep 17 00:00:00 2001 From: Glenn Morris Date: Thu, 8 May 2014 04:00:19 +0000 Subject: [PATCH] gnus-fun.el (gnus-grab-cam-face): Do not use predictable temp-file name (http://bugs.debian.org/747100) --- lisp/ChangeLog | 5 +++++ lisp/gnus-fun.el | 9 +++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 73e141136..5ae46de66 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2014-05-08 Glenn Morris + + * gnus-fun.el (gnus-grab-cam-face): + Do not use predictable temp-file name. (http://bugs.debian.org/747100) + 2014-05-04 Glenn Morris * gnus-registry.el (gnus-registry-install-p): Doc fix. diff --git a/lisp/gnus-fun.el b/lisp/gnus-fun.el index d6b4fba62..e0d1578f4 100644 --- a/lisp/gnus-fun.el +++ b/lisp/gnus-fun.el @@ -301,20 +301,21 @@ colors of the displayed X-Faces." (interactive) (shell-command "xawtv-remote snap ppm") (let ((file nil) + (tempfile (make-temp-file "gnus-face-" nil ".ppm")) result) (while (null (setq file (directory-files "/tftpboot/sparky/tmp" t "snap.*ppm"))) (sleep-for 1)) (setq file (car file)) (shell-command - (format "pnmcut -left 110 -top 30 -width 144 -height 144 '%s' | pnmscale -width 48 -height 48 | ppmtopgm > /tmp/gnus.face.ppm" - file)) + (format "pnmcut -left 110 -top 30 -width 144 -height 144 '%s' | pnmscale -width 48 -height 48 | ppmtopgm >> %s" + file tempfile)) (let ((gnus-convert-image-to-face-command (format "cat '%%s' | ppmquant %%d | ppmchange %s | pnmtopng" (gnus-fun-ppm-change-string)))) - (setq result (gnus-face-from-file "/tmp/gnus.face.ppm"))) + (setq result (gnus-face-from-file tempfile))) (delete-file file) - ;;(delete-file "/tmp/gnus.face.ppm") + ;;(delete-file tempfile) ; FIXME why are we not deleting it?! result)) (defun gnus-fun-ppm-change-string () -- 2.25.1