gnus
3 years agoRefactor mml-smime.el, mml1991.el, mml2015.el
Jens Lechtenboerger [Sun, 13 Dec 2015 15:12:30 +0000 (16:12 +0100)]
Refactor mml-smime.el, mml1991.el, mml2015.el

Cf. discussion on ding mailing list, messages on 2015-10-16 and
2015-11-07.  Common code from the three files mml-smime.el, mml1991.el,
and mml2015.el is moved to mml-sec.el.  Auxiliary functions are added to
gnus-util.el.

The code is supported by test cases with necessary test keys.

Documentation in message.texi is updated.

3 years agoUpdate copyright year to 2016
Paul Eggert [Fri, 1 Jan 2016 23:53:00 +0000 (23:53 +0000)]
Update copyright year to 2016

3 years agotls.el: Revert last change, that works on only Emacs 25.1
Katsumi Yamaoka [Thu, 31 Dec 2015 00:10:30 +0000 (00:10 +0000)]
tls.el: Revert last change, that works on only Emacs 25.1

3 years agotls.el: Remove --insecure from gnutls-cli invocation;
Lars Ingebrigtsen [Wed, 30 Dec 2015 23:40:51 +0000 (23:40 +0000)]
tls.el: Remove --insecure from gnutls-cli invocation;
make tls.el use trustfiles by default

* tls.el (tls-program):
Default to using secure TLS connections (bug#19284);
add a certfile by default (bug#21227).
(open-tls-stream):
Insert the trustfile by looking at `gnutls-trustfiles'.

3 years agomml-sec.el (mml-secure-bcc-is-safe): Keep old Emacsen compatibility
Katsumi Yamaoka [Mon, 28 Dec 2015 05:37:11 +0000 (05:37 +0000)]
mml-sec.el (mml-secure-bcc-is-safe): Keep old Emacsen compatibility

* mml-sec.el (mml-secure-bcc-is-safe):
Don't use split-string with 4th arg for old Emacsen compatibility.

3 years agoIdentify unsafe combinations of Bcc and encryption
Jens Lechtenboerger [Mon, 28 Dec 2015 01:35:02 +0000 (01:35 +0000)]
Identify unsafe combinations of Bcc and encryption

* gnus-util.el (gnus-subsetp): New function.
* mml-sec.el: Fix warnings by adding autoloads (bug#18718).
(mml-secure-safe-bcc-list): New variable.
(mml-secure-is-encrypted-p, mml-secure-bcc-is-safe): New functions.

3 years agoFix `gnus-union' so as to behave like `cl-union'
Katsumi Yamaoka [Wed, 23 Dec 2015 23:08:17 +0000 (23:08 +0000)]
Fix `gnus-union' so as to behave like `cl-union'

* gnus-group.el (gnus-group-prepare-flat):
Make gnus-union use `equal' to compare items in lists.

* gnus-util.el (gnus-union): Make it behave like cl-union partially.

3 years agoauth-source.el (auth-source-ensure-strings): Don't make a list out of 't' (Bug#22188)
Eli Zaretskii [Thu, 17 Dec 2015 22:58:38 +0000 (22:58 +0000)]
auth-source.el (auth-source-ensure-strings): Don't make a list out of 't' (Bug#22188)

Synch with the emacs-25 branch.
The changes having not been merged to the Emacs trunk are in:
http://www.jpl.org/ftp/pub/tmp/MaGnus-to-Emacs-trunk-unfinished.patch

* auth-source.el (auth-source-ensure-strings):
Don't make a list out of 't'.  (Bug#22188)

3 years agodgnushack.el (byte-optimize-apply): Fix last commit
Katsumi Yamaoka [Wed, 16 Dec 2015 09:57:45 +0000 (09:57 +0000)]
dgnushack.el (byte-optimize-apply): Fix last commit

3 years agodgnushack.el (byte-optimize-apply): Make the use-mapcan advice work
Katsumi Yamaoka [Wed, 16 Dec 2015 08:47:56 +0000 (08:47 +0000)]
dgnushack.el (byte-optimize-apply): Make the use-mapcan advice work
for (function nconc) as well as (quote nconc).

3 years agoSynch with the emacs-25 branch; the changes will be merged to the trunk (soon?)
Katsumi Yamaoka [Mon, 7 Dec 2015 00:28:17 +0000 (00:28 +0000)]
Synch with the emacs-25 branch; the changes will be merged to the trunk (soon?)

2015-12-04  Artur Malabarba  <bruce.connor.am@gmail.com>

* sasl-scram-rfc.el: Add a "Package:" header.

2015-11-17  Paul Eggert  <eggert@cs.ucla.edu>

Fix docstring quoting problems with ‘ '’

Problem reported by Artur Malabarba in:
http://lists.gnu.org/archive/html/emacs-devel/2015-11/msg01513.html
Most of these fixes are to documentation; many involve fixing
longstanding quoting glitches that are independent of the
recent substitute-command-keys changes.  The changes to code are:
* gnus-mlspl.el (gnus-group-split-fancy):
* hashcash.el (hashcash-extra-generate-parameters):
* message.el (message-qmail-inject-args, message-cite-reply-position):
* mm-decode.el (mm-inline-large-images):
* mm-util.el (mm-xemacs-find-mime-charset-1):

3 years agoqp.el: Don't replace "from " at bol
Daiki Ueno [Fri, 4 Dec 2015 04:36:31 +0000 (13:36 +0900)]
qp.el: Don't replace "from " at bol

* qp.el (quoted-printable-encode-region): Bind `case-fold-search' to
nil when looking for "^From ".  Problem reported by Simon Josefsson.

3 years agoRemove nnml-retrieve-groups that is unnecessary and somewhat problematic
Katsumi Yamaoka [Wed, 25 Nov 2015 13:47:54 +0000 (13:47 +0000)]
Remove nnml-retrieve-groups that is unnecessary and somewhat problematic

* nnml.el (nnml-retrieve-groups): Remove.  See:
<http://thread.gmane.org/gmane.emacs.gnus.general/86308> and
<http://thread.gmane.org/gmane.emacs.gnus.general/86321>

3 years agomm-url.el (mm-url-form-encode-xwfu): Allow argument CHUNK to be nil (Bug#21881)
Eli Zaretskii [Wed, 11 Nov 2015 22:56:54 +0000 (22:56 +0000)]
mm-url.el (mm-url-form-encode-xwfu): Allow argument CHUNK to be nil (Bug#21881)

3 years ago* gnus-sum.el (gnus-summary-backend-map): Bind B-backspace to
Michael Sperber [Mon, 9 Nov 2015 01:58:00 +0000 (01:58 +0000)]
* gnus-sum.el (gnus-summary-backend-map): Bind B-backspace to
`gnus-summary-delete-article` in a way that also works on XEmacs.

3 years agontlm.el: Change version to 2.0.0
Thomas Fitzsimmons [Sun, 1 Nov 2015 09:02:36 +0000 (09:02 +0000)]
ntlm.el: Change version to 2.0.0

3 years agoauth-source.el: Silence lexical-binding warnings
Stefan Monnier [Fri, 30 Oct 2015 13:52:00 +0000 (13:52 +0000)]
auth-source.el: Silence lexical-binding warnings

* auth-source.el (auth-source-netrc-use-gpg-tokens):
Simplify (symbol-value 'VAR) to just VAR.
(auth-source-backend-parse): Use make-instance.
(auth-source-search): Remove unused key args.
Remove unused vars `accessor-key' and `backend'.  Avoid `eval'.
(auth-source-search-backends): Use slot names rather than their initarg.
(auth-source-netrc-create):
(auth-source-delete):
(auth-source-secrets-create, auth-source-plstore-search)
(auth-source-macos-keychain-create, auth-source-macos-keychain-search)
(auth-source-plstore-create, auth-source-netrc-search)
(auth-source-netrc-parse): Remove unused key args.
(auth-source-forget+): Simplify the arglist.
(auth-source-macos-keychain-search-items)
(auth-source-token-passphrase-callback-function): Mark unused args.
(auth-source-epa-extract-gpg-token): Remove unused var `plain'.
(pp-escape-newlines): Declare.
(auto-source--symbol-keyword): New function.
(auth-source-plstore-create, auth-source-netrc-create)
(auth-source-netrc-normalize): Use it.
(auth-source-netrc-search): Don't pass :delete to
auth-source-netrc-parse since it doesn't use it.
(auth-source-plstore-create, auth-source-netrc-create): Use plist-get
symbol-value to index in keyword args.
(auth-source-macos-keychain-result-append): Avoid setq.
(auth-source-netrc-create): Remove unused vars `file' and `add'.
(auth-source-user-or-password): Remove unused var `cname'.

3 years agognus-topic.el: Silence some warnings
Stefan Monnier [Wed, 28 Oct 2015 02:35:38 +0000 (02:35 +0000)]
gnus-topic.el: Silence some warnings

* gnus-topic.el (gnus-topic-prepare-topic): Remove unused var `topic'.
(gnus-topic-remove-topic): Mark unused arg `hide'.
(gnus-tmp-header): Declare.
(gnus-topic-goto-missing-group): Remove unused var `entry'.
(gnus-topic-unmark-topic): Mark unused arg `dummy'.
(gnus-topic-copy-matching): Mark unused arg `copyp'.
Move initialization of `topic' into its declaration.

3 years agoauth-source.el: Revert last change
Katsumi Yamaoka [Fri, 23 Oct 2015 02:42:51 +0000 (02:42 +0000)]
auth-source.el: Revert last change

3 years agoFix auth-source-epa-make-gpg-token compilation (bug#21724)
Katsumi Yamaoka [Fri, 23 Oct 2015 00:09:14 +0000 (00:09 +0000)]
Fix auth-source-epa-make-gpg-token compilation (bug#21724)

cf. <http://thread.gmane.org/gmane.emacs.bugs/107802>

* auth-source.el: Add eval-and-compile to autoloads for
epg-context-set-passphrase-callback, epg-decrypt-string,
epg-encrypt-string, and epg-context-set-armor.

3 years agoRemove fboundp checks from mailcap-mime-data
Katsumi Yamaoka [Thu, 22 Oct 2015 00:08:03 +0000 (00:08 +0000)]
Remove fboundp checks from mailcap-mime-data

* mailcap.el (mailcap-mime-data): Remove fboundp checks.
(mailcap-viewer-passes-test): Do it instead.  Thanks to Stefan Monnier.

3 years agolisp/ChangeLog: Date fix
Katsumi Yamaoka [Wed, 21 Oct 2015 05:37:57 +0000 (05:37 +0000)]
lisp/ChangeLog: Date fix

3 years agomailcap.el (mailcap-mailcap-entry-passes-test): Doc fix
Katsumi Yamaoka [Wed, 21 Oct 2015 05:36:45 +0000 (05:36 +0000)]
mailcap.el (mailcap-mailcap-entry-passes-test): Doc fix

3 years ago* mailcap.el (mailcap-mime-data): Conditonalize `doc-view-mode',
Michael Sperber [Tue, 20 Oct 2015 11:18:07 +0000 (11:18 +0000)]
* mailcap.el (mailcap-mime-data): Conditonalize `doc-view-mode',
which does not exist on XEmacs.

3 years agoBind `rmail-dont-reply-to-names'
Michael Sperber [Mon, 19 Oct 2015 14:26:00 +0000 (14:26 +0000)]
Bind `rmail-dont-reply-to-names'

* message.el (message-get-reply-headers): In addition to
`mail-dont-reply-to-names', bind `rmail-dont-reply-to-names', which is
used in XEmacs.

3 years agoUnbreak `group' option for `mail-sources'
Michael Sperber [Mon, 19 Oct 2015 14:18:27 +0000 (14:18 +0000)]
Unbreak `group' option for `mail-sources'

* nnml.el (nnml-retrieve-groups, nnml-request-scan):
* nnmail.el (nnmail-get-new-mail-per-group):
(nnmail-get-new-mail-1): Unbreak `group' option for `mail-sources'.

3 years agoauth-source.el (auth-source-epa-make-gpg-token): Revert
Katsumi Yamaoka [Wed, 14 Oct 2015 00:59:28 +0000 (00:59 +0000)]
auth-source.el (auth-source-epa-make-gpg-token): Revert

3 years agolisp/ChangeLog: Fix date
Katsumi Yamaoka [Mon, 12 Oct 2015 22:29:41 +0000 (22:29 +0000)]
lisp/ChangeLog: Fix date

3 years ago* auth-source.el (auth-source-epa-make-gpg-token):
Nicolas Petton [Mon, 12 Oct 2015 22:23:54 +0000 (22:23 +0000)]
* auth-source.el (auth-source-epa-make-gpg-token):
Replace an usage of `epg-context-set-armor' with `setf'.

3 years agoauth-source.el: Use sharp-quoting with functions
Nicolas Petton [Mon, 12 Oct 2015 22:21:33 +0000 (22:21 +0000)]
auth-source.el: Use sharp-quoting with functions

* auth-source.el (auth-source-do-debug, auth-source-do-trivia)
(auth-source-read-char-choice, auth-source-search)
(auth-source-pick-first-password, auth-source-netrc-parse)
(auth-source-netrc-search, auth-source-secrets-search)
(auth-source-macos-keychain-search)
(auth-source-macos-keychain-search-items, auth-source-plstore-search)
(auth-source-user-or-password): Use sharp-quoting with functions.

3 years agoauth-source.el (auth-source-search): Clarify :create's meaning
Wieland Hoffmann [Wed, 30 Sep 2015 11:16:21 +0000 (11:16 +0000)]
auth-source.el (auth-source-search): Clarify :create's meaning

3 years agoBackslash cleanup in Elisp source files
Paul Eggert [Fri, 18 Sep 2015 00:51:57 +0000 (00:51 +0000)]
Backslash cleanup in Elisp source files

This patch should not change behavior.  It typically omits backslashes
where they are redundant (e.g., in the string literal "^\$").
In a few places, insert backslashes where they make regular expressions
clearer: e.g., replace "^\*" (equivalent to "^*") with "^\\*", which
has the same effect as a regular expression.
Also, use ‘\ %’ instead of ‘\%’ when avoiding confusion with SCCS IDs,
and similarly use ‘\ $’ instead of ‘\$’ when avoiding confusion
with RCS IDs, as that makes it clearer that the backslash is intended.
* auth-source.el (auth-source-secrets-search)
(auth-source-macos-keychain-search):
* gnus-art.el (gnus-mime-action-on-part)
(gnus-mime-display-multipart-related-as-mixed)
(gnus-button-mid-or-mail-heuristic-alist)
(gnus-button-mid-or-mail-heuristic, gnus-article-extend-url-button):
* gnus-bookmark.el (gnus-bookmark-bmenu-toggle-infos)
(gnus-bookmark-bookmark-inline-details, gnus-bookmark-bookmark-details)
(gnus-bookmark-alist, gnus-bookmark-name-from-full-record)
(gnus-bookmark-bmenu-mode, gnus-bookmark-delete):
* gnus-cus.el (gnus-group-customize):
* gnus-group.el (gnus-group-line-format, gnus-group-mode-line-format)
(gnus-group-jump-to-group-prompt, gnus-group-name-at-point):
* gnus-mlspl.el (gnus-group-split-fancy):
* gnus-registry.el (gnus-registry-prune-factor):
* gnus-salt.el (gnus-summary-pick-line-format):
* gnus-sieve.el (gnus-sieve-update, gnus-sieve-generate)
(gnus-sieve-script):
* gnus-util.el (gnus-directory-sep-char-regexp):
* gnus.el (gnus-message-archive-group, gnus-user-agent):
* message.el (message-archive-header, message-reply-headers)
(message-send-method-alist):
* mm-decode.el (mm-add-meta-html-tag):
* nndoc.el (nndoc-generate-lanl-gov-head):
* nnheader.el (nnheader-max-head-length):
* registry.el (registry-db, registry-prune):
* rfc1843.el (rfc1843-hzp-word-regexp)
(rfc1843-hzp-word-regexp-strictly):
* rfc2047.el (rfc2047-encoded-word-regexp)
(rfc2047-encoded-word-regexp-loose):

3 years agoFix several backslash typos in Elisp strings
Paul Eggert [Thu, 17 Sep 2015 23:03:27 +0000 (23:03 +0000)]
Fix several backslash typos in Elisp strings

* gnus-art.el (gnus-button-handle-library):
* gnus-group.el (gnus-read-ephemeral-gmane-group-url):
* nntp.el (nntp-via-shell-prompt, nntp-telnet-shell-prompt):
* spam-report.el (spam-report-gmane-regex):
Fix typo by replacing ‘\’ with ‘\\’ in a string literal.
For example, to get the regular expression ‘\.’ use the string
literal "\\.", not "\." (which is equivalent to ".").

Doc fixes
* auth-source.el (auth-source-read-char-choice):
* nnmaildir.el (NOV example):
* registry.el (registry-search):

3 years agomm-uu.el (mm-uu-type-alist): Use proper accents in Peter von der Ahé’s name
Paul Eggert [Thu, 17 Sep 2015 11:08:57 +0000 (11:08 +0000)]
mm-uu.el (mm-uu-type-alist): Use proper accents in Peter von der Ahé’s name

3 years agognus-faq.texi: Minor backslash fix
Paul Eggert [Thu, 17 Sep 2015 00:17:47 +0000 (00:17 +0000)]
gnus-faq.texi: Minor backslash fix

* gnus-faq.texi (FAQ 5-8):
Avoid undefined behavior in suggested sed backslash usage.

3 years agognus-compat.el: Require overlay for XEmacs
Katsumi Yamaoka [Mon, 14 Sep 2015 00:20:43 +0000 (00:20 +0000)]
gnus-compat.el: Require overlay for XEmacs

3 years agomessage.el (message-hide-headers): Bind inhibit-modification-hooks to t rather than...
Stefan Monnier [Sat, 12 Sep 2015 14:03:37 +0000 (14:03 +0000)]
message.el (message-hide-headers): Bind inhibit-modification-hooks to t rather than after-change-functions to nil

3 years agotime-date.el (time-to-seconds, time-less-p): Mark unused vars with underscore
Stefan Monnier [Wed, 9 Sep 2015 22:32:29 +0000 (22:32 +0000)]
time-date.el (time-to-seconds, time-less-p): Mark unused vars with underscore

3 years agotime-date.el (with-decoded-time-value): Fix debug spec
Stefan Monnier [Tue, 8 Sep 2015 22:10:00 +0000 (22:10 +0000)]
time-date.el (with-decoded-time-value): Fix debug spec

3 years agoGo back to grave quoting in source-code docstrings etc.
Paul Eggert [Tue, 8 Sep 2015 05:13:29 +0000 (05:13 +0000)]
Go back to grave quoting in source-code docstrings etc.

This reverts almost all my recent changes to use curved quotes
in docstrings and/or strings used for error diagnostics.

* gnus-faq.texi (FAQ 5-13, FAQ 6-2):
* gnus.texi (Score Decays, SpamAssassin):
* nnmairix.el (nnmairix-widget-create-query):
* time-date.el (format-seconds): Prefer grave quoting in source-code
strings used to generate help and diagnostics.

3 years agontlm.el: Bump version to 2.00; New maintainer; Add comm keyword
Thomas Fitzsimmons [Mon, 7 Sep 2015 04:12:36 +0000 (04:12 +0000)]
ntlm.el: Bump version to 2.00; New maintainer; Add comm keyword

3 years agolisp/ChangeLog: Update
Katsumi Yamaoka [Sun, 6 Sep 2015 23:44:03 +0000 (23:44 +0000)]
lisp/ChangeLog: Update

3 years agontlm.el (ntlm-unibyte-string): Make it a macro, not an alias
Katsumi Yamaoka [Sun, 6 Sep 2015 23:42:15 +0000 (23:42 +0000)]
ntlm.el (ntlm-unibyte-string): Make it a macro, not an alias

3 years agontlm.el: Add support for NTLMv2 authentication
Thomas Fitzsimmons [Sun, 6 Sep 2015 23:24:14 +0000 (23:24 +0000)]
ntlm.el: Add support for NTLMv2 authentication

* ntlm.el (ntlm): New customization group.
(ntlm-compatibility-level): New defcustom.
(ntlm-compute-timestamp): New function.
(ntlm-generate-nonce): Likewise.
(ntlm-build-auth-response): Add support for NTLMv2 authentication.

3 years agoFix minor problems with " in manual
Paul Eggert [Sun, 6 Sep 2015 13:11:24 +0000 (13:11 +0000)]
Fix minor problems with " in manual

* gnus-faq.texi (FAQ 4-8, FAQ 4-12, FAQ 4-14):
* gnus.texi (Archived Messages): Fix minor problems with " in manual.

3 years agolisp/ChangeLog (2015-09-04): Add missing entry
Katsumi Yamaoka [Sun, 6 Sep 2015 12:56:31 +0000 (12:56 +0000)]
lisp/ChangeLog (2015-09-04): Add missing entry

3 years agoMake the imap mail-source's :mailbox handle a list
Adam Sjøgren [Fri, 4 Sep 2015 15:41:07 +0000 (17:41 +0200)]
Make the imap mail-source's :mailbox handle a list

* mail-source.el (mail-source-fetch-imap): allow :mailbox to be
a list.

3 years agonnimap.el: Handle nil arg to nnimap-request-group
Eric Abrahamsen [Sat, 5 Sep 2015 02:09:04 +0000 (10:09 +0800)]
nnimap.el:  Handle nil arg to nnimap-request-group

* nnimap.el (nnimap-request-group):  Handle nil "info" arg.  This arg
isn't always passed in, check it's not nil before making it into a list.
The active arg will also be nil if the group is new, check for that.

3 years agoFix some more docstring etc. quoting problems
Paul Eggert [Thu, 3 Sep 2015 23:30:45 +0000 (23:30 +0000)]
Fix some more docstring etc. quoting problems

Mostly these fixes prevent the transliteration of apostrophes
that should stay apostrophes.  Also, prefer curved quotes in
Bahá’í proper names, as that’s the preferred Bahá’í style and
these names are chock-full of non-ASCII characters anyway.

3 years agoEscape ` and ' in doc
Paul Eggert [Wed, 2 Sep 2015 05:29:33 +0000 (05:29 +0000)]
Escape ` and ' in doc

* gnus-art.el (gnus-article-address-banner-alist)
(gnus-face-properties-alist):
* gnus-sum.el (gnus-newsgroup-variables):
* nndiary.el (nndiary-reminders):
* nnmail.el (nnmail-fancy-expiry-targets, nnmail-split-fancy):
Escape apostrophes and grave accents in docstrings if they
are supposed to stand for themselves and are not quotes.  Remove
apostrophes from docstring examples like ‘'(calendar-nth-named-day
-1 0 10 year)’ that confuse source code with data.  Do some other
minor docstring fixups as well, e.g., insert a missing close
quote.

3 years agoUse defalias at the top level
Katsumi Yamaoka [Tue, 1 Sep 2015 23:00:14 +0000 (23:00 +0000)]
Use defalias at the top level

* gnus-util.el (gnus-format-message):
* tls.el (tls-format-message): Use defalias at the top level so as to
make eval-and-compile unnecessary.  Thanks to Stefan Monnier.

3 years ago* gnus-sum.el (gnus-summary-search-article):
Katsumi Yamaoka [Tue, 1 Sep 2015 06:14:08 +0000 (06:14 +0000)]
* gnus-sum.el (gnus-summary-search-article):
Ensure that the article where the search word is found is displayed
and pointed to in the summary buffer.

3 years agotls.el (tls-format-message): Eval-and-compile
Katsumi Yamaoka [Mon, 31 Aug 2015 23:42:45 +0000 (23:42 +0000)]
tls.el (tls-format-message): Eval-and-compile

3 years agotls.el: Compilation fix
Katsumi Yamaoka [Mon, 31 Aug 2015 23:41:00 +0000 (23:41 +0000)]
tls.el: Compilation fix

* tls.el (tls-format-message):
Alias to format-message, or format if not available.
(open-tls-stream): Use it.

3 years agoQuoting fixes
Paul Eggert [Mon, 31 Aug 2015 22:28:22 +0000 (22:28 +0000)]
Quoting fixes

* gnus-agent.el (gnus-agent-possibly-synchronize-flags-server):
* gnus-art.el (gnus-article-browse-delete-temp-files):
* gnus-eform.el (gnus-edit-form):
* gnus-fun.el (gnus-display-x-face-in-from):
* gnus-group.el (gnus-group-edit-group, gnus-group-nnimap-edit-acl):
* gnus-topic.el (gnus-topic-edit-parameters):
* mail-source.el (mail-source-delete-old-incoming):
* message.el (message-strip-subject-encoded-words)
(message-check-recipients, message-send-form-letter):
* mm-decode.el (mm-display-part):
* mm-uu.el (mm-uu-pgp-signed-extract-1):
* mml-smime.el (mml-smime-get-dns-cert, mml-smime-get-ldap-cert):
* spam-report.el (spam-report-process-queue):
* tls.el (open-tls-stream):
Respect ‘text-quoting-style’ in diagnostics.
* gnus-art.el (article-display-face):
* gnus-fun.el (gnus-display-x-face-in-from):
Use straight quoting in email.
* rfc2231.el (rfc2231-decode-encoded-string):
Escape apostrophes in doc strings.

3 years agoDocumentation fixes re quotes
Paul Eggert [Mon, 31 Aug 2015 22:15:30 +0000 (22:15 +0000)]
Documentation fixes re quotes

* gnus-faq.texi (FAQ 5-13, FAQ 6-2):
* gnus.texi (Score Decays, SpamAssassin):
Prefer curved quotes in examples if users will typically see curved
quotes when the examples run.

3 years agoepa.texi (Encrypting/decrypting gpg files): Fix a typo
Daiki Ueno [Fri, 28 Aug 2015 01:56:34 +0000 (01:56 +0000)]
epa.texi (Encrypting/decrypting gpg files): Fix a typo

3 years agoGo back to grave quoting in Gnus
Paul Eggert [Wed, 26 Aug 2015 04:54:05 +0000 (04:54 +0000)]
Go back to grave quoting in Gnus

* auth-source.el (auth-source-netrc-parse-entries):
* gnus-agent.el (gnus-agent-check-overview-buffer)
(gnus-agent-fetch-headers):
* gnus-int.el (gnus-start-news-server):
* gnus-registry.el (gnus-registry--split-fancy-with-parent-internal)
(gnus-registry-post-process-groups):
* gnus-score.el (gnus-summary-increase-score):
* gnus-start.el (gnus-convert-old-newsrc):
* gnus-topic.el (gnus-topic-rename):
* legacy-gnus-agent.el (gnus-agent-unlist-expire-days):
* spam.el (spam-check-blackholes):
Stick with grave quoting in diagnostics strings.  This is more
portable to older Emacs, desirable for Gnus.

3 years agolisp/ChangeLog: Fix last commit
Katsumi Yamaoka [Tue, 25 Aug 2015 09:23:28 +0000 (09:23 +0000)]
lisp/ChangeLog: Fix last commit

3 years agoGnus format-message typo fix
Paul Eggert [Tue, 25 Aug 2015 09:17:02 +0000 (09:17 +0000)]
Gnus format-message typo fix

* gnus-util.el (gnus-format-message):
Fix typo when running in older Emacs.

3 years agoPrefer directed to neutral quotes
Paul Eggert [Tue, 25 Aug 2015 09:14:34 +0000 (09:14 +0000)]
Prefer directed to neutral quotes

Prefer directed to neutral quotes in docstings and diagnostics.
In docstrings, escape apostrophes that would otherwise be translated
to curved quotes using the newer, simpler rules.

* auth-source.el (auth-source-netrc-parse-entries):
* gnus-agent.el (gnus-agent-check-overview-buffer)
(gnus-agent-fetch-headers):
* gnus-int.el (gnus-start-news-server):
* gnus-registry.el (gnus-registry--split-fancy-with-parent-internal):
* gnus-score.el (gnus-summary-increase-score):
* gnus-start.el (gnus-convert-old-newsrc):
* gnus-topic.el (gnus-topic-rename):
* legacy-gnus-agent.el (gnus-agent-unlist-expire-days):
* nnmairix.el (nnmairix-widget-create-query):
* spam.el (spam-check-blackholes):
Use directed rather than neutral quotes in diagnostics.

3 years ago* auth-source.el (auth-sources):
Paul Eggert [Sat, 22 Aug 2015 03:47:41 +0000 (03:47 +0000)]
* auth-source.el (auth-sources):
Prefer (substitute-command-keys "`\\[foo-command]'")
to "`M-x foo-command'" in docstring.

* time-date.el (format-seconds):
Use curved quotes in diagnostic format strings.

3 years agoDon't quote symbols 'like-this' in docstrings
Paul Eggert [Fri, 21 Aug 2015 00:56:48 +0000 (00:56 +0000)]
Don't quote symbols 'like-this' in docstrings

* nnmairix.el (nnmairix-propagate-marks-upon-close):
* pop3.el (pop3-authentication-scheme):
Don't quote symbols with apostrophes in doc strings.
Use asymmetric quotes instead.

4 years agolisp/ChangeLog: Fix typo
Katsumi Yamaoka [Wed, 19 Aug 2015 10:40:57 +0000 (10:40 +0000)]
lisp/ChangeLog: Fix typo

4 years agoUse overlay functions directly
Katsumi Yamaoka [Wed, 19 Aug 2015 09:02:48 +0000 (09:02 +0000)]
Use overlay functions directly

4 years agonnmaildir.el (nnmaildir-flag-mark-mapping): Add "P"
Glenn Morris [Wed, 19 Aug 2015 07:50:19 +0000 (07:50 +0000)]
nnmaildir.el (nnmaildir-flag-mark-mapping): Add "P"

4 years agomessage.el: Silent the byte compiler
Katsumi Yamaoka [Tue, 18 Aug 2015 01:35:23 +0000 (01:35 +0000)]
message.el: Silent the byte compiler

* message.el (message-overlay-put, message-make-overlay)
(message-kill-all-overlays, message-overlays-in, message-overlay-get)
(message-delete-overlay, message-window-inside-pixel-edges):
Declare before using.

4 years agoWork for XEmacs
Katsumi Yamaoka [Mon, 17 Aug 2015 23:14:12 +0000 (23:14 +0000)]
Work for XEmacs

* message.el (message-overlay-get, message-overlays-in)
(message-window-inside-pixel-edges):
* messagexmas.el (message-overlay-get, message-overlays-in):
XEmacs compatible functions.

4 years ago* message.el (message-toggle-image-thumbnails): New command.
Lars Magne Ingebrigtsen [Mon, 17 Aug 2015 21:50:34 +0000 (23:50 +0200)]
* message.el (message-toggle-image-thumbnails): New command.

4 years agomessage.el (message-send-form-letter): Fix confusion with `format'
Paul Eggert [Thu, 6 Aug 2015 04:16:45 +0000 (04:16 +0000)]
message.el (message-send-form-letter): Fix confusion with `format'

4 years agolisp/ChangeLog: Fix date
Katsumi Yamaoka [Tue, 4 Aug 2015 22:37:42 +0000 (22:37 +0000)]
lisp/ChangeLog: Fix date

4 years agoDo not overwrite preexisting contents of unread-command-events
David Kastrup [Tue, 4 Aug 2015 22:23:13 +0000 (22:23 +0000)]
Do not overwrite preexisting contents of unread-command-events

* gnus-art.el (gnus-article-describe-key)
(gnus-article-describe-key-briefly)

4 years agonnimap.el: Use IMAP MOVE extension if available
Nikolaus Rath [Sat, 11 Jul 2015 04:22:24 +0000 (12:22 +0800)]
nnimap.el: Use IMAP MOVE extension if available

* nnimap.el (nnimap-request-move-article, nnimap-process-expiry-targets,
  nnimap-split-incoming-mail): Use MOVE extension if available.

4 years agonnimap.el: Explicitly ask for server capabilities
Eric Abrahamsen [Sun, 2 Aug 2015 05:13:43 +0000 (13:13 +0800)]
nnimap.el: Explicitly ask for server capabilities

* lisp/nnimap.el (nnimap-open-connection-1): Don't assume full
  capabilities will be returned in the login-result.

4 years agoDon't overflow if computing approximate percentage
Paul Eggert [Sat, 1 Aug 2015 22:43:52 +0000 (22:43 +0000)]
Don't overflow if computing approximate percentage

* nnbabyl.el (nnbabyl-retrieve-headers):
* nndiary.el (nndiary-retrieve-headers):
* nneething.el (nneething-retrieve-headers):
* nnmbox.el (nnmbox-retrieve-headers):
* nnmh.el (nnmh-retrieve-headers):
* nnml.el (nnml-retrieve-headers):
* nnspool.el (nnspool-retrieve-headers):
* nntp.el (nntp-retrieve-headers, nntp-retrieve-articles):
Prefer (floor (* 100.0 NUMERATOR) DENOMINATOR) when calculating
progress-report percentages and the like.  This avoids problems
if (* 100 NUMERATOR) would overflow.

* gnus-registry.el (gnus-registry-import-eld):
* registry.el (registry-reindex):
Use (* 100.0 ...) rather than (* 100 ...) to avoid int overflow issues.

4 years agosieve-mode: support "body" test command
Julien Danjou [Fri, 17 Jul 2015 08:52:25 +0000 (10:52 +0200)]
sieve-mode: support "body" test command

4 years agolisp/ChangeLog: Rearrange entries in chronological order
Katsumi Yamaoka [Thu, 16 Jul 2015 01:45:42 +0000 (01:45 +0000)]
lisp/ChangeLog: Rearrange entries in chronological order

4 years agonnimap.el: Clean up "unused var" warnings
Stefan Monnier [Wed, 15 Jul 2015 23:08:07 +0000 (23:08 +0000)]
nnimap.el: Clean up "unused var" warnings

(auth-source-creation-prompts): Declare.
(nnimap-retrieve-headers, nnimap-status-message)
(nnimap-request-create-group, nnimap-request-delete-group)
(nnimap-close-group, nnimap-request-move-article)
(nnimap-request-accept-article, nnimap-request-newgroups)
(nnimap-request-post, nnimap-dummy-active-number)
(nnimap-save-mail-spec, nnimap-get-groups): Add _ to unused vars.
(nnimap-parse-flags): Remove unused var `p'.
(nnimap-retrieve-group-data-early): Remove unused var `groups'.
(nnimap-flags-to-marks): Remove unused var `totalp'.

4 years agognus-registry.el: Correct function argument order.
Eric Abrahamsen [Sat, 11 Jul 2015 07:10:06 +0000 (15:10 +0800)]
gnus-registry.el: Correct function argument order.

* gnus-registry.el (gnus-registry--set/remove-mark): Reverse the order
of function arguments.

4 years agonnimap.el: Fix IMAP message size parsing
Nikolaus Rath [Sat, 11 Jul 2015 03:26:40 +0000 (11:26 +0800)]
nnimap.el: Fix IMAP message size parsing

* lisp/nnimap.el: Don't assume UID comes before RFC822.SIZE.

4 years agolisp/ChangeLog, texi/ChangeLog: Fix last commit
Katsumi Yamaoka [Thu, 9 Jul 2015 03:46:27 +0000 (03:46 +0000)]
lisp/ChangeLog, texi/ChangeLog: Fix last commit

4 years agonnimap.el: Handle plain value for nnimap-stream
Nikolaus Rath [Wed, 8 Jul 2015 03:52:45 +0000 (20:52 -0700)]
nnimap.el: Handle plain value for nnimap-stream

* lisp/nnimap.el (nnimap-open-connection-1): Always query capabilities,
  so that a 'plain value for the `nnimap-stream' server variable is
  handled correctly.
* texi/gnus.texi: Document the 'plain option.

4 years agolisp/ChangeLog: Update for the recent changes
Katsumi Yamaoka [Wed, 8 Jul 2015 22:24:23 +0000 (22:24 +0000)]
lisp/ChangeLog: Update for the recent changes

4 years agoRemove unused let variables
Eric Abrahamsen [Tue, 7 Jul 2015 03:08:35 +0000 (11:08 +0800)]
Remove unused let variables

* lisp/nnimap.el (nnimap-request-group): Variables are not used.

4 years agoCheck if group names are already strings
Eric Abrahamsen [Tue, 7 Jul 2015 03:01:38 +0000 (11:01 +0800)]
Check if group names are already strings

* lisp/gnus-group.el (gnus-group-group-name): The group name may
  already be a string.

Specifically, in the group list reached from the *Server* buffer, the
'gnus-group text property returns a string. Everywhere else it returns
a symbol.

4 years agonnmaildir.el: Silence lexical warnings
Stefan Monnier [Wed, 24 Jun 2015 22:27:46 +0000 (22:27 +0000)]
nnmaildir.el: Silence lexical warnings

* nnmaildir.el (nnmaildir--prepare): Use a more functional style.
(nnmaildir--update-nov): Remove unused var `numdir'.
(nnmaildir-request-type, nnmaildir--scan, nnmaildir-request-newgroups)
(nnmaildir-request-group, nnmaildir-request-create-group)
(nnmaildir-request-post, nnmaildir-request-move-article)
(nnmaildir-request-accept-article, nnmaildir-active-number):
Mark unused args.
(nnmaildir-get-new-mail, nnmaildir-group-alist, nnmaildir-active-file):
Declare.
(nnmaildir-request-scan): Remove unused vars `group' and `grp-dir'.
(nnmaildir-request-update-info): Remove unused vars `dotfile', `num',
`mark', `end', `new-mark', and `mark-sym'.
(nnmaildir-retrieve-headers):
Remove unused args `srv-dir', `dir', `nlist2'.
(nnmaildir-request-expire-articles):
Remove unused vars `article', `stop' and `nlist2'.
(nnmaildir-request-set-mark): Remove unused vars `begin', `article' and
`end'.  Use nnmaildir--article when dyn-binding is needed.
Give the value directly in the `let' for `del-mark', `del-action',
`add-action', and `set-action'.  Don't use `add-to-list' on a local var.
(nnmaildir-close-server):
Declare those local vars that need to be dyn-bound.

4 years agognus-art.el (gnus-button-alist): Also support quotes 'like this'
Paul Eggert [Wed, 3 Jun 2015 06:38:08 +0000 (06:38 +0000)]
gnus-art.el (gnus-button-alist): Also support quotes 'like this'

4 years agognustest-nntp: Do not use `sleep-for' to wait for ping
David Engster [Sun, 31 May 2015 10:11:48 +0000 (12:11 +0200)]
gnustest-nntp: Do not use `sleep-for' to wait for ping

* tests/gnustest-nntp.el (gnustest-ping-host): Call 'sleep' binary
instead of using `sleep-for', as the latter does not seem to reliably
wait (see for instance bug 15990).

4 years agonnimap.el (nnimap-get-groups): Use \\r rather than ^M in string literals
Paul Eggert [Sun, 31 May 2015 00:08:39 +0000 (00:08 +0000)]
nnimap.el (nnimap-get-groups): Use \\r rather than ^M in string literals

4 years agolisp/ChangeLog: Update
Katsumi Yamaoka [Thu, 28 May 2015 23:50:22 +0000 (23:50 +0000)]
lisp/ChangeLog: Update

4 years agoTry reinstalling Paul Eggert's `gnus-button-alist' change to investigate why the...
Katsumi Yamaoka [Thu, 28 May 2015 23:41:13 +0000 (23:41 +0000)]
Try reinstalling Paul Eggert's `gnus-button-alist' change to investigate why the buildbot fails

4 years agoRevert my change to gnus-art.el
Paul Eggert [Thu, 28 May 2015 09:00:48 +0000 (09:00 +0000)]
Revert my change to gnus-art.el

* gnus-art.el (gnus-button-alist): Revert last change.
It wasn't that important, and it caused a Gnus build to fail.  See:
http://www.randomsample.de:4456/builders/emacs-devel/builds/734

4 years agosmime.el (smime-CA-directory): Fix minor quoting problems in doc string
Paul Eggert [Thu, 28 May 2015 08:00:22 +0000 (08:00 +0000)]
smime.el (smime-CA-directory): Fix minor quoting problems in doc string

4 years agoSupport curved quotes
Paul Eggert [Thu, 28 May 2015 07:55:30 +0000 (07:55 +0000)]
Support curved quotes

* gnus-art.el (gnus-button-alist):
Also treat "‘" and "’" as quoting chars.

4 years agoDon't quote nil and t in doc strings
Paul Eggert [Thu, 21 May 2015 22:25:43 +0000 (22:25 +0000)]
Don't quote nil and t in doc strings

This is as per "Tips for Documentation Strings" in the elisp manual.
For consistency, do the same in diagnostics and comments.

4 years agoPrefer "this" to “this” in doc strings
Paul Eggert [Wed, 20 May 2015 02:31:14 +0000 (02:31 +0000)]
Prefer "this" to “this” in doc strings

This mostly just straightens quotes introduced in my previous patch.
Suggested by Dmitry Gutov in:
http://lists.gnu.org/archive/html/emacs-devel/2015-05/msg00565.html

* gnus-group.el (gnus-group-nnimap-edit-acl):
Prefer straight double quotes to curved double quotes in doc strings.

4 years agoFix minor quoting problems in doc strings
Paul Eggert [Tue, 19 May 2015 22:25:31 +0000 (22:25 +0000)]
Fix minor quoting problems in doc strings

These were glitches regardless of how or whether we tackle the
problem of grave accent in doc strings.

* gnus-art.el (gnus-treat-strip-list-identifiers)
(gnus-article-mode-syntax-table):
* gnus-group.el (gnus-group-nnimap-edit-acl):
* canlock.el, deuglify.el: Fix minor quoting problems in doc strings,
e.g., missing quote, ``x'' where `x' was meant, etc.

4 years agoformat-spec.el: Work for XEmacs
Katsumi Yamaoka [Thu, 14 May 2015 04:38:28 +0000 (04:38 +0000)]
format-spec.el: Work for XEmacs

(format-spec, format-spec-make): Use (char-to-int c) instead
 of (+ c 0) that the byte compiler optimizes into just c.

4 years agoformat-spec.el: Work for XEmacs
Katsumi Yamaoka [Mon, 11 May 2015 00:49:29 +0000 (00:49 +0000)]
format-spec.el: Work for XEmacs

(format-spec, format-spec-make): Normalize characters into numbers in spec keys.

4 years agognus-util.el (iswitchb-mode): Declare
Glenn Morris [Sat, 9 May 2015 01:56:48 +0000 (01:56 +0000)]
gnus-util.el (iswitchb-mode): Declare