gnus-html-image-fetched: check for errors

Signed-off-by: Julien Danjou <julien@danjou.info>

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index a664363..4321ce6 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -4,6 +4,7 @@
        variable.
        (gnus-html-image-fetched): Only cache if
        gnus-html-image-automatic-caching is set.
+       (gnus-html-image-fetched): Check for errors.
 
 2010-09-22  Lars Magne Ingebrigtsen  <larsi@gnus.org>
 

diff --git a/lisp/gnus-html.el b/lisp/gnus-html.el
index cb466b3..6879bb2 100644 (file)
--- a/lisp/gnus-html.el
+++ b/lisp/gnus-html.el
@@ -352,15 +352,16 @@ Use ALT-TEXT for the image string."
 
 (defun gnus-html-image-fetched (status buffer image)
   "Callback function called when image has been fetched."
-  (when gnus-html-image-automatic-caching
-    (url-store-in-cache (current-buffer)))
-  (when (and (or (search-forward "\n\n" nil t)
-                 (search-forward "\r\n\r\n" nil t))
-             (buffer-live-p buffer))
-    (let ((data (buffer-substring (point) (point-max))))
-      (with-current-buffer buffer
-        (let ((inhibit-read-only t))
-          (gnus-html-put-image data (car image) (cadr image))))))
+  (unless (plist-get status :error)
+    (when gnus-html-image-automatic-caching
+      (url-store-in-cache (current-buffer)))
+    (when (and (or (search-forward "\n\n" nil t)
+                   (search-forward "\r\n\r\n" nil t))
+               (buffer-live-p buffer))
+      (let ((data (buffer-substring (point) (point-max))))
+        (with-current-buffer buffer
+          (let ((inhibit-read-only t))
+            (gnus-html-put-image data (car image) (cadr image)))))))
   (kill-buffer (current-buffer)))
 
 (defun gnus-html-get-image-data (url)