Avoid `Invalid face reference: nil' messages.

* gnus-spec.el (gnus-face-face-function): Don't use nil as no-op face
place holder since this gives `Invalid face reference: nil' messages.
Use the `default' face instead.  It has the same effect here, even
though it is not no-op.

* gnus-util.el
(gnus-put-text-property-excluding-characters-with-faces): Similarly.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 9ef0174..9ff2c02 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,13 @@
+2012-12-27  Wolfgang Jenkner  <wjenkner@inode.at>
+
+       * gnus-spec.el (gnus-face-face-function): Don't use nil as no-op face
+       place holder since this gives `Invalid face reference: nil' messages.
+       Use the `default' face instead.  It has the same effect here, even
+       though it is not no-op.
+
+       * gnus-util.el
+       (gnus-put-text-property-excluding-characters-with-faces): Similarly.
+
 2012-12-27  Lars Ingebrigtsen  <larsi@gnus.org>
 
        * gnus-msg.el (gnus-summary-resend-message): Don't bug out on

diff --git a/lisp/gnus-spec.el b/lisp/gnus-spec.el
index 22d4627..0b5203d 100644 (file)
--- a/lisp/gnus-spec.el
+++ b/lisp/gnus-spec.el
@@ -270,7 +270,7 @@ Return a list of updated types."
           ;; Delay consing the value of the `face' property until
           ;; `gnus-add-text-properties' runs, since it will be modified
           ;; by `gnus-put-text-property-excluding-characters-with-faces'.
-          (list ',(symbol-value (intern (format "gnus-face-%d" type))) nil)
+          (list ',(symbol-value (intern (format "gnus-face-%d" type))) 'default)
           ;; Redundant now, but still convenient.
           '(gnus-face t)))))
 

diff --git a/lisp/gnus-util.el b/lisp/gnus-util.el
index 705a9e0..fb218e5 100644 (file)
--- a/lisp/gnus-util.el
+++ b/lisp/gnus-util.el
@@ -875,7 +875,7 @@ Otherwise, do nothing."
     (let ((stop (next-single-property-change beg 'face nil end)))
       (if (get-text-property beg 'gnus-face)
          (when (eq prop 'face)
-           (setcar (cdr (get-text-property beg 'face)) val))
+           (setcar (cdr (get-text-property beg 'face)) (or val 'default)))
        (inline
          (gnus-put-text-property beg stop prop val)))
       (setq beg stop))))