From 18094baee115e9f9a2f58340b76463e4e88b389d Mon Sep 17 00:00:00 2001 From: Stefan Monnier Date: Wed, 28 Oct 2015 02:35:38 +0000 Subject: [PATCH] gnus-topic.el: Silence some warnings * gnus-topic.el (gnus-topic-prepare-topic): Remove unused var `topic'. (gnus-topic-remove-topic): Mark unused arg `hide'. (gnus-tmp-header): Declare. (gnus-topic-goto-missing-group): Remove unused var `entry'. (gnus-topic-unmark-topic): Mark unused arg `dummy'. (gnus-topic-copy-matching): Mark unused arg `copyp'. Move initialization of `topic' into its declaration. --- lisp/ChangeLog | 10 ++++++++++ lisp/gnus-topic.el | 21 ++++++++++----------- 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 7a244eb14..15ea10b23 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,13 @@ +2015-10-28 Stefan Monnier + + * gnus-topic.el (gnus-topic-prepare-topic): Remove unused var `topic'. + (gnus-topic-remove-topic): Mark unused arg `hide'. + (gnus-tmp-header): Declare. + (gnus-topic-goto-missing-group): Remove unused var `entry'. + (gnus-topic-unmark-topic): Mark unused arg `dummy'. + (gnus-topic-copy-matching): Mark unused arg `copyp'. + Move initialization of `topic' into its declaration. + 2015-10-23 Katsumi Yamaoka * auth-source.el: Revert. diff --git a/lisp/gnus-topic.el b/lisp/gnus-topic.el index 7c6e10981..b98978325 100644 --- a/lisp/gnus-topic.el +++ b/lisp/gnus-topic.el @@ -508,7 +508,6 @@ articles in the topic and its subtopics." (all-entries entries) (point-max (point-max)) (unread 0) - (topic (car type)) info entry end active tick) ;; Insert any sub-topics. (while topicl @@ -586,7 +585,7 @@ articles in the topic and its subtopics." (goto-char end) unread)) -(defun gnus-topic-remove-topic (&optional insert total-remove hide in-level) +(defun gnus-topic-remove-topic (&optional insert total-remove _hide in-level) "Remove the current topic." (let ((topic (gnus-group-topic-name)) (level (gnus-group-topic-level)) @@ -631,6 +630,8 @@ articles in the topic and its subtopics." (or insert (not (gnus-topic-visible-p))) nil nil 9) (gnus-topic-enter-dribble))))))) +(defvar gnus-tmp-header) + (defun gnus-topic-insert-topic-line (name visiblep shownp level entries &optional unread) (let* ((visible (if visiblep "" "...")) @@ -694,8 +695,7 @@ articles in the topic and its subtopics." (let* ((topic (gnus-group-topic group)) (groups (cdr (assoc topic gnus-topic-alist))) (g (cdr (member group groups))) - (unfound t) - entry) + (unfound t)) ;; Try to jump to a visible group. (while (and g (not (gnus-group-goto-group (car g) t))) @@ -1454,7 +1454,7 @@ If NON-RECURSIVE (which is the prefix) is t, don't mark its subtopics." (funcall (if unmark 'gnus-group-remove-mark 'gnus-group-set-mark) (gnus-info-group (nth 2 (pop groups))))))))) -(defun gnus-topic-unmark-topic (topic &optional dummy non-recursive) +(defun gnus-topic-unmark-topic (topic &optional _dummy non-recursive) "Remove the process mark from all groups in the TOPIC. If NON-RECURSIVE (which is the prefix) is t, don't unmark its subtopics." (interactive (list (gnus-group-topic-name) @@ -1488,15 +1488,14 @@ If NON-RECURSIVE (which is the prefix) is t, don't unmark its subtopics." (gnus-group-mark-regexp regexp) (gnus-topic-move-group nil topic copyp)) -(defun gnus-topic-copy-matching (regexp topic &optional copyp) +(defun gnus-topic-copy-matching (regexp topic &optional _copyp) "Copy all groups that match REGEXP to some topic." (interactive - (let (topic) + (let ((topic (gnus-completing-read "Copy to topic" + (mapcar #'car gnus-topic-alist) t))) (nreverse - (list - (setq topic (gnus-completing-read "Copy to topic" - (mapcar 'car gnus-topic-alist) t)) - (read-string (format "Copy to %s (regexp): " topic)))))) + (list topic + (read-string (format "Copy to %s (regexp): " topic)))))) (gnus-topic-move-matching regexp topic t)) (defun gnus-topic-delete (topic) -- 2.34.1