Steve Youngs [Thu, 29 Mar 2012 23:54:35 +0000 (09:54 +1000)]
UI related fixes/improvements from Nelson
* merges:
Disable non UI build. Too much going wrong for that to work
Only used old_fcntl_owner when compiling unixoid event loop
Remove old file moved away
Make FD_TO_USID available to non-unixoid event loops
Only abort due to no-tty when interactive
Move src/objects.c to src/ui
Move src/objects.c to src/ui
Nelson Ferreira [Tue, 27 Mar 2012 18:11:31 +0000 (15:11 -0300)]
Disable non UI build. Too much going wrong for that to work
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 22 Mar 2012 01:58:00 +0000 (22:58 -0300)]
Only used old_fcntl_owner when compiling unixoid event loop
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 22 Mar 2012 01:56:26 +0000 (22:56 -0300)]
Remove old file moved away
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 22 Mar 2012 01:55:03 +0000 (22:55 -0300)]
Make FD_TO_USID available to non-unixoid event loops
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 22 Mar 2012 01:54:03 +0000 (22:54 -0300)]
Only abort due to no-tty when interactive
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 22 Mar 2012 01:51:49 +0000 (22:51 -0300)]
Move src/objects.c to src/ui
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Thu, 22 Mar 2012 01:51:29 +0000 (22:51 -0300)]
Move src/objects.c to src/ui
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Fri, 16 Mar 2012 23:45:08 +0000 (09:45 +1000)]
Fix dumpfile from Sebastian
* merges:
Summary: major, rename .dmp file once more Keywords: bldchn dist
Summary: minor, kick sheap and friends Keywords: bldchn dumper
fix dist, configfsf.guess and configfsf.sub are also needed
Sebastian Freundt [Fri, 16 Mar 2012 11:23:22 +0000 (11:23 +0000)]
Merge branch 'bldchn' into next
* bldchn:
Summary: major, rename .dmp file once more Keywords: bldchn dist
Summary: minor, kick sheap and friends Keywords: bldchn dumper
fix dist, configfsf.guess and configfsf.sub are also needed
Sebastian Freundt [Fri, 16 Mar 2012 11:02:36 +0000 (11:02 +0000)]
Summary: major, rename .dmp file once more
Keywords: bldchn dist
This changeset outroduces the nuisance caused by the big build chain
clean up. In particular, the dump file name is now just sxemacs.dmp,
seeing as the version number in it was just redundant as it resides in
$(archlibdir) which contains a version number already.
* src/Makefile.am: dump file in $(archlibdir) needs no version number
* src/dumper.c: reduce pdump_file_try() massively
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Fri, 16 Mar 2012 10:33:14 +0000 (10:33 +0000)]
Summary: minor, kick sheap and friends
Keywords: bldchn dumper
This changeset eradicates sheap.c and its usage in the dumping process,
since pdump is always and everywhere on.
* configure.ac: don't bother checking for SHEAP usage
* src/Makefile.am: kick sheap mumbojumbo
* src/emacs.c: kick references to sheap
* src/sheap.c: gone
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Ruediger Meier [Thu, 15 Mar 2012 21:06:50 +0000 (22:06 +0100)]
fix dist, configfsf.guess and configfsf.sub are also needed
Steve Youngs [Thu, 15 Mar 2012 22:11:56 +0000 (08:11 +1000)]
Loads of build chain fixups from Sebastian
* merges:
cosmetics, list Installation and cpuid in distclean-local hook
fix, comb out double-/ hiccups in invocation-{name,directory}
chore, bldchn, remove dump file upon make uninstall
chore, major, do not include dump id in dump file name
Summary: minor, bring back dist targets Keywords: bldchn dist doc
doc, fix, do not use structure (@unnumberedsec) inside @enumerate
chore, mention src/sxemacs in gitignore fully qualified
doc, fix, do not use @heading in @enumerate
chore, list ALL texi files in info/ and subdirs
fix, do not use @anchor in structuring commands
chore, remove TEXI2DVI redefinitions
chore, mention build chain .el files in lisp's Makefile.am
chore, mention headers needed for the ase-set emod
chore, move systty.h to src/ui/TTY/
chore, put sxe-utils.h into distribution
chore, remove VPATH fiddling from sxe-srctree.m4
chore, don't mention non-existing files in Makefile.am's
chore, name ase-resclass-test.el correctly
chore, don't mention non-existing files in Makefile.am's
Steve Youngs [Thu, 15 Mar 2012 21:43:10 +0000 (07:43 +1000)]
cosmetic fixes from Rudi
* merges:
cosmetics, correct fsf address in COPYING.LIB
fix warnings, control reaches end of non-void function
Sebastian Freundt [Thu, 15 Mar 2012 18:20:27 +0000 (18:20 +0000)]
Merge branch 'bldchn' into next
* bldchn:
cosmetics, list Installation and cpuid in distclean-local hook
fix, comb out double-/ hiccups in invocation-{name,directory}
chore, bldchn, remove dump file upon make uninstall
chore, major, do not include dump id in dump file name
Sebastian Freundt [Thu, 15 Mar 2012 18:00:14 +0000 (18:00 +0000)]
cosmetics, list Installation and cpuid in distclean-local hook
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Thu, 15 Mar 2012 17:03:56 +0000 (17:03 +0000)]
fix, comb out double-/ hiccups in invocation-{name,directory}
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Thu, 15 Mar 2012 17:01:23 +0000 (17:01 +0000)]
chore, bldchn, remove dump file upon make uninstall
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Thu, 15 Mar 2012 17:00:39 +0000 (17:00 +0000)]
chore, major, do not include dump id in dump file name
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Thu, 15 Mar 2012 18:19:12 +0000 (18:19 +0000)]
Merge branch 'bldchn' into next
* bldchn:
Summary: minor, bring back dist targets Keywords: bldchn dist doc
doc, fix, do not use structure (@unnumberedsec) inside @enumerate
chore, mention src/sxemacs in gitignore fully qualified
doc, fix, do not use @heading in @enumerate
chore, list ALL texi files in info/ and subdirs
fix, do not use @anchor in structuring commands
chore, remove TEXI2DVI redefinitions
chore, mention build chain .el files in lisp's Makefile.am
chore, mention headers needed for the ase-set emod
chore, move systty.h to src/ui/TTY/
chore, put sxe-utils.h into distribution
chore, remove VPATH fiddling from sxe-srctree.m4
chore, don't mention non-existing files in Makefile.am's
chore, name ase-resclass-test.el correctly
chore, don't mention non-existing files in Makefile.am's
Sebastian Freundt [Thu, 15 Mar 2012 12:09:29 +0000 (12:09 +0000)]
Summary: minor, bring back dist targets
Keywords: bldchn dist doc
This changeset brings back the dist targets, in particular `distcheck'.
On the way there loads of cleaning up is done.
* .gitignore: explicitly mention src/sxemacs* (naming conflict)
* Makefile.am: major, allow dist again
* info/Makefile.am: kick TEXI2DVI redefinitions
list all .texi files (recursively)
* info/lispref/intro.texi: fix up @heading in @enumerate
* info/sppm.texi: fix up @anchor in structuring commands
* info/sxemacs/new.texi: fix up @unnumberedsec in @enumerate
* lib-src/Makefile.am: kick ad2c script from the dist
* lisp/Makefile.am: mention build chain .el's
* m4/sxe-srctree.m4: remove VPATH fiddling ... this needs investigating
who put it there and why?
* modules/ase/Makefile.am: ship with header files
* src/Makefile.am: ship with sxe-utils.h
* src/callproc.c: move systty.h to src/ui/TTY/
* src/emacs.c: move systty.h to src/ui/TTY/
* src/process-unix.c: move systty.h to src/ui/TTY/
* src/process.c: move systty.h to src/ui/TTY/
* src/sysdep.c: move systty.h to src/ui/TTY/
* src/ui/TTY/Makefile.am: move systty.h to src/ui/TTY/
* src/ui/TTY/console-tty.h: move systty.h to src/ui/TTY/
* src/ui/TTY/systty.h: move systty.h to src/ui/TTY/
* src/ui/systty.h: move from to src/ui
* tests/Makefile.am: typo
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Thu, 15 Mar 2012 07:45:47 +0000 (07:45 +0000)]
doc, fix, do not use structure (@unnumberedsec) inside @enumerate
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Thu, 15 Mar 2012 07:45:16 +0000 (07:45 +0000)]
chore, mention src/sxemacs in gitignore fully qualified
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Thu, 15 Mar 2012 07:39:25 +0000 (07:39 +0000)]
doc, fix, do not use @heading in @enumerate
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Wed, 14 Mar 2012 15:22:35 +0000 (15:22 +0000)]
chore, list ALL texi files in info/ and subdirs
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Wed, 14 Mar 2012 14:42:06 +0000 (14:42 +0000)]
fix, do not use @anchor in structuring commands
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Wed, 14 Mar 2012 12:49:34 +0000 (12:49 +0000)]
chore, remove TEXI2DVI redefinitions
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Wed, 14 Mar 2012 12:47:09 +0000 (12:47 +0000)]
chore, mention build chain .el files in lisp's Makefile.am
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Wed, 14 Mar 2012 09:34:00 +0000 (09:34 +0000)]
chore, mention headers needed for the ase-set emod
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Wed, 14 Mar 2012 08:41:39 +0000 (08:41 +0000)]
chore, move systty.h to src/ui/TTY/
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Wed, 14 Mar 2012 08:31:03 +0000 (08:31 +0000)]
chore, put sxe-utils.h into distribution
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Tue, 13 Mar 2012 17:21:02 +0000 (17:21 +0000)]
chore, remove VPATH fiddling from sxe-srctree.m4
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Tue, 13 Mar 2012 13:18:41 +0000 (13:18 +0000)]
chore, don't mention non-existing files in Makefile.am's
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Tue, 13 Mar 2012 13:09:18 +0000 (13:09 +0000)]
chore, name ase-resclass-test.el correctly
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Tue, 13 Mar 2012 13:08:47 +0000 (13:08 +0000)]
chore, don't mention non-existing files in Makefile.am's
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Ruediger Meier [Thu, 15 Mar 2012 11:36:51 +0000 (12:36 +0100)]
cosmetics, correct fsf address in COPYING.LIB
Ruediger Meier [Thu, 15 Mar 2012 11:07:57 +0000 (12:07 +0100)]
fix warnings, control reaches end of non-void function
See also Nelson's "Coverity: Missing break" patches
09e0c4e2,
100ad363,
0c0a6fa6 and
eef3d3ba.
Steve Youngs [Thu, 15 Mar 2012 00:57:36 +0000 (10:57 +1000)]
Fix return on non-void function from Rudi
* merges:
fix, return with no value, in function returning non-void
Ruediger Meier [Wed, 14 Mar 2012 16:55:55 +0000 (17:55 +0100)]
fix, return with no value, in function returning non-void
followup
4da01e95
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Steve Youngs [Wed, 14 Mar 2012 02:10:25 +0000 (12:10 +1000)]
Coverity fixes from Nelson
* merges:
Refactor
Fix build
Refactor
Refactoring
reflow
Coverity CID 400832 Out of bounds access
Small optimization
Nelson Ferreira [Wed, 14 Mar 2012 00:11:04 +0000 (20:11 -0400)]
Merge branch 'njsf-cov' into for-steve
Nelson Ferreira [Wed, 14 Mar 2012 00:10:38 +0000 (20:10 -0400)]
Refactor
* src/mule/file-coding.c (autodetect_real_coding_system): New
function to reduce indentention of scope. Also as soon as stream
read fails, it returns, thus solving one of the coverity issues.
Several scope reduction refactorings.
* src/mule/file-coding.c (determine_real_coding_system): Call the
new function.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Mon, 12 Mar 2012 02:08:20 +0000 (22:08 -0400)]
Fix build
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Mon, 12 Mar 2012 01:11:12 +0000 (21:11 -0400)]
Refactor
* src/mule/file-coding.c (determine_real_coding_system): Refactor
condition in inner for loop so that negative branch of the
condition will continue loop, and fall through is the old positive
condition branch.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Mon, 12 Mar 2012 01:01:50 +0000 (21:01 -0400)]
Refactoring
* src/mule/file-coding.c (determine_real_coding_system): Static
local variable for the mime name chars and some added explicit
scope braces.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Mon, 12 Mar 2012 00:57:30 +0000 (20:57 -0400)]
reflow
* src/mule/file-coding.c (determine_real_coding_system): Reflow to make it easier to read and refactor.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 11 Mar 2012 23:45:52 +0000 (19:45 -0400)]
Coverity CID 400832 Out of bounds access
* src/editfns.c (Ftemp_directory): Use proper size argument with xstrncat
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Sun, 11 Mar 2012 23:42:58 +0000 (19:42 -0400)]
Small optimization
* src/emodules-ng.c (__emodng_open_append_exts): New remain variable to keep
invariant computation...
* src/emodules-ng.c (__emodng_open_prepend_paths_append_exts): Ditto.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Fri, 9 Mar 2012 23:43:14 +0000 (09:43 +1000)]
Close Bug #135, fix test suite. From Sebastian
* merges:
Summary: fix, initialise cat morphism array properly, harden the tests Keywords: fix bug 135
fix, change order of bitset in lrecord struct, hash_cache last
cosmetics, turn morphism extern_inlines into static inlines
test, run test suite with MALLOC_PERTURB_ set to be extra-harsh to the code
test, introduce regression test for one MALLOC_PERTURB_ triggered crash
Summary: fix, make sure ase-heap emits all symbols it needs Keywords: bld/chn
Steve Youngs [Fri, 9 Mar 2012 23:26:07 +0000 (09:26 +1000)]
Don't put the dumpfile in bin dir from Rudi
* merges:
bldchn fix, don't install buildir's dumpfile
bldchn, install dumpfile into archlibdir
try to read dumpfile also from libarchdir
why the hell we don't have always EXEC_PATH available
bldchn cleanup, remove/re-use some unused dumpfile related AM variables
Sebastian Freundt [Fri, 9 Mar 2012 17:16:28 +0000 (17:16 +0000)]
Merge branch 'bug/135' into next
* bug/135:
Summary: fix, initialise cat morphism array properly, harden the tests Keywords: fix bug 135
fix, change order of bitset in lrecord struct, hash_cache last
cosmetics, turn morphism extern_inlines into static inlines
test, run test suite with MALLOC_PERTURB_ set to be extra-harsh to the code
test, introduce regression test for one MALLOC_PERTURB_ triggered crash
Sebastian Freundt [Fri, 9 Mar 2012 17:15:02 +0000 (17:15 +0000)]
Summary: fix, initialise cat morphism array properly, harden the tests
Keywords: fix bug 135
This changeset fixes an issue of using uninitialised memory (bug 135).
* src/lrecord.h (set_lheader_implementation): properly initialise lheaders
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Fri, 9 Mar 2012 17:14:45 +0000 (17:14 +0000)]
fix, change order of bitset in lrecord struct, hash_cache last
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Fri, 9 Mar 2012 17:13:46 +0000 (17:13 +0000)]
cosmetics, turn morphism extern_inlines into static inlines
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Fri, 9 Mar 2012 15:00:43 +0000 (15:00 +0000)]
test, run test suite with MALLOC_PERTURB_ set to be extra-harsh to the code
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Fri, 9 Mar 2012 14:57:53 +0000 (14:57 +0000)]
test, introduce regression test for one MALLOC_PERTURB_ triggered crash
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Sebastian Freundt [Fri, 9 Mar 2012 12:31:01 +0000 (12:31 +0000)]
Merge branch 'bld/x32' into next
* bld/x32:
Summary: fix, make sure ase-heap emits all symbols it needs Keywords: bld/chn
Sebastian Freundt [Fri, 9 Mar 2012 12:30:04 +0000 (12:30 +0000)]
Summary: fix, make sure ase-heap emits all symbols it needs
Keywords: bld/chn
This changeset fixes an issue with the ase-heap emodule. Ctors and
wrappers are now declared and defined in the file that they're used.
* modules/ase/ase-heap.h: kick static inlines, no need to expose them
* modules/ase/ase-heap.c: soak up static inlines decls from the header
Signed-off-by: Sebastian Freundt <freundt@ga-group.nl>
Ruediger Meier [Thu, 8 Mar 2012 14:32:00 +0000 (15:32 +0100)]
bldchn fix, don't install buildir's dumpfile
This problem became visible since we create the symlink within
archlibdir instead of bindir.
Also we delete $(bindir)/sxemacs.dmp from older installations
because unfortunately sxemacs would still try this first.
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Ruediger Meier [Thu, 8 Mar 2012 14:16:55 +0000 (15:16 +0100)]
bldchn, install dumpfile into archlibdir
Also we only install the one which is named with dump_id.
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Ruediger Meier [Thu, 8 Mar 2012 14:01:43 +0000 (15:01 +0100)]
try to read dumpfile also from libarchdir
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Ruediger Meier [Thu, 8 Mar 2012 13:45:51 +0000 (14:45 +0100)]
why the hell we don't have always EXEC_PATH available
Does this break anything?
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Ruediger Meier [Wed, 7 Mar 2012 16:52:43 +0000 (17:52 +0100)]
bldchn cleanup, remove/re-use some unused dumpfile related AM variables
This does not change anything.
Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
Steve Youngs [Wed, 7 Mar 2012 22:24:54 +0000 (08:24 +1000)]
Coverity and build fixes from Nelson
* merges:
Coverity: CID 400010: Improper use of negative value
Coverity: CID 400001: Logically dead code
Coverity: CID 400005: Division or modulo by zero
Coverity: CID 400007: Deference after null check
Coverity: CID 400831: Out of bonds access
Coverity: CID 400832: Out of bounds access
Fix build
Fix the relocate_fd
Coverity CID 400833 UNINIT
Nelson Ferreira [Wed, 7 Mar 2012 15:21:00 +0000 (10:21 -0500)]
Coverity: CID 400010: Improper use of negative value
* src/ui/minibuf.c (echo_area_append): Make sure length<0 also
returns early here.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Wed, 7 Mar 2012 14:58:51 +0000 (09:58 -0500)]
Merge branch 'for-steve' into njsf-cov
Nelson Ferreira [Wed, 7 Mar 2012 14:41:24 +0000 (09:41 -0500)]
Coverity: CID 400001: Logically dead code
* lib-src/etags.c (get_language_from_filename): Rework code a
little so that Coverity does not get fooled by ternary operator.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Wed, 7 Mar 2012 14:37:39 +0000 (09:37 -0500)]
Coverity: CID 400005: Division or modulo by zero
* src/media/sound-oss.c (sound_oss_play): Fix gross condition
error of previous change
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Wed, 7 Mar 2012 14:36:29 +0000 (09:36 -0500)]
Coverity: CID 400007: Deference after null check
* src/eval.c (Finteractive_p): Make sure btp is not NULL before
dereference.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Wed, 7 Mar 2012 14:32:01 +0000 (09:32 -0500)]
Coverity: CID 400831: Out of bonds access
* src/fileio.c: Provide proper length to xstrncat
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Wed, 7 Mar 2012 14:30:31 +0000 (09:30 -0500)]
Coverity: CID 400832: Out of bounds access
* src/editfns.c (Ftemp_directory): Proper size passed to xstrncat
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Wed, 7 Mar 2012 14:13:54 +0000 (09:13 -0500)]
Fix build
* src/callproc.c (relocate_fd): fix the argument rename usage
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Wed, 7 Mar 2012 13:29:21 +0000 (08:29 -0500)]
Merge branch 'master' into for-steve
Nelson Ferreira [Wed, 7 Mar 2012 13:25:49 +0000 (08:25 -0500)]
Fix the relocate_fd
* src/callproc.c (max_filedesc): New function to determine the
actual maximum file descriptor.
* src/callproc.c (relocate_fd): Realized previous use of just dup
was actually better, made sure that the closing of temporary duped
file descriptors was commented.
* src/emacs.c (__sys_stk_sz): Minor cosmetic variable rename.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Wed, 7 Mar 2012 12:49:20 +0000 (07:49 -0500)]
Coverity CID 400833 UNINIT
* src/sysdep.c (raw_open): Use the proper argument for open
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Wed, 7 Mar 2012 03:03:07 +0000 (13:03 +1000)]
test suite fixes from Nelson
* merges:
Why are quick fixes so bad ? Because they break more than they fix
Nelson Ferreira [Wed, 7 Mar 2012 02:47:39 +0000 (21:47 -0500)]
Why are quick fixes so bad ? Because they break more than they fix
* src/emodules-ng.c (__emodng_open_prepend_paths): Fix xstpncpy
arguments. For real this time.
* src/emodules-ng.c (__emodng_open_prepend_paths_append_exts): Ditto.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Wed, 7 Mar 2012 02:45:29 +0000 (12:45 +1000)]
test suite fixes from Nelson
* merges:
Improve relocate_fd with dup2
Fix build
Nelson Ferreira [Wed, 7 Mar 2012 01:58:18 +0000 (20:58 -0500)]
Merge branch 'njsf-cov' into for-steve
Nelson Ferreira [Wed, 7 Mar 2012 01:53:56 +0000 (20:53 -0500)]
Improve relocate_fd with dup2
* src/callproc.c (relocate_fd): Satisfy checkers for return values
until proper check of getrlimit is implemented
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Wed, 7 Mar 2012 01:50:52 +0000 (20:50 -0500)]
Fix build
* src/emodules-ng.c (__emodng_open_prepend_paths): Correct usage of xstpcpy size argument.
* src/emodules-ng.c (_adapt_load_path): Ditto.
* src/emodules-ng.c (__emodng_open_prepend_paths_append_exts): Fix indentation
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Tue, 6 Mar 2012 22:20:11 +0000 (08:20 +1000)]
Fix autoload breakage from prev changeset from Nelson
* merges:
Fix introduced bug by coverity fix attempt
Nelson Ferreira [Tue, 6 Mar 2012 13:25:08 +0000 (08:25 -0500)]
Fix introduced bug by coverity fix attempt
* src/search.c (boyer_moore): User REGEXP_FASTMAP_MASK for the
bit-and instead of the REGEXP_FASTMAP_SIZE (which is clearly
wrong).
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Steve Youngs [Tue, 6 Mar 2012 07:39:44 +0000 (17:39 +1000)]
build fix from Nelson
* merges:
Make sure list-load-path-shadows can work after dmp
Steve Youngs [Tue, 6 Mar 2012 07:32:06 +0000 (17:32 +1000)]
Coverity and build chain fixes from Nelson
* merges:
Coverity: Resource leak: CID 400015
Fix configure.ac
Fix configure
xstrncpy saga
xstrncpy saga
xstrncpy saga
Fix tty build broken in last configure.ac changes
Do not add tty objects when no tty is available
Coverity: CID 400005: Division or modulo by zero
Coverity: CID 400006: Division or modulo by zero
Coverity: Out of bounds write: CID 21140
Coverity: CID 400012 Overrun dynamic
Fix build for branches without tags
Coverity CID 400013 Printf arg type mismatch
Coverity: CID 400031: Tainted string
Coverity: CID 400829: Uninit
Use dup2 if available for -t. Also check for ttyname and isatty in configure.
Coverity: CID 400828 Resource leak
Use AS_IF instead of if some places - be more M4sh friendly
Update copyright, remove unused ent arguments
Nelson Ferreira [Tue, 6 Mar 2012 07:18:10 +0000 (02:18 -0500)]
Make sure list-load-path-shadows can work after dmp
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Tue, 6 Mar 2012 07:13:23 +0000 (02:13 -0500)]
Merge branch 'master' of ssh://dio.dreamhost.com/~/repos.nelsonferreira.com/git/sxemacs into for-steve
Nelson Ferreira [Tue, 6 Mar 2012 07:10:19 +0000 (02:10 -0500)]
Coverity: Resource leak: CID 400015
* src/callproc.c (relocate_fd): Make sure that dup'ed file
descriptors < min are closed. In addition, make a better version
when dup2 is available.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Tue, 6 Mar 2012 06:29:23 +0000 (01:29 -0500)]
Merge remote-tracking branch 'njsf/for-steve' into for-steve
Nelson Ferreira [Tue, 6 Mar 2012 06:27:19 +0000 (01:27 -0500)]
Fix configure.ac
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Tue, 6 Mar 2012 06:02:32 +0000 (01:02 -0500)]
Fix configure
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Tue, 6 Mar 2012 05:58:48 +0000 (00:58 -0500)]
xstrncpy saga
* src/emodules-ng.c (__emodng_open_append_exts): Use xstrncpy instead of strncpy
* src/emodules-ng.c (__emodng_open_prepend_paths): Ditto.
* src/emodules-ng.c (__emodng_open_prepend_paths_append_exts): Ditto.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Tue, 6 Mar 2012 05:52:11 +0000 (00:52 -0500)]
xstrncpy saga
* src/editfns.c (Ftemp_directory): Use xstrncpy instead of strncpy
and xstrncat instead of strcat
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Tue, 6 Mar 2012 05:50:05 +0000 (00:50 -0500)]
xstrncpy saga
* src/database/postgresql.c (Fpq_connectdb): Use xstrncpy instead of strncpy
* src/database/postgresql.c (Fpq_connect_start): Ditto.
* src/database/postgresql.c (Fpq_exec): Ditto.
* src/database/postgresql.c (Fpq_get_result): Ditto.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Tue, 6 Mar 2012 05:33:16 +0000 (00:33 -0500)]
Fix tty build broken in last configure.ac changes
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Tue, 6 Mar 2012 03:08:38 +0000 (22:08 -0500)]
Merge branch 'for-steve' into njsf-tty
Nelson Ferreira [Tue, 6 Mar 2012 02:50:30 +0000 (21:50 -0500)]
Do not add tty objects when no tty is available
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Tue, 6 Mar 2012 01:57:31 +0000 (20:57 -0500)]
Coverity: CID 400005: Division or modulo by zero
* src/media/sound-oss.c (sound_oss_play): Abort early when channels is 0.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>
Nelson Ferreira [Tue, 6 Mar 2012 00:53:42 +0000 (19:53 -0500)]
Coverity: CID 400006: Division or modulo by zero
* src/ui/window.c (Fwindow_displayed_text_pixel_height): Make sure
no division by 0 is attempted and use "best heuristic" of just
adding 3.
Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>