Coverity: Assert side effect: CID 2

	* src/extents.c (gap_array_delete_marker): Remove unnecessary
	volatile (we don't multithread so we should have this be
	interrupted. If at some point we make multi-threaded SXEmacs, this
	should be protected by some barrier.

	* src/extents.c (gap_array_delete_all_markers): Ditto.

Signed-off-by: Nelson Ferreira <nelson.ferreira@ieee.org>

diff --git a/src/extents.c b/src/extents.c
index c59e066..7cdfed7 100644 (file)
--- a/src/extents.c
+++ b/src/extents.c
@@ -662,13 +662,12 @@ gap_array_make_marker(gap_array_t ga, int pos)
 static void
 gap_array_delete_marker(gap_array_t ga, gap_array_marker_t m)
 {
-       volatile gap_array_marker_t p, prev;
+       gap_array_marker_t p, prev;
 
        for (prev = 0, p = ga->markers; p && p != m; prev = p, p = p->next);
        if (UNLIKELY(p == NULL)) {
                return;
        }
-       assert(p);
        if (prev) {
                prev->next = p->next;
        } else {
@@ -687,7 +686,7 @@ gap_array_delete_marker(gap_array_t ga, gap_array_marker_t m)
 static void
 gap_array_delete_all_markers(gap_array_t ga)
 {
-       for (volatile gap_array_marker_t p = ga->markers, next; p; p = next) {
+       for (gap_array_marker_t p = ga->markers, next; p; p = next) {
                next = p->next;
 #if defined HAVE_BDWGC && defined EF_USE_BDWGC
                xfree(p);