X-Git-Url: http://cgit.sxemacs.org/?a=blobdiff_plain;f=lisp%2Fgnus-logic.el;h=13c9a20da8fcdc31707a1435afc27c74e8283e74;hb=8652cb37e35862cb66e043e87348d76ccfc6b44a;hp=d6e86eddc1b381bce96584590e884e416811d2c6;hpb=4c0bad76d2316c59b181d93baf04bb796ed439b0;p=gnus

diff --git a/lisp/gnus-logic.el b/lisp/gnus-logic.el
index d6e86eddc..13c9a20da 100644
--- a/lisp/gnus-logic.el
+++ b/lisp/gnus-logic.el
@@ -1,7 +1,8 @@
 ;;; gnus-logic.el --- advanced scoring code for Gnus
-;; Copyright (C) 1996 Free Software Foundation, Inc.
+;; Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001
+;;        Free Software Foundation, Inc.
 
-;; Author: Lars Magne Ingebrigtsen <larsi@ifi.uio.no>
+;; Author: Lars Magne Ingebrigtsen <larsi@gnus.org>
 ;; Keywords: news
 
 ;; This file is part of GNU Emacs.
@@ -25,15 +26,17 @@
 
 ;;; Code:
 
-(require 'gnus-load)
+(eval-when-compile (require 'cl))
+
+(require 'gnus)
 (require 'gnus-score)
 (require 'gnus-util)
 
-;;; Internal variables. 
+;;; Internal variables.
 
 (defvar gnus-advanced-headers nil)
 
-;; To avoid having 8-bit charaters in the source file.
+;; To avoid having 8-bit characters in the source file.
 (defvar gnus-advanced-not (intern (format "%c" 172)))
 
 (defconst gnus-advanced-index
@@ -42,10 +45,10 @@
     ("subject" 1 gnus-advanced-string)
     ("from" 2 gnus-advanced-string)
     ("date" 3 gnus-advanced-date)
-    ("message-id" 4 gnus-advanced-string) 
-    ("references" 5 gnus-advanced-string) 
-    ("chars" 6 gnus-advanced-integer) 
-    ("lines" 7 gnus-advanced-integer) 
+    ("message-id" 4 gnus-advanced-string)
+    ("references" 5 gnus-advanced-string)
+    ("chars" 6 gnus-advanced-integer)
+    ("lines" 7 gnus-advanced-integer)
     ("xref" 8 gnus-advanced-string)
     ("head" nil gnus-advanced-body)
     ("body" nil gnus-advanced-body)
@@ -53,7 +56,7 @@
 
 (eval-and-compile
   (autoload 'parse-time-string "parse-time"))
-     
+
 (defun gnus-score-advanced (rule &optional trace)
   "Apply advanced scoring RULE to all the articles in the current group."
   (let ((headers gnus-newsgroup-headers)
@@ -65,7 +68,7 @@
 	(if (setq score (assq (mail-header-number gnus-advanced-headers)
 			      gnus-newsgroup-scored))
 	    (setcdr score
-		    (+ (cdr score) 
+		    (+ (cdr score)
 		       (or (nth 1 rule)
 			   gnus-score-interactive-default-score)))
 	  (push (cons (mail-header-number gnus-advanced-headers)
@@ -79,7 +82,7 @@
 (defun gnus-advanced-score-rule (rule)
   "Apply RULE to `gnus-advanced-headers'."
   (let ((type (car rule)))
-    (cond 
+    (cond
      ;; "And" rule.
      ((or (eq type '&) (eq type 'and))
       (pop rule)
@@ -106,7 +109,7 @@
      ;; This is a `1-'-type redirection rule.
      ((and (symbolp type)
 	   (string-match "^[0-9]+-$\\|^\\^+$" (symbol-name type)))
-      (let ((gnus-advanced-headers 
+      (let ((gnus-advanced-headers
 	     (gnus-parent-headers
 	      gnus-advanced-headers
 	      (if (string-match "^\\([0-9]+\\)-$" (symbol-name type))
@@ -142,7 +145,7 @@
   (let* ((type (or type 's))
 	 (case-fold-search (not (eq (downcase (symbol-name type))
 				    (symbol-name type))))
-	 (header (aref gnus-advanced-headers index)))
+	 (header (or (aref gnus-advanced-headers index) "")))
     (cond
      ((memq type '(r R regexp Regexp))
       (string-match match header))
@@ -162,16 +165,16 @@
     (funcall type match (or (aref gnus-advanced-headers index) 0))))
 
 (defun gnus-advanced-date (index match type)
-  (let ((date (encode-time (parse-time-string
-			    (aref gnus-advanced-headers index))))
-	(match (encode-time (parse-time-string match))))
-    (cond 
+  (let ((date (apply 'encode-time (parse-time-string
+				   (aref gnus-advanced-headers index))))
+	(match (apply 'encode-time (parse-time-string match))))
+    (cond
      ((eq type 'at)
       (equal date match))
      ((eq type 'before)
-      (gnus-time-less match date))
+      (time-less-p match date))
      ((eq type 'after)
-      (gnus-time-less date match))
+      (time-less-p date match))
      (t
       (error "No such date score type: %s" type)))))
 
@@ -188,7 +191,7 @@
 	   ofunc article)
       ;; Not all backends support partial fetching.  In that case,
       ;; we just fetch the entire article.
-      (unless (gnus-check-backend-function 
+      (unless (gnus-check-backend-function
 	       (intern (concat "request-" header))
 	       gnus-newsgroup-name)
 	(setq ofunc request-func)
@@ -200,23 +203,23 @@
 	;; If just parts of the article is to be searched and the
 	;; backend didn't support partial fetching, we just narrow
 	;; to the relevant parts.
-	(if ofunc
-	    (if (eq ofunc 'gnus-request-head)
-		(narrow-to-region
-		 (point)
-		 (or (search-forward "\n\n" nil t) (point-max)))
+	(when ofunc
+	  (if (eq ofunc 'gnus-request-head)
 	      (narrow-to-region
-	       (or (search-forward "\n\n" nil t) (point))
-	       (point-max))))
+	       (point)
+	       (or (search-forward "\n\n" nil t) (point-max)))
+	    (narrow-to-region
+	     (or (search-forward "\n\n" nil t) (point))
+	     (point-max))))
 	(let* ((case-fold-search (not (eq (downcase (symbol-name type))
 					  (symbol-name type))))
-	       (search-func 
+	       (search-func
 		(cond ((memq type '(r R regexp Regexp))
 		       're-search-forward)
 		      ((memq type '(s S string String))
 		       'search-forward)
 		      (t
-		       (error "Illegal match type: %s" type)))))
+		       (error "Invalid match type: %s" type)))))
 	  (goto-char (point-min))
 	  (prog1
 	      (funcall search-func match nil t)
@@ -224,4 +227,4 @@
 
 (provide 'gnus-logic)
 
-;;; gnus-logic.el ends here.
+;;; gnus-logic.el ends here