1 ;;; gnus-spec.el --- format spec functions for Gnus
3 ;; Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004,
4 ;; 2005, 2006, 2007 Free Software Foundation, Inc.
6 ;; Author: Lars Magne Ingebrigtsen <larsi@gnus.org>
9 ;; This file is part of GNU Emacs.
11 ;; GNU Emacs is free software; you can redistribute it and/or modify
12 ;; it under the terms of the GNU General Public License as published by
13 ;; the Free Software Foundation; either version 2, or (at your option)
16 ;; GNU Emacs is distributed in the hope that it will be useful,
17 ;; but WITHOUT ANY WARRANTY; without even the implied warranty of
18 ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19 ;; GNU General Public License for more details.
21 ;; You should have received a copy of the GNU General Public License
22 ;; along with GNU Emacs; see the file COPYING. If not, write to the
23 ;; Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
24 ;; Boston, MA 02110-1301, USA.
30 (eval-when-compile (require 'cl))
31 (defvar gnus-newsrc-file-version)
35 (defcustom gnus-use-correct-string-widths (featurep 'xemacs)
36 "*If non-nil, use correct functions for dealing with wide characters."
41 (defcustom gnus-make-format-preserve-properties (featurep 'xemacs)
42 "*If non-nil, use a replacement `format' function which preserves
43 text properties. This is only needed on XEmacs, as FSF Emacs does this anyway."
48 ;;; Internal variables.
50 (defvar gnus-summary-mark-positions nil)
51 (defvar gnus-group-mark-positions nil)
52 (defvar gnus-group-indentation "")
54 ;; Format specs. The chunks below are the machine-generated forms
55 ;; that are to be evaled as the result of the default format strings.
56 ;; We write them in here to get them byte-compiled. That way the
57 ;; default actions will be quite fast, while still retaining the full
58 ;; flexibility of the user-defined format specs.
60 ;; First we have lots of dummy defvars to let the compiler know these
61 ;; are really dynamic variables.
63 (defvar gnus-tmp-unread)
64 (defvar gnus-tmp-replied)
65 (defvar gnus-tmp-score-char)
66 (defvar gnus-tmp-indentation)
67 (defvar gnus-tmp-opening-bracket)
68 (defvar gnus-tmp-lines)
69 (defvar gnus-tmp-name)
70 (defvar gnus-tmp-closing-bracket)
71 (defvar gnus-tmp-subject-or-nil)
72 (defvar gnus-tmp-subject)
73 (defvar gnus-tmp-marked)
74 (defvar gnus-tmp-marked-mark)
75 (defvar gnus-tmp-subscribed)
76 (defvar gnus-tmp-process-marked)
77 (defvar gnus-tmp-number-of-unread)
78 (defvar gnus-tmp-group-name)
79 (defvar gnus-tmp-group)
80 (defvar gnus-tmp-article-number)
81 (defvar gnus-tmp-unread-and-unselected)
82 (defvar gnus-tmp-news-method)
83 (defvar gnus-tmp-news-server)
84 (defvar gnus-tmp-article-number)
85 (defvar gnus-mouse-face)
86 (defvar gnus-mouse-face-prop)
87 (defvar gnus-tmp-header)
88 (defvar gnus-tmp-from)
90 (defun gnus-summary-line-format-spec ()
91 (insert gnus-tmp-unread gnus-tmp-replied
92 gnus-tmp-score-char gnus-tmp-indentation)
93 (gnus-put-text-property
97 (format "%c%4s: %-23s%c" gnus-tmp-opening-bracket gnus-tmp-lines
100 (gnus-summary-from-or-to-or-newsgroups
101 gnus-tmp-header gnus-tmp-from))))
102 (if (> (length val) 23)
105 gnus-tmp-closing-bracket))
107 gnus-mouse-face-prop gnus-mouse-face)
108 (insert " " gnus-tmp-subject-or-nil "\n"))
110 (defvar gnus-summary-line-format-spec
111 (gnus-byte-code 'gnus-summary-line-format-spec))
113 (defun gnus-summary-dummy-line-format-spec ()
115 (gnus-put-text-property
120 gnus-mouse-face-prop gnus-mouse-face)
121 (insert " " gnus-tmp-subject "\n"))
123 (defvar gnus-summary-dummy-line-format-spec
124 (gnus-byte-code 'gnus-summary-dummy-line-format-spec))
126 (defun gnus-group-line-format-spec ()
127 (insert gnus-tmp-marked-mark gnus-tmp-subscribed
128 gnus-tmp-process-marked
129 gnus-group-indentation
130 (format "%5s: " gnus-tmp-number-of-unread))
131 (gnus-put-text-property
134 (insert gnus-tmp-group "\n")
136 gnus-mouse-face-prop gnus-mouse-face))
137 (defvar gnus-group-line-format-spec
138 (gnus-byte-code 'gnus-group-line-format-spec))
140 (defvar gnus-format-specs
141 `((version . ,emacs-version)
142 (gnus-version . ,(gnus-continuum-version))
143 (group "%M\%S\%p\%P\%5y: %(%g%)\n" ,gnus-group-line-format-spec)
144 (summary-dummy "* %(: :%) %S\n"
145 ,gnus-summary-dummy-line-format-spec)
146 (summary "%U%R%z%I%(%[%4L: %-23,23f%]%) %s\n"
147 ,gnus-summary-line-format-spec))
148 "Alist of format specs.")
150 (defvar gnus-default-format-specs gnus-format-specs)
152 (defvar gnus-article-mode-line-format-spec nil)
153 (defvar gnus-summary-mode-line-format-spec nil)
154 (defvar gnus-group-mode-line-format-spec nil)
156 ;;; Phew. All that gruft is over with, fortunately.
159 (defun gnus-update-format (var)
160 "Update the format specification near point."
165 ;; Find the end of the current word.
166 (re-search-forward "[ \t\n]" nil t)
168 (when (re-search-backward "\\(gnus-[-a-z]+-line-format\\)" nil t)
170 (let* ((type (intern (progn (string-match "gnus-\\([-a-z]+\\)-line" var)
171 (match-string 1 var))))
172 (entry (assq type gnus-format-specs))
175 (setq gnus-format-specs (delq entry gnus-format-specs)))
177 (intern (format "%s-spec" var))
178 (gnus-parse-format (setq value (symbol-value (intern var)))
179 (symbol-value (intern (format "%s-alist" var)))
180 (not (string-match "mode" var))))
181 (setq spec (symbol-value (intern (format "%s-spec" var))))
182 (push (list type value spec) gnus-format-specs)
184 (pop-to-buffer "*Gnus Format*")
186 (lisp-interaction-mode)
187 (insert (gnus-pp-to-string spec))))
189 (defun gnus-update-format-specifications (&optional force &rest types)
190 "Update all (necessary) format specifications.
191 Return a list of updated types."
192 ;; Make the indentation array.
193 ;; See whether all the stored info needs to be flushed.
195 (not gnus-newsrc-file-version)
196 (not (equal (gnus-continuum-version)
197 (gnus-continuum-version gnus-newsrc-file-version)))
198 (not (equal emacs-version
199 (cdr (assq 'version gnus-format-specs)))))
200 (setq gnus-format-specs nil))
201 ;; Flush the group format spec cache if there's the grouplens stuff
202 ;; or it doesn't support decoded group names.
203 (when (memq 'group types)
204 (let* ((spec (assq 'group gnus-format-specs))
205 (sspec (gnus-prin1-to-string (nth 2 spec))))
206 (when (or (string-match " gnus-tmp-grouplens[ )]" sspec)
207 (not (string-match " gnus-tmp-decoded-group[ )]" sspec)))
208 (setq gnus-format-specs (delq spec gnus-format-specs)))))
210 ;; Go through all the formats and see whether they need updating.
211 (let (new-format entry type val updated)
212 (while (setq type (pop types))
213 ;; Jump to the proper buffer to find out the value of the
214 ;; variable, if possible. (It may be buffer-local.)
216 (let ((buffer (intern (format "gnus-%s-buffer" type))))
217 (when (and (boundp buffer)
218 (setq val (symbol-value buffer))
219 (gnus-buffer-exists-p val))
221 (setq new-format (symbol-value
222 (intern (format "gnus-%s-line-format" type)))))
223 (setq entry (cdr (assq type gnus-format-specs)))
225 (equal (car entry) new-format))
226 ;; Use the old format.
227 (set (intern (format "gnus-%s-line-format-spec" type))
229 ;; This is a new format.
231 (if (not (stringp new-format))
232 ;; This is a function call or something.
234 ;; This is a "real" format.
238 (intern (format "gnus-%s-line-format-alist" type)))
239 (not (string-match "mode$" (symbol-name type))))))
240 ;; Enter the new format spec into the list.
243 (setcar (cdr entry) val)
244 (setcar entry new-format))
245 (push (list type new-format val) gnus-format-specs))
246 (set (intern (format "gnus-%s-line-format-spec" type)) val)
247 (push type updated))))
249 (unless (assq 'version gnus-format-specs)
250 (push (cons 'version emacs-version) gnus-format-specs))
253 (defvar gnus-mouse-face-0 'highlight)
254 (defvar gnus-mouse-face-1 'highlight)
255 (defvar gnus-mouse-face-2 'highlight)
256 (defvar gnus-mouse-face-3 'highlight)
257 (defvar gnus-mouse-face-4 'highlight)
259 (defun gnus-mouse-face-function (form type)
260 `(gnus-put-text-property
261 (point) (progn ,@form (point))
265 `(quote ,(symbol-value (intern (format "gnus-mouse-face-%d" type)))))))
267 (defvar gnus-face-0 'bold)
268 (defvar gnus-face-1 'italic)
269 (defvar gnus-face-2 'bold-italic)
270 (defvar gnus-face-3 'bold)
271 (defvar gnus-face-4 'bold)
273 (defun gnus-face-face-function (form type)
274 `(gnus-add-text-properties
275 (point) (progn ,@form (point))
276 '(gnus-face t face ,(symbol-value (intern (format "gnus-face-%d" type))))))
278 (defun gnus-balloon-face-function (form type)
279 `(gnus-put-text-property
280 (point) (progn ,@form (point))
281 ,(if (fboundp 'balloon-help-mode)
284 ,(intern (format "gnus-balloon-face-%d" type))))
286 (defun gnus-spec-tab (column)
288 `(insert-char ? (max (- ,column (current-column)) 0))
289 (let ((column (abs column)))
290 `(if (> (current-column) ,column)
292 (if (= (move-to-column ,column) ,column)
293 (delete-region (point) end)
294 (delete-region (1- (point)) end)
296 (insert-char ? (max (- ,column (current-column)) 0))))))
298 (defun gnus-correct-length (string)
299 "Return the correct width of STRING."
301 (mapcar (lambda (char) (incf length (char-width char))) string)
304 (defun gnus-correct-substring (string start &optional end)
309 (length (length string))
310 (string (concat string "\0")))
311 ;; Find the start position.
312 (while (and (< seek length)
314 (incf wseek (char-width (aref string seek)))
317 ;; Find the end position.
318 (while (and (<= seek length)
321 (incf wseek (char-width (aref string seek)))
324 (substring string wstart (1- wend))))
326 (defun gnus-string-width-function ()
328 (gnus-use-correct-string-widths
329 'gnus-correct-length)
330 ((fboundp 'string-width)
335 (defun gnus-substring-function ()
337 (gnus-use-correct-string-widths
338 'gnus-correct-substring)
339 ((fboundp 'string-width)
340 'gnus-correct-substring)
344 (defun gnus-tilde-max-form (el max-width)
345 "Return a form that limits EL to MAX-WIDTH."
346 (let ((max (abs max-width))
347 (length-fun (gnus-string-width-function))
348 (substring-fun (gnus-substring-function)))
350 `(if (> (,length-fun ,el) ,max)
352 `(,substring-fun ,el (- (,length-fun ,el) ,max))
353 `(,substring-fun ,el 0 ,max))
355 `(let ((val (eval ,el)))
356 (if (> (,length-fun val) ,max)
358 `(,substring-fun val (- (,length-fun val) ,max))
359 `(,substring-fun val 0 ,max))
362 (defun gnus-tilde-cut-form (el cut-width)
363 "Return a form that cuts CUT-WIDTH off of EL."
364 (let ((cut (abs cut-width))
365 (length-fun (gnus-string-width-function))
366 (substring-fun (gnus-substring-function)))
368 `(if (> (,length-fun ,el) ,cut)
370 `(,substring-fun ,el 0 (- (,length-fun ,el) ,cut))
371 `(,substring-fun ,el ,cut))
373 `(let ((val (eval ,el)))
374 (if (> (,length-fun val) ,cut)
376 `(,substring-fun val 0 (- (,length-fun val) ,cut))
377 `(,substring-fun val ,cut))
380 (defun gnus-tilde-ignore-form (el ignore-value)
381 "Return a form that is blank when EL is IGNORE-VALUE."
383 `(if (equal ,el ,ignore-value)
385 `(let ((val (eval ,el)))
386 (if (equal val ,ignore-value)
389 (defun gnus-pad-form (el pad-width)
390 "Return a form that pads EL to PAD-WIDTH accounting for multi-column
391 characters correctly. This is because `format' may pad to columns or to
392 characters when given a pad value."
393 (let ((pad (abs pad-width))
394 (side (< 0 pad-width))
395 (length-fun (gnus-string-width-function)))
397 `(let ((need (- ,pad (,length-fun ,el))))
399 (concat ,(when side '(make-string need ?\ ))
401 ,(when (not side) '(make-string need ?\ )))
403 `(let* ((val (eval ,el))
404 (need (- ,pad (,length-fun val))))
406 (concat ,(when side '(make-string need ?\ ))
408 ,(when (not side) '(make-string need ?\ )))
411 (defun gnus-parse-format (format spec-alist &optional insert)
412 ;; This function parses the FORMAT string with the help of the
413 ;; SPEC-ALIST and returns a list that can be eval'ed to return the
414 ;; string. If the FORMAT string contains the specifiers %( and %)
415 ;; the text between them will have the mouse-face text property.
416 ;; If the FORMAT string contains the specifiers %[ and %], the text between
417 ;; them will have the balloon-help text property.
418 (let ((case-fold-search nil))
420 "\\`\\(.*\\)%[0-9]?[{(«]\\(.*\\)%[0-9]?[»})]\\(.*\n?\\)\\'\\|%[-0-9]*=\\|%[-0-9]*\\*"
422 (gnus-parse-complex-format format spec-alist)
423 ;; This is a simple format.
424 (gnus-parse-simple-format format spec-alist insert))))
426 (defun gnus-parse-complex-format (format spec-alist)
427 (let ((cursor-spec nil))
429 (gnus-set-work-buffer)
431 (goto-char (point-min))
432 (while (re-search-forward "\"" nil t)
433 (replace-match "\\\"" nil t))
434 (goto-char (point-min))
436 ;; Convert all font specs into font spec lists.
437 (while (re-search-forward "%\\([0-9]+\\)?\\([«»{}()]\\)" nil t)
438 (let ((number (if (match-beginning 1)
439 (match-string 1) "0"))
440 (delim (aref (match-string 2) 0)))
441 (if (or (= delim ?\()
444 (replace-match (concat "\"("
445 (cond ((= delim ?\() "mouse")
446 ((= delim ?\{) "face")
450 (replace-match "\")\""))))
451 (goto-char (point-max))
453 ;; Convert point position commands.
454 (goto-char (point-min))
455 (let ((case-fold-search nil))
456 (while (re-search-forward "%\\([-0-9]+\\)?\\*" nil t)
457 (replace-match "\"(point)\"" t t)
458 (setq cursor-spec t)))
459 ;; Convert TAB commands.
460 (goto-char (point-min))
461 (while (re-search-forward "%\\([-0-9]+\\)=" nil t)
462 (replace-match (format "\"(tab %s)\"" (match-string 1)) t t))
463 ;; Convert the buffer into the spec.
464 (goto-char (point-min))
465 (let ((form (read (current-buffer))))
467 `(let (gnus-position)
468 ,@(gnus-complex-form-to-spec form spec-alist)
470 (gnus-put-text-property gnus-position (1+ gnus-position)
473 ,@(gnus-complex-form-to-spec form spec-alist)))))))
475 (defun gnus-complex-form-to-spec (form spec-alist)
481 (gnus-parse-simple-format sform spec-alist t))
482 ((eq (car sform) 'point)
483 '(setq gnus-position (point)))
484 ((eq (car sform) 'tab)
485 (gnus-spec-tab (cadr sform)))
487 (funcall (intern (format "gnus-%s-face-function" (car sform)))
488 (gnus-complex-form-to-spec (cddr sform) spec-alist)
493 (defun gnus-xmas-format (fstring &rest args)
494 "A version of `format' which preserves text properties.
496 Required for XEmacs, where the built in `format' function strips all text
497 properties from both the format string and any inserted strings.
499 Only supports the format sequence %s, and %% for inserting
500 literal % characters. A pad width and an optional - (to right pad)
501 are supported for %s."
502 (let ((re "%%\\|%\\(-\\)?\\([1-9][0-9]*\\)?s")
506 (goto-char (point-min))
507 (while (re-search-forward re nil t)
508 (goto-char (match-end 0))
510 ((string= (match-string 0) "%%")
514 (error 'wrong-number-of-arguments #'my-format n fstring))
515 (let* ((minlen (string-to-number (or (match-string 2) "")))
517 (str (if (stringp arg) arg (format "%s" arg)))
518 (lpad (null (match-string 1)))
519 (padlen (max 0 (- minlen (length str)))))
521 (if lpad (insert-char ?\ padlen))
523 (unless lpad (insert-char ?\ padlen))
524 (setq args (cdr args))))))
527 (defun gnus-parse-simple-format (format spec-alist &optional insert)
528 ;; This function parses the FORMAT string with the help of the
529 ;; SPEC-ALIST and returns a list that can be eval'ed to return a
532 spec flist fstring elem result dontinsert user-defined
533 type value pad-width spec-beg cut-width ignore-value
534 tilde-form tilde elem-type extended-spec)
536 (gnus-set-work-buffer)
538 (goto-char (point-min))
539 (while (re-search-forward "%" nil t)
540 (setq user-defined nil
548 (setq spec-beg (1- (point)))
550 ;; Parse this spec fully.
553 ((looking-at "\\([-.0-9]+\\)\\(,[-0-9]+\\)?")
554 (setq pad-width (string-to-number (match-string 1)))
555 (when (match-beginning 2)
556 (setq max-width (string-to-number (buffer-substring
557 (1+ (match-beginning 2))
559 (goto-char (match-end 0)))
562 (setq tilde (read (current-buffer))
566 ((memq type '(pad pad-left))
567 (setq pad-width value))
568 ((eq type 'pad-right)
569 (setq pad-width (- value)))
570 ((memq type '(max-right max))
571 (setq max-width value))
573 (setq max-width (- value)))
574 ((memq type '(cut cut-left))
575 (setq cut-width value))
576 ((eq type 'cut-right)
577 (setq cut-width (- value)))
580 (if (stringp value) value (format "%s" value))))
582 (setq tilde-form value))
584 (error "Unknown tilde type: %s" tilde)))
589 ;; User-defined spec -- find the spec name.
590 ((eq (setq spec (char-after)) ?u)
592 (when (and (eq (setq user-defined (char-after)) ?&)
593 (looking-at "&\\([^;]+\\);"))
594 (setq user-defined (match-string 1))
595 (goto-char (match-end 1))))
597 ((and (eq spec ?&) (looking-at "&\\([^;]+\\);"))
598 (setq extended-spec (intern (match-string 1)))
599 (goto-char (match-end 1))))
601 (delete-region spec-beg (point))
603 ;; Now we have all the relevant data on this spec, so
604 ;; we start doing stuff.
607 ;; "%%" just results in a "%".
612 (setq elem (list tilde-form ?s)))
613 ;; Treat user defined format specifiers specially.
617 (list (intern (format
618 (if (stringp user-defined)
619 "gnus-user-format-function-%s"
620 "gnus-user-format-function-%c")
624 ;; Find the specification from `spec-alist'.
625 ((setq elem (cdr (assq (or extended-spec spec) spec-alist))))
626 ;; We used to use "%l" for displaying the grouplens score.
628 (setq elem '("" ?s)))
630 (setq elem '("*" ?s))))
631 (setq elem-type (cadr elem))
632 ;; Insert the new format elements.
634 (not (and (featurep 'xemacs)
635 gnus-use-correct-string-widths)))
636 (insert (number-to-string pad-width)))
637 ;; Create the form to be evaled.
638 (if (or max-width cut-width ignore-value
639 (and (featurep 'xemacs)
640 gnus-use-correct-string-widths))
643 (let ((el (car elem)))
644 (cond ((= (cadr elem) ?c)
645 (setq el (list 'char-to-string el)))
647 (setq el (list 'int-to-string el))))
649 (setq el (gnus-tilde-ignore-form el ignore-value)))
651 (setq el (gnus-tilde-cut-form el cut-width)))
653 (setq el (gnus-tilde-max-form el max-width)))
655 (setq el (gnus-pad-form el pad-width)))
658 (push (car elem) flist))))
659 (setq fstring (buffer-substring-no-properties (point-min) (point-max))))
661 ;; Do some postprocessing to increase efficiency.
666 ((string= fstring "")
668 ;; Not a format string.
669 ((not (string-match "%" fstring))
671 ;; A format string with just a single string spec.
672 ((string= fstring "%s")
674 ;; A single character.
675 ((string= fstring "%c")
678 ((string= fstring "%d")
681 (list `(princ ,(car flist)))
682 (list `(int-to-string ,(car flist)))))
683 ;; Just lots of chars and strings.
684 ((string-match "\\`\\(%[cs]\\)+\\'" fstring)
686 ;; A single string spec at the beginning of the spec.
687 ((string-match "\\`%[sc][^%]+\\'" fstring)
688 (list (car flist) (substring fstring 2)))
689 ;; A single string spec in the middle of the spec.
690 ((string-match "\\`\\([^%]+\\)%[sc]\\([^%]+\\)\\'" fstring)
691 (list (match-string 1 fstring) (car flist) (match-string 2 fstring)))
692 ;; A single string spec in the end of the spec.
693 ((string-match "\\`\\([^%]+\\)%[sc]\\'" fstring)
694 (list (match-string 1 fstring) (car flist)))
695 ;; Only string (and %) specs (XEmacs only!)
696 ((and (featurep 'xemacs)
697 gnus-make-format-preserve-properties
699 "\\`\\([^%]*\\(%%\\|%-?\\([1-9][0-9]*\\)?s\\)\\)*[^%]*\\'"
701 (list (cons 'gnus-xmas-format (cons fstring (nreverse flist)))))
702 ;; A more complex spec.
704 (list (cons 'format (cons fstring (nreverse flist)))))))
710 (cons 'insert result)))
711 (cond ((stringp result)
714 (cons 'concat result))
717 (defun gnus-eval-format (format &optional alist props)
718 "Eval the format variable FORMAT, using ALIST.
719 If PROPS, insert the result."
720 (let ((form (gnus-parse-format format alist props)))
722 (gnus-add-text-properties (point) (progn (eval form) (point)) props)
725 (defun gnus-compile ()
726 "Byte-compile the user-defined format specs."
729 (let ((entries gnus-format-specs)
730 (byte-compile-warnings '(unresolved callargs redefine))
733 (gnus-message 7 "Compiling format specs...")
736 (setq entry (pop entries))
737 (if (memq (car entry) '(gnus-version version))
738 (setq gnus-format-specs (delq entry gnus-format-specs))
739 (let ((form (caddr entry)))
740 (when (and (listp form)
741 ;; Under GNU Emacs, it's (byte-code ...)
742 (not (eq 'byte-code (car form)))
743 ;; Under XEmacs, it's (funcall #<compiled-function ...>)
744 (not (and (eq 'funcall (car form))
745 (byte-code-function-p (cadr form)))))
746 (defalias 'gnus-tmp-func `(lambda () ,form))
747 (byte-compile 'gnus-tmp-func)
748 (setcar (cddr entry) (gnus-byte-code 'gnus-tmp-func))))))
750 (push (cons 'version emacs-version) gnus-format-specs)
751 ;; Mark the .newsrc.eld file as "dirty".
753 (gnus-message 7 "Compiling user specs...done"))))
755 (defun gnus-set-format (type &optional insertable)
756 (set (intern (format "gnus-%s-line-format-spec" type))
758 (symbol-value (intern (format "gnus-%s-line-format" type)))
759 (symbol-value (intern (format "gnus-%s-line-format-alist" type)))
765 ;; coding: iso-8859-1
768 ;;; arch-tag: a4328fa1-1f84-4b09-97ad-4b5767cfd50f
769 ;;; gnus-spec.el ends here